Changeset 6687135

Timestamp:

Jul 27, 2010, 9:10:44 PM (14 years ago)

Author:

Nelson Elhage <nelhage@mit.edu>

Branches:

release-1.6

Children:

af16ad3

Parents:

26a1398

git-author:

Nelson Elhage <nelhage@mit.edu> (07/15/10 23:38:45)

git-committer:

Nelson Elhage <nelhage@mit.edu> (07/27/10 21:10:44)

Message:

Open the debug file using O_EXCL and an explicit mode.

We write potentially sensitive data out to the debug log, so we should protect
it.

Reported-by: Geoffrey Thomas <geofft@mit.edu>

File:

• global.c (modified) (1 diff)

global.c

@@ -1009 +1009 @@
   if (g->debug_file == NULL ||
       (open_file && strcmp(filename, open_file) != 0)) {
+    int fd;
+
     if (g->debug_file)
       fclose(g->debug_file);
-    g->debug_file = fopen(filename, "a");
+
+    g->debug_file = NULL;
+
+    fd = open(filename, O_CREAT|O_WRONLY|O_EXCL, 0600);
+    if (fd >= 0)
+      g->debug_file = fdopen(fd, "a");
 
     owl_free(open_file);