Changeset e3cbd65cfe991b0f4d6b753d76dc9e1157caa634

Timestamp:

10/26/09 16:09:38 (4 weeks ago)

Author:

David Benjamin <davidben@mit.edu>

git-author:

David Benjamin <davidben@mit.edu> / 2009-10-05T22:53:21Z-0400

Parents:

3cc4bfc144304de096deb510403db0c38a62af68

Children:

fe7616e5988beed102273ee0ed321a352ba80297

git-committer:

David Benjamin <davidben@mit.edu> / 2009-10-26T16:09:38Z-0400

Message:

Use owl_new_av in exported functions

Simplified all_variables, all_filters, and all_styles.

Signed-off-by: David Benjamin <davidben@mit.edu>

Files:

• perlglue.xs (modified) (3 diffs)

perlglue.xs

@@ -334 +334 @@
 all_filters()
         PREINIT:
-                AV *filters;
                 const owl_list *fl;
-                const owl_filter *f;
-                int i;
         CODE:
         {
                 fl = owl_global_get_filterlist(&g);
-                filters = newAV();
-                for(i=0;i<owl_list_get_size(fl);i++) {
-                        f = owl_list_get_element(fl, i);
-                        av_push(filters, owl_new_sv(owl_filter_get_name(f)));
-                }
-                RETVAL = filters;
+                RETVAL = owl_new_av(fl, (SV*(*)(const void*))owl_filter_to_sv);
                 sv_2mortal((SV*)RETVAL);
         }
@@ -355 +347 @@
 all_styles()
         PREINIT:
-                AV *styles;
                 owl_list l;
-                const char *name;
-                int i;
         CODE:
         {
                 owl_list_create(&l);
                 owl_global_get_style_names(&g, &l);
-                styles = newAV();
-                for(i=0;i<owl_list_get_size(&l);i++) {
-                        name = owl_list_get_element(&l, i);
-                        av_push(styles, owl_new_sv(name));
-                }
-                RETVAL = styles;
+                RETVAL = owl_new_av(&l, (SV*(*)(const void*))owl_new_sv);
                 sv_2mortal((SV*)RETVAL);
         }
@@ -380 +364 @@
 all_variables()
         PREINIT:
-                AV *vars;
                 owl_list l;
-                const char *name;
-                int i;
         CODE:
         {
                 owl_list_create(&l);
                 owl_dict_get_keys(owl_global_get_vardict(&g), &l);
-                vars = newAV();
-                for(i=0;i<owl_list_get_size(&l);i++) {
-                        name = owl_list_get_element(&l, i);
-                        av_push(vars, owl_new_sv(name));
-                }
-                RETVAL = vars;
+                RETVAL = owl_new_av(&l, (SV*(*)(const void*))owl_new_sv);
                 sv_2mortal((SV*)RETVAL);
         }