Changeset 044f19f


Ignore:
Timestamp:
Jun 12, 2010, 3:29:01 PM (11 years ago)
Author:
David Benjamin <davidben@mit.edu>
Branches:
master, release-1.7, release-1.8, release-1.9
Children:
ea7daa8
Parents:
e92e2a1
git-author:
David Benjamin <davidben@mit.edu> (06/12/10 01:49:55)
git-committer:
David Benjamin <davidben@mit.edu> (06/12/10 15:29:01)
Message:
Don't use signals for dirtying the sepbar

I'm less convinced the correct code looks substantially different here,
but the first iteration should not have this globalnotifier.
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • cmd.c

    r94be4a8 r044f19f  
    7474  } else if (NULL != (cmd = owl_dict_find_element(cd, argv[0]))) {
    7575    retval = owl_cmd_execute(cmd, cd, ctx, argc, argv, buff);
    76     /* This really should be attached to the cmd or cmddict... */
    77     owl_global_notifier_emit_command_executed(g.gn);
     76    /* redraw the sepbar; TODO: don't violate layering */
     77    owl_global_sepbar_dirty(&g);
    7878  } else {
    7979    owl_function_makemsg("Unknown command '%s'.", buff);
  • global.c

    re92e2a1 r044f19f  
    141141}
    142142
     143void owl_global_sepbar_dirty(owl_global *g)
     144{
     145  owl_window_dirty(g->mainpanel.sepwin);
     146}
     147
    143148/* Called once perl has been initialized */
    144149void owl_global_complete_setup(owl_global *g)
  • owl.c

    r07b59ea r044f19f  
    271271  /* log the message if we need to */
    272272  owl_log_message(m);
    273   /* emit a signal for listeners */
    274   owl_global_notifier_emit_message_received(g.gn, m);
     273  /* redraw the sepbar; TODO: don't violate layering */
     274  owl_global_sepbar_dirty(&g);
    275275
    276276  return 1;
  • sepbar.c

    r94be4a8 r044f19f  
    66{
    77  g_signal_connect(w, "redraw", G_CALLBACK(sepbar_redraw), NULL);
    8   owl_dirty_window_on_signal(w, g.gn, "message-received");
    9   owl_dirty_window_on_signal(w, g.gn, "command-executed");
     8  /* TODO: handle dirtiness in the sepbar */
    109  owl_window_dirty(w);
    1110}
Note: See TracChangeset for help on using the changeset viewer.