Changeset 044f19f

Timestamp:

Jun 12, 2010, 3:29:01 PM (14 years ago)

Author:

David Benjamin <davidben@mit.edu>

Branches:

master, release-1.10, release-1.7, release-1.8, release-1.9

Children:

ea7daa8

Parents:

e92e2a1

git-author:

David Benjamin <davidben@mit.edu> (06/12/10 01:49:55)

git-committer:

David Benjamin <davidben@mit.edu> (06/12/10 15:29:01)

Message:

Don't use signals for dirtying the sepbar

I'm less convinced the correct code looks substantially different here,
but the first iteration should not have this globalnotifier.

Files:

• cmd.c (modified) (1 diff)
• global.c (modified) (1 diff)
• owl.c (modified) (1 diff)
• sepbar.c (modified) (1 diff)

cmd.c

@@ -74 +74 @@
   } else if (NULL != (cmd = owl_dict_find_element(cd, argv[0]))) {
     retval = owl_cmd_execute(cmd, cd, ctx, argc, argv, buff);
-    /* This really should be attached to the cmd or cmddict... */
-    owl_global_notifier_emit_command_executed(g.gn);
+    /* redraw the sepbar; TODO: don't violate layering */
+    owl_global_sepbar_dirty(&g);
   } else {
     owl_function_makemsg("Unknown command '%s'.", buff);

global.c

@@ -141 +141 @@
 }
 
+void owl_global_sepbar_dirty(owl_global *g)
+{
+  owl_window_dirty(g->mainpanel.sepwin);
+}
+
 /* Called once perl has been initialized */
 void owl_global_complete_setup(owl_global *g)

owl.c

@@ -271 +271 @@
   /* log the message if we need to */
   owl_log_message(m);
-  /* emit a signal for listeners */
-  owl_global_notifier_emit_message_received(g.gn, m);
+  /* redraw the sepbar; TODO: don't violate layering */
+  owl_global_sepbar_dirty(&g);
 
   return 1;

sepbar.c

@@ -6 +6 @@
 {
   g_signal_connect(w, "redraw", G_CALLBACK(sepbar_redraw), NULL);
-  owl_dirty_window_on_signal(w, g.gn, "message-received");
-  owl_dirty_window_on_signal(w, g.gn, "command-executed");
+  /* TODO: handle dirtiness in the sepbar */
   owl_window_dirty(w);
 }