Changeset 10b866d

Timestamp:

Jul 8, 2002, 10:37:21 PM (22 years ago)

Author:

Erik Nygren <nygren@mit.edu>

Branches:

master, barnowl_perlaim, debian, owl, release-1.10, release-1.4, release-1.5, release-1.6, release-1.7, release-1.8, release-1.9

Children:

e1c4636

Parents:

8df36cc

Message:

* Fixed preservation of e->dotsend across owl_editwin_clear().

* Added history for multiline edit windows (eg, for zephyr composition).
  The M-n and M-p keys will cycle through the history ring.
  In particular, it is now possible to edit the command line
  of a zephyr being composed:  C-c it and restart it
  and then M-p to get the aborted composition back.

Files:

• ChangeLog (modified) (1 diff)
• commands.c (modified) (6 diffs)
• context.c (modified) (1 diff)
• editwin.c (modified) (9 diffs)
• functions.c (modified) (3 diffs)
• global.c (modified) (3 diffs)
• history.c (modified) (5 diffs)
• keymap.c (modified) (3 diffs)
• keys.c (modified) (1 diff)
• owl.h (modified) (3 diffs)
• util.c (modified) (1 diff)

ChangeLog

@@ -28 +28 @@
         Always clear the command buffer before executing the command.
                 (So that interactive commands can sanely do start-command.)
-
+        Fixed preservation of e->dotsend across owl_editwin_clear().
+        Added history for multiline edit windows (eg, for zephyr composition).
+                The M-n and M-p keys will cycle through the history ring.
+                In particular, it is now possible to edit the command line
+                of a zephyr being composed:  C-c it and restart it 
+                and then M-p to get the aborted composition back.
+        
 1.2.1-pre-1
         Added RCS Id strings to all files.

commands.c

@@ -593 +593 @@
 
   OWLCMD_VOID_CTX("edit:history-next", owl_command_edit_history_next, 
-                  OWL_CTX_EDITLINE,
+                  OWL_CTX_EDIT,
                   "replaces the text with the previous history",
                   "", ""),
 
   OWLCMD_VOID_CTX("edit:history-prev", owl_command_edit_history_prev, 
-                  OWL_CTX_EDITLINE,
+                  OWL_CTX_EDIT,
                   "replaces the text with the previous history",
                   "", ""),
@@ -1478 +1478 @@
 
 void owl_command_edit_cancel(owl_editwin *e) {
+  owl_history *hist;
+
   owl_function_makemsg("Command cancelled.");
+
+  hist=owl_editwin_get_history(e);
+  owl_history_store(hist, owl_editwin_get_text(e));
+  owl_history_reset(hist);
+
   owl_editwin_fullclear(e);
   owl_global_set_needrefresh(&g);
   wnoutrefresh(owl_editwin_get_curswin(e));
   owl_global_set_typwin_inactive(&g);
-  owl_editwin_new_style(e, OWL_EDITWIN_STYLE_ONELINE);
+  owl_editwin_new_style(e, OWL_EDITWIN_STYLE_ONELINE, NULL);
 }
 
@@ -1490 +1497 @@
   char *ptr;
 
-  hist=owl_global_get_history(&g);
+  hist=owl_editwin_get_history(e);
   if (!owl_history_is_touched(hist)) {
     owl_history_store(hist, owl_editwin_get_text(e));
@@ -1510 +1517 @@
   char *ptr;
 
-  hist=owl_global_get_history(&g);
+  hist=owl_editwin_get_history(e);
   ptr=owl_history_get_next(hist);
   if (ptr) {
@@ -1531 +1538 @@
 
 void owl_command_editline_done(owl_editwin *e) {
-  owl_history *hist=owl_global_get_history(&g);
+  owl_history *hist=owl_editwin_get_history(e);
   char *rv, *cmd;
 
-  owl_global_set_typwin_inactive(&g);
   owl_history_store(hist, owl_editwin_get_text(e));
   owl_history_reset(hist);
+  owl_global_set_typwin_inactive(&g);
   cmd = owl_strdup(owl_editwin_get_text(e));
   owl_editwin_fullclear(e);
@@ -1552 +1559 @@
 
 void owl_command_editmulti_done(owl_editwin *e) {
+  owl_history *hist=owl_editwin_get_history(e);
+
+  owl_history_store(hist, owl_editwin_get_text(e));
+  owl_history_reset(hist);
+
   owl_function_run_buffercommand();
-  owl_editwin_new_style(e, OWL_EDITWIN_STYLE_ONELINE);
+  owl_editwin_new_style(e, OWL_EDITWIN_STYLE_ONELINE, NULL);
   owl_editwin_fullclear(e);
   owl_global_set_typwin_inactive(&g);

context.c

@@ -16 +16 @@
 /* returns whether test matches the current context */
 int owl_context_matches(owl_context *ctx, int test) {
-  owl_function_debugmsg(", current: 0x%04x test: 0x%04x\n", ctx->mode, test);
+  /*owl_function_debugmsg(", current: 0x%04x test: 0x%04x\n", ctx->mode, test);*/
   if ((((ctx->mode&OWL_CTX_MODE_BITS) & test)
        || !(test&OWL_CTX_MODE_BITS))

editwin.c

@@ -3 +3 @@
 #include <unistd.h>
 #include <string.h>
+#include <ctype.h>
 
 static const char fileIdent[] = "$Id$";
@@ -8 +9 @@
 #define INCR 5000
 
-void owl_editwin_init(owl_editwin *e, WINDOW *win, int winlines, int wincols, int style) {
+void owl_editwin_init(owl_editwin *e, WINDOW *win, int winlines, int wincols, int style, owl_history *hist) {
   /* initialize the editwin e.
    * 'win' is an already initialzed curses window that will be used by editwin
    */
-  e->buff=owl_malloc(INCR);
+  e->buff=owl_malloc(INCR);  
   e->buff[0]='\0';
   e->bufflen=0;
+  e->hist=hist;
   e->allocated=INCR;
   e->buffx=0;
@@ -50 +52 @@
 }
 
+void owl_editwin_set_history(owl_editwin *e, owl_history *h) {
+  e->hist = h;
+}
+
+owl_history *owl_editwin_get_history(owl_editwin *e) {
+  return e->hist;
+}
+
 void owl_editwin_set_dotsend(owl_editwin *e) {
   e->dotsend=1;
@@ -85 +95 @@
 }
 
-void owl_editwin_new_style(owl_editwin *e, int newstyle) {
+void owl_editwin_new_style(owl_editwin *e, int newstyle, owl_history *h) {
   char *ptr;
-  
+
+  owl_editwin_set_history(e, h);
   if (e->style==newstyle) return;
 
@@ -111 +122 @@
   /* completly reinitialize the buffer */
   owl_free(e->buff);
-  owl_editwin_init(e, e->curswin, e->winlines, e->wincols, e->style);
+  owl_editwin_init(e, e->curswin, e->winlines, e->wincols, e->style, e->hist);
 }
 
@@ -117 +128 @@
   /* clear all text except for locktext and put the cursor at the beginning */
   int lock;
+  int dotsend=e->dotsend;
   char *locktext=NULL;
-  
+
   lock=0;
   if (e->lock > 0) {
@@ -129 +141 @@
 
   owl_free(e->buff);
-  owl_editwin_init(e, e->curswin, e->winlines, e->wincols, e->style);
+  owl_editwin_init(e, e->curswin, e->winlines, e->wincols, e->style, e->hist);
 
   if (lock > 0) {
     owl_editwin_set_locktext(e, locktext);
+  }
+  if (dotsend) {
+    owl_editwin_set_dotsend(e);
   }
 
@@ -742 +757 @@
 /* returns if only whitespace remains */
 int owl_editwin_is_at_end(owl_editwin *e) {
-  int i, cur;  
-  cur=_owl_editwin_get_index_from_xy(e);
-  if (cur >= e->bufflen) return(1);
-  for (i=e->bufflen-1; i>cur; i--) {
-    if (e->buff[i] != '\r'
-        && e->buff[i] != '\n'
-        && e->buff[i] != ' ') {
-      return(0);
-    }
-  }
-  if (cur==i) return(1);
-  else return(0);
+  int cur=_owl_editwin_get_index_from_xy(e);
+  return only_whitespace(e->buff+cur);
 }
 
@@ -768 +773 @@
       return(1);
     }
-    if (e->buff[i] != '\r'
-        && e->buff[i] != '\n'
-        && e->buff[i] != ' ') {
+    if (!isspace(e->buff[i])) {
       return(0);
     }

functions.c

@@ -124 +124 @@
   /* create and setup the editwin */
   e=owl_global_get_typwin(&g);
-  owl_editwin_new_style(e, OWL_EDITWIN_STYLE_MULTILINE);
+  owl_editwin_new_style(e, OWL_EDITWIN_STYLE_MULTILINE,
+                        owl_global_get_msg_history(&g));
 
   if (!owl_global_get_lockout_ctrld(&g)) {
@@ -1416 +1417 @@
 
       if (enter) {
-        owl_history_store(owl_global_get_history(&g), buff);
-        owl_function_zwrite_setup(buff);
-        owl_global_set_buffercommand(&g, buff);
+        owl_history *hist = owl_global_get_cmd_history(&g);
+        owl_history_store(hist, buff);
+        owl_history_reset(hist);
+        owl_function_command_norv(buff);
       } else {
         owl_function_start_command(buff);
@@ -1447 +1449 @@
   tw=owl_global_get_typwin(&g);
   owl_global_set_typwin_active(&g);
+  owl_editwin_new_style(tw, OWL_EDITWIN_STYLE_ONELINE, 
+                        owl_global_get_cmd_history(&g));
+
   owl_editwin_set_locktext(tw, "command: ");
   owl_global_set_needrefresh(&g);

global.c

@@ -42 +42 @@
   g->rightshift=0;
 
-  owl_editwin_init(&(g->tw), NULL, owl_global_get_typwin_lines(g), g->cols, OWL_EDITWIN_STYLE_ONELINE);
+  owl_editwin_init(&(g->tw), NULL, owl_global_get_typwin_lines(g), g->cols, OWL_EDITWIN_STYLE_ONELINE, NULL);
 
   owl_keyhandler_init(&g->kh);
@@ -65 +65 @@
   owl_global_set_userclue(g, OWL_USERCLUE_NONE);
   owl_global_set_no_have_config(g);
-  owl_history_init(&(g->hist));
+  owl_history_init(&(g->msghist));
+  owl_history_init(&(g->cmdhist));
   g->nextmsgid=0;
 
@@ -486 +487 @@
 /* history */
 
-owl_history *owl_global_get_history(owl_global *g) {
-  return(&(g->hist));
+owl_history *owl_global_get_msg_history(owl_global *g) {
+  return(&(g->msghist));
+}
+
+owl_history *owl_global_get_cmd_history(owl_global *g) {
+  return(&(g->cmdhist));
 }
 

history.c

@@ -5 +5 @@
 void owl_history_init(owl_history *h) {
   owl_list_create(&(h->hist));
-  h->cur=0;
-  h->touched=0;
-  h->partial=0;
+  h->cur=0;                     /* current position in history */
+  h->touched=0;                 /* whether we've gone into history */
+  h->partial=0;                 /* is the 0th element is partially composed? */
 }
 
 char *owl_history_get_prev(owl_history *h) {
+
+  if (!h) return NULL;
   h->touched=1;
 
@@ -20 +22 @@
 
   h->cur++;
+
   return(owl_list_get_element(&(h->hist), h->cur));
 }
 
 char *owl_history_get_next(owl_history *h) {
+  if (!h) return NULL;
   if (owl_list_get_size(&(h->hist))==0) return(NULL);
-
   if (h->cur==0) {
     return(NULL);
@@ -37 +40 @@
   int size;
 
+  if (!h) return;
+
   /* if partial is set, remove the first entry first */
   if (h->partial) {
     owl_list_remove_element(&(h->hist), 0);
   }
-    
+
   /* if we've reached the max history size, pop off the last element */
   size=owl_list_get_size(&(h->hist));
@@ -54 +59 @@
 
 void owl_history_set_partial(owl_history *h) {
+  if (!h) return;
   h->partial=1;
 }
 
 void owl_history_reset(owl_history *h) {
+  if (!h) return;
   h->cur=0;
   h->touched=0;
@@ -64 +71 @@
 
 int owl_history_is_touched(owl_history *h) {
+  if (!h) return(0);
   if (h->touched) return(1);
   return(0);

keymap.c

@@ -201 +201 @@
   }
 
-  owl_function_debugmsg("processkey: got key %d, active keymap %s, stack at %d",
-                        j, kh->active->name, kh->kpstackpos);
+  /*
+    owl_function_debugmsg("processkey: got key %d, active keymap %s, stack at %d",
+    j, kh->active->name, kh->kpstackpos);
+  */
 
   /* deal with ESC prefixing */
@@ -236 +238 @@
       match = owl_keybinding_match(kb, kh->kpstack);
       if (match == 1) {         /* subset match */
-        owl_function_debugmsg("processkey: found subset match in %s", km->name);
+
+        /* owl_function_debugmsg("processkey: found subset match in %s", km->name); */
         return(0);
       } else if (match == 2) {  /* exact match */
-        owl_function_debugmsg("processkey: found exact match in %s", km->name);
+        /* owl_function_debugmsg("processkey: found exact match in %s", km->name); */
         owl_keybinding_execute(kb, j);
         owl_keyhandler_reset(kh);
@@ -252 +255 @@
   /* see if a default action exists for the active keymap */
   if (kh->active->default_fn && kh->kpstackpos<1) {
-    owl_function_debugmsg("processkey: executing default_fn");
+    /*owl_function_debugmsg("processkey: executing default_fn");*/
+
     kh->active->default_fn(j);
     owl_keyhandler_reset(kh);

keys.c

@@ -93 +93 @@
   /* This would be nice, but interferes with C-c to cancel */
   /*BIND_CMD("C-c C-c", "editmulti:done", "sends the zephyr");*/
+
+  BIND_CMD("M-p",         "edit:history-prev", "");
+  BIND_CMD("M-n",         "edit:history-next", "");
 
   /* note that changing "disable-ctrl-d" to "on" will change this to 

owl.h

@@ -238 +238 @@
 } owl_mainwin;
 
-typedef struct _owl_editwin {
-  char *buff;
-  int bufflen;
-  int allocated;
-  int buffx, buffy;
-  int topline;
-  int winlines, wincols, fillcol, wrapcol;
-  WINDOW *curswin;
-  int style;
-  int lock;
-  int dotsend;
-} owl_editwin;
-
 typedef struct _owl_viewwin {
   owl_fmtext fmtext;
@@ -305 +292 @@
 } owl_history;
 
+typedef struct _owl_editwin {
+  char *buff;
+  owl_history *hist;
+  int bufflen;
+  int allocated;
+  int buffx, buffy;
+  int topline;
+  int winlines, wincols, fillcol, wrapcol;
+  WINDOW *curswin;
+  int style;
+  int lock;
+  int dotsend;
+} owl_editwin;
+
 typedef struct _owl_keybinding {
   int  *j;                      /* keypress stack (0-terminated) */  
@@ -334 +335 @@
   owl_mainwin mw;
   owl_popwin pw;
-  owl_history hist;
+  owl_history cmdhist;          /* command history */
+  owl_history msghist;          /* outgoing message history */
   owl_keyhandler kh;
   owl_list filterlist;

util.c

@@ -299 +299 @@
 }
 
+/* returns if a string is only whitespace */
+int only_whitespace(char *s) {
+  int i;
+  for (i=0; s[i]; i++) {
+    if (!isspace(s[i])) return(0);
+  }
+  return(1);
+}
 
 void *owl_malloc(size_t size) {