Changeset 125fd21

Timestamp:

Mar 29, 2010, 8:36:18 PM (15 years ago)

Author:

Nelson Elhage <nelhage@mit.edu>

Branches:

master, release-1.10, release-1.6, release-1.7, release-1.8, release-1.9

Children:

db4b293

Parents:

f25812b

git-author:

Nelson Elhage <nelhage@mit.edu> (03/22/10 22:03:53)

git-committer:

Nelson Elhage <nelhage@mit.edu> (03/29/10 20:36:18)

Message:

Fix a use-after-free in popexec.c

Fixes: #130

File:

• popexec.c (modified) (3 diffs)

popexec.c

@@ -96 +96 @@
   if (!pe->pid && !pe->winactive) {
     owl_select_remove_io_dispatch(d);
+    pe->dispatch = NULL;
     return;
   }
@@ -114 +115 @@
     }
     owl_select_remove_io_dispatch(d);
+    pe->dispatch = NULL;
     return;
   }
@@ -157 +159 @@
 
   pe->winactive = 0;
-  if (pe->dispatch->fd > 0) {
+  if (pe->dispatch) {
     owl_select_remove_io_dispatch(pe->dispatch);
+    pe->dispatch = NULL;
   }
   if (pe->pid) {