Changeset 1b6b2f3

Timestamp:

Oct 27, 2006, 1:17:18 PM (16 years ago)

Author:

Nelson Elhage <nelhage@mit.edu>

Branches:

master, barnowl_perlaim, debian, release-1.4, release-1.5, release-1.6, release-1.7, release-1.8, release-1.9

Children:

e74c01c

Parents:

dd16bdd

Message:

Refactoring the editwin code somewhat, and adding the ability to hang
arbitrary reply commands off of messages.

Files:

• commands.c (modified) (1 diff)
• functions.c (modified) (9 diffs)
• global.c (modified) (2 diffs)
• owl.h (modified) (2 diffs)
• perlglue.xs (modified) (3 diffs)

commands.c

@@ -2379 +2379 @@
   if (argc==2) {
     owl_global_set_buffercommand(&g, argv[1]);
-    owl_global_set_buffercallback(&g, owl_function_aimlogin);
+    owl_global_set_buffercallback(&g, &owl_callback_aimlogin);
     owl_function_start_password("AIM Password: ");
     return(NULL);

functions.c

@@ -320 +320 @@
 
   owl_global_set_buffercommand(&g, line);
-  owl_global_set_buffercallback(&g, &owl_function_zwrite);
+  owl_global_set_buffercallback(&g, &owl_callback_zwrite);
 }
 
@@ -351 +351 @@
 
   owl_global_set_buffercommand(&g, line);
-  owl_global_set_buffercallback(&g, &owl_function_aimwrite);
+  owl_global_set_buffercallback(&g, &owl_callback_aimwrite);
 }
 
@@ -376 +376 @@
 
   owl_global_set_buffercommand(&g, "loopwrite");
-  owl_global_set_buffercallback(&g, &owl_function_loopwrite);
+  owl_global_set_buffercallback(&g, &owl_callback_loopwrite);
+}
+
+void owl_callback_zwrite(owl_editwin *e) {
+  owl_function_zwrite(owl_editwin_get_command(e),
+                      owl_editwin_get_text(e));
 }
 
@@ -486 +491 @@
 }
 
+void owl_callback_aimwrite(owl_editwin *e) {
+  owl_function_aimwrite(owl_editwin_get_command(e),
+                        owl_editwin_get_text(e));
+}
+
 void owl_function_aimwrite(char *line, char *msg)
 {
@@ -562 +572 @@
 }
 
-void owl_function_loopwrite(char *line, char *msg)
+void owl_callback_loopwrite(owl_editwin *e) {
+  owl_function_loopwrite(owl_editwin_get_text(e));
+}
+
+void owl_function_loopwrite(char *msg)
 {
   owl_message *min, *mout;
@@ -932 +946 @@
     owl_function_error("Error subscribing to login messages from file.");
   }
+}
+
+void owl_callback_aimlogin(owl_editwin *e) {
+  owl_function_aimlogin(owl_editwin_get_command(e),
+                        owl_global_get_response(&g));
 }
 
@@ -1324 +1343 @@
 void owl_function_run_buffercommand()
 {
-  char *buff;
-  void (*cb)(char*, char*);
-
-  buff=owl_global_get_buffercommand(&g);
-  cb=owl_global_get_buffercallback(&g);
-  if(!cb) {
-    owl_function_error("Internal error: No callback for buffercommand %s", buff);
-  } else {
-    cb(buff, owl_editwin_get_text(owl_global_get_typwin(&g)));
-  }
+  owl_editwin_do_callback(owl_global_get_typwin(&g));
 }
 
@@ -2167 +2177 @@
       }
       if (cc) owl_free(cc);
-    }
-
-    /* aim */
-    if (owl_message_is_type_aim(m)) {
+    } else if (owl_message_is_type_aim(m)) {
+      /* aim */
       if (owl_message_is_direction_out(m)) {
         buff=owl_sprintf("aimwrite %s", owl_message_get_recipient(m));
@@ -2176 +2184 @@
         buff=owl_sprintf("aimwrite %s", owl_message_get_sender(m));
       }
-    }
-    
+    } else {
+      char *cmd;
+      if((type==0 && (cmd=owl_message_get_attribute_value(m, "replycmd")))
+         || (type==1 && (cmd=owl_message_get_attribute_value(m, "replysendercmd")))) {
+        buff = owl_strdup(cmd);
+      }
+    }
+
     if (enter) {
       owl_history *hist = owl_global_get_cmd_history(&g);

global.c

@@ -68 +68 @@
   g->searchstring=NULL;
   g->starttime=time(NULL); /* assumes we call init only a start time */
-  g->buffercommand=NULL;
   g->newmsgproc_pid=0;
   
@@ -241 +240 @@
 
 void owl_global_set_buffercommand(owl_global *g, char *command) {
-  if (g->buffercommand) owl_free(g->buffercommand);
-  g->buffercommand=owl_strdup(command);
+  owl_editwin_set_command(owl_global_get_typwin(g), command);
 }
 
 char *owl_global_get_buffercommand(owl_global *g) {
-  if (g->buffercommand) return(g->buffercommand);
-  return("");
-}
-
-void owl_global_set_buffercallback(owl_global *g, void (*cb)(char*,char*)) {
-  g->buffercallback = cb;
-}
-
-void (*owl_global_get_buffercallback(owl_global *g))(char*,char*) {
-  return g->buffercallback;
+  return owl_editwin_get_command(owl_global_get_typwin(g));
+}
+
+void owl_global_set_buffercallback(owl_global *g, void (*cb)(owl_editwin*)) {
+  owl_editwin_set_callback(owl_global_get_typwin(g), cb);
+}
+
+void (*owl_global_get_buffercallback(owl_global *g))(owl_editwin*) {
+  return owl_editwin_get_callback(owl_global_get_typwin(g));
 }
 

owl.h

@@ -442 +442 @@
   int dotsend;
   int echochar;
+
+  char *command;
+  void (*callback)(struct _owl_editwin*);
+  void *cbdata;
 } owl_editwin;
 
@@ -536 +540 @@
   int haveconfig;
   int config_format;
-  char *buffercommand;
-  void (*buffercallback)(char *cmd, char *msg);
+  void *buffercbdata;
   owl_editwin tw;
   owl_viewwin vw;

perlglue.xs

@@ -100 +100 @@
                 owl_cmddict_add_cmd(owl_global_get_cmddict(&g), &cmd);
 
-void queue_message(msg)
+void queue_message(msg) 
         SV *msg
         PREINIT:
@@ -111 +111 @@
                 I32 len;
         CODE:
+        {
                 if(!SvROK(msg) || SvTYPE(SvRV(msg)) != SVt_PVHV) {
                         croak("Usage: owl::queue_message($message)");
@@ -131 +132 @@
                         }
                 }
+                owl_message_set_isprivate(m);
+                if(owl_message_is_type_admin(m)) {
+                        if(!owl_message_get_attribute_value(m, "adminheader"))
+                                owl_message_set_attribute(m, "adminheader", "");
+                } 
 
                 owl_global_messagequeue_addmsg(&g, m);
+        }