Changes in / [2bc6bb16:1c01cdf7]

Files:

• aim.c (modified) (1 diff)
• cmd.c (modified) (10 diffs)
• commands.c (modified) (7 diffs)
• context.c (modified) (1 diff)
• dict.c (modified) (1 diff)
• editcontext.c (modified) (1 diff)
• editwin.c (modified) (5 diffs)
• filter.c (modified) (1 diff)
• fmtext.c (modified) (1 diff)
• functions.c (modified) (22 diffs)
• global.c (modified) (2 diffs)
• keybinding.c (modified) (3 diffs)
• keymap.c (modified) (2 diffs)
• keypress.c (modified) (1 diff)
• list.c (modified) (1 diff)
• logging.c (modified) (4 diffs)
• message.c (modified) (2 diffs)
• messagelist.c (modified) (1 diff)
• owl.h (modified) (3 diffs)
• perlconfig.c (modified) (11 diffs)
• popwin.c (modified) (1 diff)
• regex.c (modified) (1 diff)
• text.c (modified) (6 diffs)
• util.c (modified) (14 diffs)
• variable.c (modified) (7 diffs)
• viewwin.c (modified) (3 diffs)
• window.c (modified) (1 diff)
• zcrypt.c (modified) (6 diffs)
• zephyr.c (modified) (10 diffs)
• zwrite.c (modified) (4 diffs)

aim.c

@@ -437 +437 @@
 
 /* caller must free the return */
-char *owl_aim_normalize_screenname(const char *in)
+G_GNUC_WARN_UNUSED_RESULT char *owl_aim_normalize_screenname(const char *in)
 {
   char *out;

cmd.c

@@ -9 +9 @@
 /**************************************************************************/
 
-int owl_cmddict_setup(owl_cmddict *cd) {
+void owl_cmddict_setup(owl_cmddict *cd)
+{
   owl_cmddict_init(cd);
-  return owl_cmd_add_defaults(cd);
+  owl_cmd_add_defaults(cd);
 }
 
@@ -19 +20 @@
 
 /* for bulk initialization at startup */
-int owl_cmddict_add_from_list(owl_cmddict *cd, const owl_cmd *cmds) {
+void owl_cmddict_add_from_list(owl_cmddict *cd, const owl_cmd *cmds)
+{
   const owl_cmd *cur;
-  int ret = 0;
   for (cur = cmds; cur->name != NULL; cur++) {
-    ret = owl_cmddict_add_cmd(cd, cur);
-    if (ret < 0) break;
-  }
-  return ret;
+    owl_cmddict_add_cmd(cd, cur);
+  }
 }
 
@@ -38 +37 @@
 
 /* creates a new command alias */
-int owl_cmddict_add_alias(owl_cmddict *cd, const char *alias_from, const char *alias_to) {
+void owl_cmddict_add_alias(owl_cmddict *cd, const char *alias_from, const char *alias_to) {
   owl_cmd *cmd;
   cmd = g_new(owl_cmd, 1);
@@ -44 +43 @@
   owl_perlconfig_new_command(cmd->name);
   owl_dict_insert_element(cd, cmd->name, cmd, (void (*)(void *))owl_cmd_delete);
-  return(0);
 }
 
@@ -57 +55 @@
 }
 
-char *_owl_cmddict_execute(const owl_cmddict *cd, const owl_context *ctx, const char *const *argv, int argc, const char *buff) {
+/* caller must free the return */
+G_GNUC_WARN_UNUSED_RESULT char *_owl_cmddict_execute(const owl_cmddict *cd, const owl_context *ctx, const char *const *argv, int argc, const char *buff)
+{
   char *retval = NULL;
   const owl_cmd *cmd;
@@ -72 +72 @@
 }
 
-char *owl_cmddict_execute(const owl_cmddict *cd, const owl_context *ctx, const char *cmdbuff) {
+/* caller must free the return */
+G_GNUC_WARN_UNUSED_RESULT char *owl_cmddict_execute(const owl_cmddict *cd, const owl_context *ctx, const char *cmdbuff)
+{
   char **argv;
   int argc;
@@ -94 +96 @@
 }
 
-char *owl_cmddict_execute_argv(const owl_cmddict *cd, const owl_context *ctx, const char *const *argv, int argc) {
+/* caller must free the return */
+G_GNUC_WARN_UNUSED_RESULT char *owl_cmddict_execute_argv(const owl_cmddict *cd, const owl_context *ctx, const char *const *argv, int argc)
+{
   char *buff;
   char *retval = NULL;
@@ -121 +125 @@
 }
 
-int owl_cmd_create_alias(owl_cmd *cmd, const char *name, const char *aliased_to) {
+void owl_cmd_create_alias(owl_cmd *cmd, const char *name, const char *aliased_to) {
   memset(cmd, 0, sizeof(owl_cmd));
   cmd->name = g_strdup(name);
   cmd->cmd_aliased_to = g_strdup(aliased_to);
   cmd->summary = g_strdup_printf("%s%s", OWL_CMD_ALIAS_SUMMARY_PREFIX, aliased_to);
-  return(0);
 }
 
@@ -150 +153 @@
 }
 
-char *owl_cmd_execute(const owl_cmd *cmd, const owl_cmddict *cd, const owl_context *ctx, int argc, const char *const *argv, const char *cmdbuff) {
+/* caller must free the result */
+G_GNUC_WARN_UNUSED_RESULT char *owl_cmd_execute(const owl_cmd *cmd, const owl_cmddict *cd, const owl_context *ctx, int argc, const char *const *argv, const char *cmdbuff)
+{
   static int alias_recurse_depth = 0;
   int ival=0;
@@ -223 +228 @@
 
 /* returns a summary line describing this keymap.  the caller must free. */
-char *owl_cmd_describe(const owl_cmd *cmd) {
+G_GNUC_WARN_UNUSED_RESULT char *owl_cmd_describe(const owl_cmd *cmd)
+{
   if (!cmd || !cmd->name || !cmd->summary) return NULL;
   return g_strdup_printf("%-25s - %s", cmd->name, cmd->summary);

commands.c

@@ -41 +41 @@
 
 
-int owl_cmd_add_defaults(owl_cmddict *cd)
+void owl_cmd_add_defaults(owl_cmddict *cd)
 {
   owl_cmd commands_to_init[] = {
@@ -1040 +1040 @@
   };
 
-  int ret = owl_cmddict_add_from_list(cd, commands_to_init);
+  owl_cmddict_add_from_list(cd, commands_to_init);
   owl_cmd *cmd;
   for (cmd = commands_to_init; cmd->name != NULL; cmd++)
     owl_cmd_cleanup(cmd);
-  return ret;
 }
 
@@ -1374 +1373 @@
 }
 
-char *owl_command_smartfilter(int argc, const char *const *argv, const char *buff)
+G_GNUC_WARN_UNUSED_RESULT char *owl_command_smartfilter(int argc, const char *const *argv, const char *buff)
 {
   char *filtname = NULL;
@@ -1414 +1413 @@
 }
 
-char *owl_command_get_shift(int argc, const char *const *argv, const char *buff)
+G_GNUC_WARN_UNUSED_RESULT char *owl_command_get_shift(int argc, const char *const *argv, const char *buff)
 {
   if(argc != 1)
@@ -1645 +1644 @@
 
 
-char *owl_command_exec(int argc, const char *const *argv, const char *buff)
+G_GNUC_WARN_UNUSED_RESULT char *owl_command_exec(int argc, const char *const *argv, const char *buff)
 {
   return owl_function_exec(argc, argv, buff, OWL_OUTPUT_RETURN);
 }
 
-char *owl_command_pexec(int argc, const char *const *argv, const char *buff)
+G_GNUC_WARN_UNUSED_RESULT char *owl_command_pexec(int argc, const char *const *argv, const char *buff)
 {
   return owl_function_exec(argc, argv, buff, OWL_OUTPUT_POPUP);
 }
 
-char *owl_command_aexec(int argc, const char *const *argv, const char *buff)
+G_GNUC_WARN_UNUSED_RESULT char *owl_command_aexec(int argc, const char *const *argv, const char *buff)
 {
   return owl_function_exec(argc, argv, buff, OWL_OUTPUT_ADMINMSG);
 }
 
-char *owl_command_perl(int argc, const char *const *argv, const char *buff)
+G_GNUC_WARN_UNUSED_RESULT char *owl_command_perl(int argc, const char *const *argv, const char *buff)
 {
   return owl_function_perl(argc, argv, buff, OWL_OUTPUT_RETURN);
 }
 
-char *owl_command_pperl(int argc, const char *const *argv, const char *buff)
+G_GNUC_WARN_UNUSED_RESULT char *owl_command_pperl(int argc, const char *const *argv, const char *buff)
 {
   return owl_function_perl(argc, argv, buff, OWL_OUTPUT_POPUP);
 }
 
-char *owl_command_aperl(int argc, const char *const *argv, const char *buff)
+G_GNUC_WARN_UNUSED_RESULT char *owl_command_aperl(int argc, const char *const *argv, const char *buff)
 {
   return owl_function_perl(argc, argv, buff, OWL_OUTPUT_ADMINMSG);
 }
 
-char *owl_command_multi(int argc, const char *const *argv, const char *buff)
+G_GNUC_WARN_UNUSED_RESULT char *owl_command_multi(int argc, const char *const *argv, const char *buff)
 {
   char *lastrv = NULL, *newbuff;
@@ -2595 +2594 @@
 }
 
-char *owl_command_getstyle(int argc, const char *const *argv, const char *buff)
+G_GNUC_WARN_UNUSED_RESULT char *owl_command_getstyle(int argc, const char *const *argv, const char *buff)
 {
   const char *stylename;
@@ -2638 +2637 @@
 }
 
-char *owl_command_with_history(int argc, const char *const *argv, const char *buff)
+G_GNUC_WARN_UNUSED_RESULT char *owl_command_with_history(int argc, const char *const *argv, const char *buff)
 {
   owl_history *hist;

context.c

@@ -6 +6 @@
 
 /* TODO: dependency from owl_context -> owl_window is annoying. */
-owl_context *owl_context_new(int mode, void *data, const char *keymap, owl_window *cursor)
+G_GNUC_WARN_UNUSED_RESULT owl_context *owl_context_new(int mode, void *data, const char *keymap, owl_window *cursor)
 {
   owl_context *c;

dict.c

@@ -107 +107 @@
 /* Doesn't free the value of the element, but does
  * return it so the caller can free it. */
-void *owl_dict_remove_element(owl_dict *d, const char *k) {
+G_GNUC_WARN_UNUSED_RESULT void *owl_dict_remove_element(owl_dict *d, const char *k)
+{
   int i;
   int pos, found;

editcontext.c

@@ -8 +8 @@
 }
 
-owl_context *owl_editcontext_new(int mode, owl_editwin *e, const char *keymap, void (*deactivate_cb)(owl_context*), void *cbdata)
+G_GNUC_WARN_UNUSED_RESULT owl_context *owl_editcontext_new(int mode, owl_editwin *e, const char *keymap, void (*deactivate_cb)(owl_context*), void *cbdata)
 {
   owl_context *ctx = owl_context_new(mode, owl_editwin_ref(e), keymap,

editwin.c

@@ -61 +61 @@
 static const char *oe_copy_buf(owl_editwin *e, const char *buf, int len);
 static int oe_copy_region(owl_editwin *e);
-static char *oe_chunk(owl_editwin *e, int start, int end);
+static G_GNUC_WARN_UNUSED_RESULT char *oe_chunk(owl_editwin *e, int start, int end);
 static void oe_destroy_cbdata(owl_editwin *e);
 static void oe_dirty(owl_editwin *e);
@@ -70 +70 @@
 #define WHITESPACE " \n\t"
 
-static owl_editwin *owl_editwin_allocate(void)
+static G_GNUC_WARN_UNUSED_RESULT owl_editwin *owl_editwin_allocate(void)
 {
   owl_editwin *e = g_new0(owl_editwin, 1);
@@ -142 +142 @@
 }
 
-owl_editwin *owl_editwin_new(owl_window *win, int winlines, int wincols, int style, owl_history *hist)
+G_GNUC_WARN_UNUSED_RESULT owl_editwin *owl_editwin_new(owl_window *win, int winlines, int wincols, int style, owl_history *hist)
 {
   owl_editwin *e = owl_editwin_allocate();
@@ -1369 +1369 @@
 }
 
-char *owl_editwin_get_region(owl_editwin *e)
+G_GNUC_WARN_UNUSED_RESULT char *owl_editwin_get_region(owl_editwin *e)
 {
   int start, end;
@@ -1388 +1388 @@
 }
 
-static char *oe_chunk(owl_editwin *e, int start, int end)
+static G_GNUC_WARN_UNUSED_RESULT char *oe_chunk(owl_editwin *e, int start, int end)
 {
   char *p;

filter.c

@@ -200 +200 @@
 
 
-char* owl_filter_print(const owl_filter *f)
+char G_GNUC_WARN_UNUSED_RESULT *owl_filter_print(const owl_filter *f)
 {
   GString *out = g_string_new("");

fmtext.c

@@ -171 +171 @@
  * freeing the return
  */
-char *owl_fmtext_print_plain(const owl_fmtext *f)
+char G_GNUC_WARN_UNUSED_RESULT *owl_fmtext_print_plain(const owl_fmtext *f)
 {
   return owl_strip_format_chars(f->buff->str);

functions.c

@@ -14 +14 @@
 #include "filterproc.h"
 
-char *owl_function_command(const char *cmdbuff)
+G_GNUC_WARN_UNUSED_RESULT char *owl_function_command(const char *cmdbuff)
 {
   owl_function_debugmsg("executing command: %s", cmdbuff);
@@ -21 +21 @@
 }
 
-char *owl_function_command_argv(const char *const *argv, int argc)
+G_GNUC_WARN_UNUSED_RESULT char *owl_function_command_argv(const char *const *argv, int argc)
 {
   return owl_cmddict_execute_argv(owl_global_get_cmddict(&g),
@@ -95 +95 @@
 }
 
-char *owl_function_style_describe(const char *name) {
+G_GNUC_WARN_UNUSED_RESULT char *owl_function_style_describe(const char *name)
+{
   const char *desc;
   char *s;
@@ -111 +112 @@
 }
 
-char *owl_function_cmd_describe(const char *name)
+G_GNUC_WARN_UNUSED_RESULT char *owl_function_cmd_describe(const char *name)
 {
   const owl_cmd *cmd = owl_cmddict_find(owl_global_get_cmddict(&g), name);
@@ -249 +250 @@
  * owl_global_messagequeue_addmsg() for that.
  */
-owl_message *owl_function_make_outgoing_aim(const char *body, const char *to)
+G_GNUC_WARN_UNUSED_RESULT owl_message *owl_function_make_outgoing_aim(const char *body, const char *to)
 {
   owl_message *m;
@@ -270 +271 @@
  * owl_global_messagequeue_addmsg() for that.
  */
-owl_message *owl_function_make_outgoing_loopback(const char *body)
+G_GNUC_WARN_UNUSED_RESULT owl_message *owl_function_make_outgoing_loopback(const char *body)
 {
   owl_message *m;
@@ -1227 +1228 @@
 }
 
-static void _dirty_everything(owl_window *w) {
+static void _dirty_everything(gpointer data, gpointer user_data) {
+  owl_window *w = data;
   if (!owl_window_is_realized(w))
     return;
   owl_window_dirty(w);
-  owl_window_children_foreach(w, (GFunc)_dirty_everything, NULL);
+  owl_window_children_foreach(w, _dirty_everything, NULL);
 }
 
@@ -1237 +1239 @@
 {
   /* Ask every widget to redraw itself. */
-  _dirty_everything(owl_window_get_screen());
+  _dirty_everything(owl_window_get_screen(), NULL);
   /* Force ncurses to redisplay everything. */
   clearok(stdscr, TRUE);
@@ -1898 +1900 @@
 }
 
-owl_editwin *owl_function_start_question(const char *line)
+G_GNUC_WARN_UNUSED_RESULT owl_editwin *owl_function_start_question(const char *line)
 {
   owl_editwin *tw;
@@ -1913 +1915 @@
 }
 
-owl_editwin *owl_function_start_password(const char *line)
+G_GNUC_WARN_UNUSED_RESULT owl_editwin *owl_function_start_password(const char *line)
 {
   owl_editwin *tw;
@@ -1930 +1932 @@
 }
 
-char *owl_function_exec(int argc, const char *const *argv, const char *buff, int type)
+G_GNUC_WARN_UNUSED_RESULT char *owl_function_exec(int argc, const char *const *argv, const char *buff, int type)
 {
   /* if type == 1 display in a popup
@@ -1973 +1975 @@
 }
 
-char *owl_function_perl(int argc, const char *const *argv, const char *buff, int type)
+G_GNUC_WARN_UNUSED_RESULT char *owl_function_perl(int argc, const char *const *argv, const char *buff, int type)
 {
   /* if type == 1 display in a popup
@@ -2143 +2145 @@
  * Returns the name of the negated filter, which the caller must free.
  */
-char *owl_function_create_negative_filter(const char *filtername)
+G_GNUC_WARN_UNUSED_RESULT char *owl_function_create_negative_filter(const char *filtername)
 {
   char *newname;
@@ -2240 +2242 @@
  * If 'related' is nonzero, encompass unclasses and .d classes as well.
  */
-char *owl_function_classinstfilt(const char *c, const char *i, int related) 
+G_GNUC_WARN_UNUSED_RESULT char *owl_function_classinstfilt(const char *c, const char *i, int related) 
 {
   owl_filter *f;
@@ -2327 +2329 @@
  * the filter, which the caller must free.
  */
-char *owl_function_zuserfilt(const char *longuser)
+G_GNUC_WARN_UNUSED_RESULT char *owl_function_zuserfilt(const char *longuser)
 {
   owl_filter *f;
@@ -2373 +2375 @@
  * Returns the name of the filter, which the caller must free.
  */
-char *owl_function_aimuserfilt(const char *user)
+G_GNUC_WARN_UNUSED_RESULT char *owl_function_aimuserfilt(const char *user)
 {
   owl_filter *f;
@@ -2411 +2413 @@
 }
 
-char *owl_function_typefilt(const char *type)
+G_GNUC_WARN_UNUSED_RESULT char *owl_function_typefilt(const char *type)
 {
   owl_filter *f;
@@ -2467 +2469 @@
 }
 
-static char *owl_function_smartfilter_cc(const owl_message *m) {
+static G_GNUC_WARN_UNUSED_RESULT char *owl_function_smartfilter_cc(const owl_message *m)
+{
   const char *ccs;
   char *ccs_quoted;
@@ -2518 +2521 @@
  *    name to the AIM conversation with that user 
  */
-char *owl_function_smartfilter(int type, int invert_related)
+G_GNUC_WARN_UNUSED_RESULT char *owl_function_smartfilter(int type, int invert_related)
 {
   const owl_view *v;
@@ -2857 +2860 @@
 }
 
-char *owl_function_keymap_summary(const char *name)
+G_GNUC_WARN_UNUSED_RESULT char *owl_function_keymap_summary(const char *name)
 {
   const owl_keymap *km 
@@ -2971 +2974 @@
 /* strips formatting from ztext and returns the unformatted text. 
  * caller is responsible for freeing. */
-char *owl_function_ztext_stylestrip(const char *zt)
+G_GNUC_WARN_UNUSED_RESULT char *owl_function_ztext_stylestrip(const char *zt)
 {
   owl_fmtext fm;
@@ -3152 +3155 @@
     }
     
-    /* if it exited, fork & exec a new one */
+    /* if it exited, spawn a new one */
     if (owl_global_get_newmsgproc_pid(&g)==0) {
-      pid_t i;
       int myargc;
-      i=fork();
-      if (i) {
-        /* parent set the child's pid */
-        owl_global_set_newmsgproc_pid(&g, i);
-        owl_function_debugmsg("I'm the parent and I started a new newmsgproc with pid %i", i);
-      } else {
-        /* child exec's the program */
-        char **parsed;
-        parsed=owl_parseline(owl_global_get_newmsgproc(&g), &myargc);
-        if (myargc < 0) {
-          owl_function_debugmsg("Could not parse newmsgproc '%s': unbalanced quotes?", owl_global_get_newmsgproc(&g));
-        }
-        if (myargc <= 0) {
-          _exit(127);
-        }
-        owl_function_debugmsg("About to exec \"%s\" with %d arguments", parsed[0], myargc);
-        
-        execvp(parsed[0], parsed);
-        
-        
-        /* was there an error exec'ing? */
-        owl_function_debugmsg("Cannot run newmsgproc '%s': cannot exec '%s': %s", 
-                              owl_global_get_newmsgproc(&g), parsed[0], strerror(errno));
-        _exit(127);
+      char **argv = owl_parseline(owl_global_get_newmsgproc(&g), &myargc);
+      if (myargc < 0) {
+        owl_function_debugmsg("Could not parse newmsgproc '%s': unbalanced quotes?",
+                              owl_global_get_newmsgproc(&g));
+      } else if (myargc > 0) {
+        /* Spawn the child. */
+        pid_t pid;
+        GError *error = NULL;
+        owl_function_debugmsg("About to exec \"%s\" with %d arguments", argv[0], myargc);
+        if (g_spawn_async(NULL, argv, NULL,
+                          G_SPAWN_SEARCH_PATH | G_SPAWN_DO_NOT_REAP_CHILD,
+                          NULL, NULL, &pid, &error)) {
+          owl_global_set_newmsgproc_pid(&g, pid);
+          owl_function_debugmsg("I'm the parent and I started a new newmsgproc with pid %i", pid);
+        } else {
+          owl_function_debugmsg("Cannot run newmsgproc '%s': %s",
+                                owl_global_get_newmsgproc(&g), error->message);
+          g_error_free(error);
+        }
       }
+      g_strfreev(argv);
     }
   }

global.c

@@ -172 +172 @@
 /* Pops the current context from the context stack and returns it. Caller is
  * responsible for freeing. */
-owl_context *owl_global_pop_context_no_delete(owl_global *g) {
+G_GNUC_WARN_UNUSED_RESULT owl_context *owl_global_pop_context_no_delete(owl_global *g)
+{
   owl_context *c;
   if (!g->context_stack)
@@ -724 +725 @@
  * necessary.
  */
-owl_message *owl_global_messagequeue_popmsg(owl_global *g)
+owl_message G_GNUC_WARN_UNUSED_RESULT *owl_global_messagequeue_popmsg(owl_global *g)
 {
   owl_message *out;

keybinding.c

@@ -14 +14 @@
 
 /* sets up a new keybinding for a command */
-owl_keybinding *owl_keybinding_new(const char *keyseq, const char *command, void (*function_fn)(void), const char *desc)
+G_GNUC_WARN_UNUSED_RESULT owl_keybinding *owl_keybinding_new(const char *keyseq, const char *command, void (*function_fn)(void), const char *desc)
 {
   owl_keybinding *kb = g_new(owl_keybinding, 1);
@@ -85 +85 @@
 }
 
-char *owl_keybinding_stack_tostring(int *j, int len)
+G_GNUC_WARN_UNUSED_RESULT char *owl_keybinding_stack_tostring(int *j, int len)
 {
   GString *string;
@@ -100 +100 @@
 }
 
-char *owl_keybinding_tostring(const owl_keybinding *kb)
+G_GNUC_WARN_UNUSED_RESULT char *owl_keybinding_tostring(const owl_keybinding *kb)
 {
   return owl_keybinding_stack_tostring(kb->keys, kb->len);

keymap.c

@@ -51 +51 @@
     }
   }
-  return owl_list_append_element(&km->bindings, kb);  
-
+  owl_list_append_element(&km->bindings, kb);
+  return 0;
 }
 
@@ -80 +80 @@
 
 /* returns a summary line describing this keymap.  the caller must free. */
-char *owl_keymap_summary(const owl_keymap *km)
+G_GNUC_WARN_UNUSED_RESULT char *owl_keymap_summary(const owl_keymap *km)
 {
   if (!km || !km->name || !km->desc) return NULL;

keypress.c

@@ -129 +129 @@
 /* OWL_META is definied in owl.h */
 
-char *owl_keypress_tostring(int j, int esc)
+char G_GNUC_WARN_UNUSED_RESULT *owl_keypress_tostring(int j, int esc)
 {
   GString *kb;

list.c

@@ -53 +53 @@
 }
 
-int owl_list_append_element(owl_list *l, void *element)
+void owl_list_append_element(owl_list *l, void *element)
 {
-  return owl_list_insert_element(l, l->size, element);
+  owl_list_insert_element(l, l->size, element);
 }
 
-int owl_list_prepend_element(owl_list *l, void *element)
+void owl_list_prepend_element(owl_list *l, void *element)
 {
-  return owl_list_insert_element(l, 0, element);
+  owl_list_insert_element(l, 0, element);
 }
 

logging.c

@@ -80 +80 @@
 }
 
-char *owl_log_zephyr(const owl_message *m) {
+G_GNUC_WARN_UNUSED_RESULT char *owl_log_zephyr(const owl_message *m)
+{
     char *tmp = NULL;
     GString *buffer = NULL;
@@ -103 +104 @@
 }
 
-char *owl_log_aim(const owl_message *m) {
+G_GNUC_WARN_UNUSED_RESULT char *owl_log_aim(const owl_message *m)
+{
     GString *buffer = NULL;
     buffer = g_string_new("");
@@ -120 +122 @@
 }
 
-char *owl_log_jabber(const owl_message *m) {
+G_GNUC_WARN_UNUSED_RESULT char *owl_log_jabber(const owl_message *m)
+{
     GString *buffer = NULL;
     buffer = g_string_new("");
@@ -132 +135 @@
 }
 
-char *owl_log_generic(const owl_message *m) {
+G_GNUC_WARN_UNUSED_RESULT char *owl_log_generic(const owl_message *m)
+{
     GString *buffer;
     buffer = g_string_new("");

message.c

@@ -580 +580 @@
 
 /* caller must free return value. */
-char *owl_message_get_cc(const owl_message *m)
+G_GNUC_WARN_UNUSED_RESULT char *owl_message_get_cc(const owl_message *m)
 {
   const char *cur;
@@ -597 +597 @@
 
 /* caller must free return value */
-GList *owl_message_get_cc_without_recipient(const owl_message *m)
+G_GNUC_WARN_UNUSED_RESULT GList *owl_message_get_cc_without_recipient(const owl_message *m)
 {
   char *cc, *shortuser, *recip;

messagelist.c

@@ -42 +42 @@
 }
 
-int owl_messagelist_append_element(owl_messagelist *ml, void *element)
+void owl_messagelist_append_element(owl_messagelist *ml, void *element)
 {
-  return(owl_list_append_element(&(ml->list), element));
+  owl_list_append_element(&ml->list, element);
 }
 

owl.h

@@ -251 +251 @@
                                  * WARNING:  this approach is hard to make
                                  * thread-safe... */
-  char *(*get_tostring_fn)(const struct _owl_variable *v, const void *val);
+  char G_GNUC_WARN_UNUSED_RESULT *(*get_tostring_fn)(const struct _owl_variable *v, const void *val);
                                 /* converts val to a string;
                                  * caller must free the result */
@@ -313 +313 @@
   
   /* These don't take any context */
-  char *(*cmd_args_fn)(int argc, const char *const *argv, const char *buff);  
+  char G_GNUC_WARN_UNUSED_RESULT *(*cmd_args_fn)(int argc, const char *const *argv, const char *buff);
                                 /* takes argv and the full command as buff.
                                  * caller must free return value if !NULL */
@@ -320 +320 @@
 
   /* The following also take the active context if it's valid */
-  char *(*cmd_ctxargs_fn)(void *ctx, int argc, const char *const *argv, const char *buff);  
+  char G_GNUC_WARN_UNUSED_RESULT *(*cmd_ctxargs_fn)(void *ctx, int argc, const char *const *argv, const char *buff);
                                 /* takes argv and the full command as buff.
                                  * caller must free return value if !NULL */

perlconfig.c

@@ -23 +23 @@
 
 
-SV *owl_new_sv(const char * str)
+G_GNUC_WARN_UNUSED_RESULT SV *owl_new_sv(const char * str)
 {
   SV *ret = newSVpv(str, 0);
@@ -36 +36 @@
 }
 
-AV *owl_new_av(const owl_list *l, SV *(*to_sv)(const void *))
+G_GNUC_WARN_UNUSED_RESULT AV *owl_new_av(const owl_list *l, SV *(*to_sv)(const void *))
 {
   AV *ret;
@@ -52 +52 @@
 }
 
-HV *owl_new_hv(const owl_dict *d, SV *(*to_sv)(const void *))
+G_GNUC_WARN_UNUSED_RESULT HV *owl_new_hv(const owl_dict *d, SV *(*to_sv)(const void *))
 {
   HV *ret;
@@ -75 +75 @@
 }
 
-SV *owl_perlconfig_message2hashref(const owl_message *m)
+G_GNUC_WARN_UNUSED_RESULT SV *owl_perlconfig_message2hashref(const owl_message *m)
 {
   HV *h, *stash;
@@ -165 +165 @@
 }
 
-SV *owl_perlconfig_curmessage2hashref(void)
+G_GNUC_WARN_UNUSED_RESULT SV *owl_perlconfig_curmessage2hashref(void)
 {
   int curmsg;
@@ -183 +183 @@
    This has been somewhat addressed, but is still not lossless.
  */
-owl_message * owl_perlconfig_hashref2message(SV *msg)
+G_GNUC_WARN_UNUSED_RESULT owl_message *owl_perlconfig_hashref2message(SV *msg)
 {
   owl_message * m;
@@ -251 +251 @@
 /* Calls in a scalar context, passing it a hash reference.
    If return value is non-null, caller must free. */
-char *owl_perlconfig_call_with_message(const char *subname, const owl_message *m)
+G_GNUC_WARN_UNUSED_RESULT char *owl_perlconfig_call_with_message(const char *subname, const owl_message *m)
 {
   dSP ;
@@ -300 +300 @@
    If the return value is non-null, the caller must free it.
  */
-char * owl_perlconfig_message_call_method(const owl_message *m, const char *method, int argc, const char ** argv)
+G_GNUC_WARN_UNUSED_RESULT char *owl_perlconfig_message_call_method(const owl_message *m, const char *method, int argc, const char **argv)
 {
   dSP;
@@ -349 +349 @@
 }
 
-
-char *owl_perlconfig_initperl(const char * file, int *Pargc, char ***Pargv, char *** Penv)
+/* caller must free result, if not NULL */
+G_GNUC_WARN_UNUSED_RESULT char *owl_perlconfig_initperl(const char *file, int *Pargc, char ***Pargv, char ***Penv)
 {
   int ret;
@@ -436 +436 @@
 
 /* caller is responsible for freeing returned string */
-char *owl_perlconfig_execute(const char *line)
+G_GNUC_WARN_UNUSED_RESULT char *owl_perlconfig_execute(const char *line)
 {
   STRLEN len;
@@ -505 +505 @@
 }
 
-char *owl_perlconfig_perlcmd(const owl_cmd *cmd, int argc, const char *const *argv)
+/* caller must free the result */
+G_GNUC_WARN_UNUSED_RESULT char *owl_perlconfig_perlcmd(const owl_cmd *cmd, int argc, const char *const *argv)
 {
   int i, count;

popwin.c

@@ -1 +1 @@
 #include "owl.h"
 
-owl_popwin *owl_popwin_new(void)
+G_GNUC_WARN_UNUSED_RESULT owl_popwin *owl_popwin_new(void)
 {
   owl_popwin *pw = g_new0(owl_popwin, 1);

regex.c

@@ -39 +39 @@
 {
   char *quoted;
+  int ret;
   
-  quoted=owl_text_quote(string, OWL_REGEX_QUOTECHARS, OWL_REGEX_QUOTEWITH);
-  owl_regex_create(re, quoted);
+  quoted = owl_text_quote(string, OWL_REGEX_QUOTECHARS, OWL_REGEX_QUOTEWITH);
+  ret = owl_regex_create(re, quoted);
   g_free(quoted);
-  return(0);
+  return ret;
 }
 

text.c

@@ -7 +7 @@
 /* Returns a copy of 'in' with each line indented 'n'
  * characters. Result must be freed with g_free. */
-char *owl_text_indent(const char *in, int n)
+G_GNUC_WARN_UNUSED_RESULT char *owl_text_indent(const char *in, int n)
 {
   const char *ptr1, *ptr2, *last;
@@ -48 +48 @@
 
 /* caller must free the return */
-char *owl_text_htmlstrip(const char *in)
+G_GNUC_WARN_UNUSED_RESULT char *owl_text_htmlstrip(const char *in)
 {
   const char *ptr1, *end, *ptr2, *ptr3;
@@ -129 +129 @@
 
 /* Caller must free return */
-char *owl_text_expand_tabs(const char *in)
+G_GNUC_WARN_UNUSED_RESULT char *owl_text_expand_tabs(const char *in)
 {
   int len = 0;
@@ -188 +188 @@
 
 /* caller must free the return */
-char *owl_text_wordwrap(const char *in, int col)
+G_GNUC_WARN_UNUSED_RESULT char *owl_text_wordwrap(const char *in, int col)
 {
   char *out;
@@ -269 +269 @@
  * Caller must free returned string.
  */
-char *owl_text_substitute(const char *in, const char *from, const char *to)
+G_GNUC_WARN_UNUSED_RESULT char *owl_text_substitute(const char *in, const char *from, const char *to)
 {
   char **split = g_strsplit(in, from, 0), *out;
@@ -284 +284 @@
  * On success returns the string, on error returns NULL.
  */
-char *owl_text_quote(const char *in, const char *toquote, const char *quotestr)
+G_GNUC_WARN_UNUSED_RESULT char *owl_text_quote(const char *in, const char *toquote, const char *quotestr)
 {
   int i, x, r, place, escape;

util.c

@@ -35 +35 @@
  * duplicate slashes are removed.  Caller must free the return.
  */
-char *owl_util_makepath(const char *in)
+G_GNUC_WARN_UNUSED_RESULT char *owl_util_makepath(const char *in)
 {
   int i, j, x;
@@ -102 +102 @@
    to -1, argv will be NULL and the caller does not need to free anything. The
    returned vector is NULL-terminated. */
-char **owl_parseline(const char *line, int *argc)
+G_GNUC_WARN_UNUSED_RESULT char **owl_parseline(const char *line, int *argc)
 {
   GPtrArray *argv;
@@ -245 +245 @@
 }
 
-char *owl_string_build_quoted(const char *tmpl, ...)
+G_GNUC_WARN_UNUSED_RESULT char *owl_string_build_quoted(const char *tmpl, ...)
 {
   GString *buf = g_string_new("");
@@ -257 +257 @@
 /* Returns a quoted version of arg suitable for placing in a
  * command-line. Result should be freed with g_free. */
-char *owl_arg_quote(const char *arg)
+G_GNUC_WARN_UNUSED_RESULT char *owl_arg_quote(const char *arg)
 {
   GString *buf = g_string_new("");;
@@ -265 +265 @@
 
 /* caller must free the return */
-char *owl_util_minutes_to_timestr(int in)
+G_GNUC_WARN_UNUSED_RESULT char *owl_util_minutes_to_timestr(int in)
 {
   int days, hours;
@@ -331 +331 @@
 
 /* Get the default tty name.  Caller must free the return */
-char *owl_util_get_default_tty(void)
+G_GNUC_WARN_UNUSED_RESULT char *owl_util_get_default_tty(void)
 {
   const char *tmp;
@@ -353 +353 @@
  * return.
  */
-char *owl_util_stripnewlines(const char *in)
+G_GNUC_WARN_UNUSED_RESULT char *owl_util_stripnewlines(const char *in)
 {
   
@@ -384 +384 @@
  * Error conditions are the same as g_file_read_link.
  */
-gchar *owl_util_recursive_resolve_link(const char *filename)
+G_GNUC_WARN_UNUSED_RESULT gchar *owl_util_recursive_resolve_link(const char *filename)
 {
   gchar *last_path = g_strdup(filename);
@@ -511 +511 @@
    The caller is responsible for freeing the allocated string.
 */
-char * owl_util_baseclass(const char * class)
+G_GNUC_WARN_UNUSED_RESULT char *owl_util_baseclass(const char *class)
 {
   char *start, *end;
@@ -546 +546 @@
 
 /* Strips format characters from a valid utf-8 string. Returns the
-   empty string if 'in' does not validate. */
-char * owl_strip_format_chars(const char *in)
+   empty string if 'in' does not validate.  Caller must free the return. */
+G_GNUC_WARN_UNUSED_RESULT char *owl_strip_format_chars(const char *in)
 {
   char *r;
@@ -584 +584 @@
  * out characters in Unicode Plane 16, as we use that plane internally
  * for formatting.
- */
-char * owl_validate_or_convert(const char *in)
+ * Caller must free the return.
+ */
+G_GNUC_WARN_UNUSED_RESULT char *owl_validate_or_convert(const char *in)
 {
   if (g_utf8_validate(in, -1, NULL)) {
@@ -599 +600 @@
  * Validate 'in' as UTF-8, and either return a copy of it, or an empty
  * string if it is invalid utf-8.
- */
-char * owl_validate_utf8(const char *in)
+ * Caller must free the return.
+ */
+G_GNUC_WARN_UNUSED_RESULT char *owl_validate_utf8(const char *in)
 {
   char *out;
@@ -632 +634 @@
 }
 
-char *owl_escape_highbit(const char *str)
+/* caller must free the return */
+G_GNUC_WARN_UNUSED_RESULT char *owl_escape_highbit(const char *str)
 {
   GString *out = g_string_new("");
@@ -695 +698 @@
 
 /* Read the rest of the input available in fp into a string. */
-char *owl_slurp(FILE *fp)
+G_GNUC_WARN_UNUSED_RESULT char *owl_slurp(FILE *fp)
 {
   char *buf = NULL;

variable.c

@@ -646 +646 @@
 }
 
-owl_variable * owl_variable_newvar(const char *name, const char *summary, const char * description) {
+G_GNUC_WARN_UNUSED_RESULT owl_variable *owl_variable_newvar(const char *name, const char *summary, const char *description)
+{
   owl_variable * var = g_new0(owl_variable, 1);
   var->name = g_strdup(name);
@@ -824 +825 @@
 }
 
-char *owl_variable_get_tostring(const owl_vardict *d, const char *name) {
+G_GNUC_WARN_UNUSED_RESULT char *owl_variable_get_tostring(const owl_vardict *d, const char *name)
+{
   owl_variable *v;
   if (!name) return NULL;
@@ -832 +834 @@
 }
 
-char *owl_variable_get_default_tostring(const owl_vardict *d, const char *name) {
+G_GNUC_WARN_UNUSED_RESULT char *owl_variable_get_default_tostring(const owl_vardict *d, const char *name)
+{
   owl_variable *v;
   if (!name) return NULL;
@@ -992 +995 @@
 }
 
-char *owl_variable_bool_get_tostring_default(const owl_variable *v, const void *val) {
+G_GNUC_WARN_UNUSED_RESULT char *owl_variable_bool_get_tostring_default(const owl_variable *v, const void *val)
+{
   if (val == NULL) {
     return g_strdup("<null>");
@@ -1027 +1031 @@
 }
 
-char *owl_variable_int_get_tostring_default(const owl_variable *v, const void *val) {
+G_GNUC_WARN_UNUSED_RESULT char *owl_variable_int_get_tostring_default(const owl_variable *v, const void *val)
+{
   if (val == NULL) {
     return g_strdup("<null>");
@@ -1066 +1071 @@
 }
 
-char *owl_variable_enum_get_tostring(const owl_variable *v, const void *val) {
+G_GNUC_WARN_UNUSED_RESULT char *owl_variable_enum_get_tostring(const owl_variable *v, const void *val)
+{
   char **enums;
   int nenums, i;
@@ -1106 +1112 @@
 }
 
-char *owl_variable_string_get_tostring_default(const owl_variable *v, const void *val) {
+G_GNUC_WARN_UNUSED_RESULT char *owl_variable_string_get_tostring_default(const owl_variable *v, const void *val)
+{
   if (val == NULL) {
     return g_strdup("<null>");

viewwin.c

@@ -12 +12 @@
  * will be used by the viewwin
  */
-owl_viewwin *owl_viewwin_new_text(owl_window *win, const char *text)
+G_GNUC_WARN_UNUSED_RESULT owl_viewwin *owl_viewwin_new_text(owl_window *win, const char *text)
 {
   owl_viewwin *v = g_new0(owl_viewwin, 1);
@@ -34 +34 @@
  * will be used by the viewwin
  */
-owl_viewwin *owl_viewwin_new_fmtext(owl_window *win, const owl_fmtext *fmtext)
+G_GNUC_WARN_UNUSED_RESULT owl_viewwin *owl_viewwin_new_fmtext(owl_window *win, const owl_fmtext *fmtext)
 {
   char *text;
@@ -237 +237 @@
 }
 
-owl_editwin *owl_viewwin_set_typwin_active(owl_viewwin *v, owl_history *hist) {
+G_GNUC_WARN_UNUSED_RESULT owl_editwin *owl_viewwin_set_typwin_active(owl_viewwin *v, owl_history *hist) {
   int lines, cols;
   owl_editwin *cmdline;

window.c

@@ -569 +569 @@
 };
 
-GSource *owl_window_redraw_source_new(void) {
+G_GNUC_WARN_UNUSED_RESULT GSource *owl_window_redraw_source_new(void)
+{
   GSource *source;
   source = g_source_new(&redraw_funcs, sizeof(GSource));

zcrypt.c

@@ -53 +53 @@
 } ZWRITEOPTIONS;
 
-char *GetZephyrVarKeyFile(const char *whoami, const char *class, const char *instance);
+G_GNUC_WARN_UNUSED_RESULT char *GetZephyrVarKeyFile(const char *whoami, const char *class, const char *instance);
 int ParseCryptSpec(const char *spec, const char **keyfile);
-char *BuildArgString(char **argv, int start, int end);
-char *read_keystring(const char *keyfile);
+G_GNUC_WARN_UNUSED_RESULT char *BuildArgString(char **argv, int start, int end);
+G_GNUC_WARN_UNUSED_RESULT char *read_keystring(const char *keyfile);
 
 int do_encrypt(int zephyr, const char *class, const char *instance,
@@ -364 +364 @@
 /* Build a space-separated string from argv from elements between start  *
  * and end - 1.  malloc()'s the returned string. */
-char *BuildArgString(char **argv, int start, int end)
+G_GNUC_WARN_UNUSED_RESULT char *BuildArgString(char **argv, int start, int end)
 {
   int len = 1;
@@ -401 +401 @@
 #define MAX_SEARCH 3
 /* Find the class/instance in the .crypt-table */
-char *GetZephyrVarKeyFile(const char *whoami, const char *class, const char *instance)
+G_GNUC_WARN_UNUSED_RESULT char *GetZephyrVarKeyFile(const char *whoami, const char *class, const char *instance)
 {
   char *keyfile = NULL;
@@ -579 +579 @@
 }
 
-char *slurp_stdin(int ignoredot, int *length) {
+G_GNUC_WARN_UNUSED_RESULT char *slurp_stdin(int ignoredot, int *length) {
   char *buf;
   char *inptr;
@@ -611 +611 @@
 }
 
-char *GetInputBuffer(ZWRITEOPTIONS *zoptions, int *length) {
+G_GNUC_WARN_UNUSED_RESULT char *GetInputBuffer(ZWRITEOPTIONS *zoptions, int *length) {
   char *buf;
 
@@ -637 +637 @@
 }
 
-char *read_keystring(const char *keyfile) {
+G_GNUC_WARN_UNUSED_RESULT char *read_keystring(const char *keyfile) {
   char *keystring;
   FILE *fkey = fopen(keyfile, "r");

zephyr.c

@@ -524 +524 @@
  */
 #ifdef HAVE_LIBZEPHYR
-char *owl_zephyr_get_field(const ZNotice_t *n, int j)
+G_GNUC_WARN_UNUSED_RESULT char *owl_zephyr_get_field(const ZNotice_t *n, int j)
 {
   int i, count, save;
@@ -552 +552 @@
 }
 
-char *owl_zephyr_get_field_as_utf8(const ZNotice_t *n, int j)
+G_GNUC_WARN_UNUSED_RESULT char *owl_zephyr_get_field_as_utf8(const ZNotice_t *n, int j)
 {
   int i, count, save;
@@ -584 +584 @@
 }
 #else
-char *owl_zephyr_get_field(void *n, int j)
+G_GNUC_WARN_UNUSED_RESULT char *owl_zephyr_get_field(void *n, int j)
 {
   return(g_strdup(""));
 }
-char *owl_zephyr_get_field_as_utf8(void *n, int j)
+G_GNUC_WARN_UNUSED_RESULT char *owl_zephyr_get_field_as_utf8(void *n, int j)
 {
   return owl_zephyr_get_field(n, j);
@@ -621 +621 @@
  * caller must free the return
  */
-char *owl_zephyr_get_message(const ZNotice_t *n, const owl_message *m)
+G_GNUC_WARN_UNUSED_RESULT char *owl_zephyr_get_message(const ZNotice_t *n, const owl_message *m)
 {
 #define OWL_NFIELDS     5
@@ -942 +942 @@
 #endif
 
-char *owl_zephyr_zlocate(const char *user, int auth)
+G_GNUC_WARN_UNUSED_RESULT char *owl_zephyr_zlocate(const char *user, int auth)
 {
 #ifdef HAVE_LIBZEPHYR
@@ -1042 +1042 @@
 
 /* caller must free the return */
-char *owl_zephyr_makesubline(const char *class, const char *inst, const char *recip)
+G_GNUC_WARN_UNUSED_RESULT char *owl_zephyr_makesubline(const char *class, const char *inst, const char *recip)
 {
   return g_strdup_printf("%s,%s,%s\n", class, inst, !strcmp(recip, "") ? "*" : recip);
@@ -1122 +1122 @@
  * free the return.
  */
-char *owl_zephyr_getsubs(void)
+G_GNUC_WARN_UNUSED_RESULT char *owl_zephyr_getsubs(void)
 {
 #ifdef HAVE_LIBZEPHYR
@@ -1242 +1242 @@
  * The caller must free the return
  */
-char *short_zuser(const char *in)
+G_GNUC_WARN_UNUSED_RESULT char *short_zuser(const char *in)
 {
   char *ptr = strrchr(in, '@');
@@ -1254 +1254 @@
  * The caller must free the return.
  */
-char *long_zuser(const char *in)
+G_GNUC_WARN_UNUSED_RESULT char *long_zuser(const char *in)
 {
   char *ptr = strrchr(in, '@');
@@ -1282 +1282 @@
  * caller must free the return.
  */
-char *owl_zephyr_smartstripped_user(const char *in)
+G_GNUC_WARN_UNUSED_RESULT char *owl_zephyr_smartstripped_user(const char *in)
 {
   char *slash, *dot, *realm, *out;

zwrite.c

@@ -5 +5 @@
 #include "owl.h"
 
-owl_zwrite *owl_zwrite_new(const char *line)
+G_GNUC_WARN_UNUSED_RESULT owl_zwrite *owl_zwrite_new(const char *line)
 {
   owl_zwrite *z = g_new(owl_zwrite, 1);
@@ -15 +15 @@
 }
 
-int owl_zwrite_create_from_line(owl_zwrite *z, const char *line)
+G_GNUC_WARN_UNUSED_RESULT int owl_zwrite_create_from_line(owl_zwrite *z, const char *line)
 {
   int argc, badargs, myargc;
@@ -321 +321 @@
 
 /* Caller must free the result. */
-char *owl_zwrite_get_recip_n_with_realm(const owl_zwrite *z, int n)
+G_GNUC_WARN_UNUSED_RESULT char *owl_zwrite_get_recip_n_with_realm(const owl_zwrite *z, int n)
 {
   if (z->realm[0]) {
@@ -370 +370 @@
  * If not a CC, only the recip_index'th user will be replied to.
  */
-char *owl_zwrite_get_replyline(const owl_zwrite *z, int recip_index)
+G_GNUC_WARN_UNUSED_RESULT char *owl_zwrite_get_replyline(const owl_zwrite *z, int recip_index)
 {
   /* Match ordering in zwrite help. */