Changeset 2226f91 for perl/modules/Facebook/lib/BarnOwl/Module

Timestamp:

Sep 19, 2011, 1:31:34 PM (13 years ago)

Author:

Edward Z. Yang <ezyang@mit.edu>

Children:

61d7594

Parents:

9da6022

git-author:

Edward Z. Yang <ezyang@mit.edu> (06/20/11 11:43:49)

git-committer:

Edward Z. Yang <ezyang@mit.edu> (09/19/11 13:31:34)

Message:

Rename postid to post_id.

Signed-off-by: Edward Z. Yang <ezyang@mit.edu>

Location:

perl/modules/Facebook/lib/BarnOwl/Module

Files:

• Facebook.pm (modified) (2 diffs)
• Facebook/Handle.pm (modified) (7 diffs)

perl/modules/Facebook/lib/BarnOwl/Module/Facebook.pm

@@ -102 +102 @@
 BarnOwl::new_command('facebook-comment' => \&cmd_facebook_comment, {
     summary     => 'Comment on a wall post.',
-    usage       => 'facebook-comment POSTID',
+    usage       => 'facebook-comment POST_ID',
     description => 'Comment on a friend\'s wall post.  Using r is recommended.'
 });
@@ -130 +130 @@
 sub cmd_facebook_comment {
     my $cmd  = shift;
-    my $postid = shift;
+    my $post_id = shift;
 
-    my $topic = $facebook_handle->get_topic($postid);
+    my $topic = $facebook_handle->get_topic($post_id);
 
     # XXX UI should give some (better) indication /which/ conversation
     # is being commented on
     BarnOwl::start_edit_win("Write a comment on '$topic'...",
-                            sub { $facebook_handle->facebook_comment($postid, shift) });
+                            sub { $facebook_handle->facebook_comment($post_id, shift) });
 }
 

perl/modules/Facebook/lib/BarnOwl/Module/Facebook/Handle.pm

@@ -179 +179 @@
         my $name    = $post->{to}{data}[0]{name} || $post->{from}{name};
         my $name_id = $post->{to}{data}[0]{id} || $post->{from}{id};
-        my $postid  = $post->{id};
+        my $post_id  = $post->{id};
 
         # Only handle post if it's new
@@ -186 +186 @@
             my @keywords = keywords($post->{name} || $post->{message});
             my $topic = $keywords[0] || 'personal';
-            $self->{topics}->{$postid} = $topic;
+            $self->{topics}->{$post_id} = $topic;
             # XXX indexing is fragile
             my $msg = BarnOwl::Message->new(
@@ -196 +196 @@
                 direction => 'in',
                 body      => $self->format_body($post),
-                postid    => $postid,
+                post_id    => $post_id,
                 topic     => $topic,
                 time      => asctime(localtime $created_time),
@@ -206 +206 @@
             BarnOwl::queue_message($msg);
         } else {
-            $self->{topics}->{$postid} = $old_topics->{$postid} || 'personal';
+            $self->{topics}->{$post_id} = $old_topics->{$post_id} || 'personal';
         }
 
@@ -227 +227 @@
                     direction => 'in',
                     body      => $comment->{message},
-                    postid    => $postid,
-                    topic     => $self->get_topic($postid),
+                    post_id    => $post_id,
+                    topic     => $self->get_topic($post_id),
                     time      => asctime(localtime $comment_time),
                    );
@@ -279 +279 @@
     my $self = shift;
 
-    my $postid = shift;
+    my $post_id = shift;
     my $msg = shift;
 
-    $self->{facebook}->add_comment( $postid )->set_message( $msg )->publish;
+    $self->{facebook}->add_comment( $post_id )->set_message( $msg )->publish;
     $self->sleep(0);
 }
@@ -326 +326 @@
     my $self = shift;
 
-    my $postid = shift;
-
-    return $self->{topics}->{$postid} || 'personal';
+    my $post_id = shift;
+
+    return $self->{topics}->{$post_id} || 'personal';
 }