Changeset 23fddad for owl.c

Timestamp:

Oct 23, 2009, 11:01:30 PM (15 years ago)

Author:

Karl Ramm <kcr@1ts.org>

Branches:

master, release-1.10, release-1.5, release-1.6, release-1.7, release-1.8, release-1.9

Children:

8590774

Parents:

52761cc

git-author:

Karl Ramm <kcr@1ts.org> (09/30/09 10:12:27)

git-committer:

Karl Ramm <kcr@1ts.org> (10/23/09 23:01:30)

Message:

refactor & rename filter creation & storage management

filter_init_fromstring -> filter_new_fromstring
filter_init -> filter_new
filter_free -> filter_delete

Every time owl_filter_init and owl_filter_init_fromstring were called,
there was a call to malloc right above them;  Conversely, after every
owl_filter_free there needed to be a call to owl_free (and sometimes
there wasn't).

File:

• owl.c (modified) (2 diffs)

owl.c

@@ -151 +151 @@
 static void owl_setup_default_filters(void)
 {
-  owl_filter *f;
   int i;
   static const struct {
@@ -176 +175 @@
   owl_function_debugmsg("startup: creating default filters");
 
-  for (i = 0; filters[i].name != NULL; i++) {
-    f = owl_malloc(sizeof(owl_filter));
-    owl_filter_init_fromstring(f, filters[i].name, filters[i].desc);
-    owl_list_append_element(owl_global_get_filterlist(&g), f);
-  }
+  for (i = 0; filters[i].name != NULL; i++)
+    owl_list_append_element(owl_global_get_filterlist(&g),
+                            owl_filter_new_fromstring(filters[i].name,
+                                                      filters[i].desc));
 }