Changeset 2c4c4c4

Timestamp:

Jun 22, 2011, 9:56:47 PM (13 years ago)

Author:

Edward Z. Yang <ezyang@mit.edu>

Children:

2f6c263

Parents:

68fa539

git-author:

Edward Z. Yang <ezyang@mit.edu> (06/22/11 18:42:02)

git-committer:

Edward Z. Yang <ezyang@mit.edu> (06/22/11 21:56:47)

Message:

Make topic detection more robust.

Signed-off-by: Edward Z. Yang <ezyang@mit.edu>

File:

• perl/modules/Facebook/lib/BarnOwl/Module/Facebook/Handle.pm (modified) (3 diffs)

perl/modules/Facebook/lib/BarnOwl/Module/Facebook/Handle.pm

@@ -270 +270 @@
         my $post_id  = $post->{id};
 
-        # Only handle post if it's new
-        my $created_time = str2time($post->{created_time});
-        if ($created_time >= $self->{last_poll}) {
+        if (defined $old_topics->{$post_id}) {
+            $self->{topics}->{$post_id} = $old_topics->{$post_id};
+        } else {
             my @keywords = keywords($post->{name} || $post->{message});
             my $topic = $keywords[0] || 'personal';
             $topic =~ s/ /-/g;
             $self->{topics}->{$post_id} = $topic;
+        }
+
+        # Only handle post if it's new
+        my $created_time = str2time($post->{created_time});
+        if ($created_time >= $self->{last_poll}) {
             # XXX indexing is fragile
             my $msg = BarnOwl::Message->new(
@@ -286 +291 @@
                 direction => 'in',
                 body      => $self->format_body($post),
-                post_id    => $post_id,
-                topic     => $topic,
+                post_id   => $post_id,
+                topic     => $self->get_topic($post_id),
                 time      => asctime(localtime $created_time),
                 # XXX The intent is to get the 'Comment' link, which also
@@ -295 +300 @@
                );
             BarnOwl::queue_message($msg);
-        } else {
-            $self->{topics}->{$post_id} = $old_topics->{$post_id} || 'personal';
         }