Changeset 34132f7 for message.c

Timestamp:

Mar 11, 2012, 10:34:18 PM (13 years ago)

Author:

David Benjamin <davidben@mit.edu>

Branches:

release-1.8

Children:

6a08f16

Parents:

4a80a16

git-author:

David Benjamin <davidben@mit.edu> (01/23/12 00:38:29)

git-committer:

David Benjamin <davidben@mit.edu> (03/11/12 22:34:18)

Message:

Rewrite call_filter to use g_spawn_async_with_pipes

This simplifies the error-handling code. Also fixes a bug where file
descriptors get double-closed in call_filter. Also adds a unit test. The
separate prog argument is removed to avoid having to deal with
G_SPAWN_FILE_AND_ARGV_ZERO, and since we don't really use it anyway.

File:

• message.c (modified) (2 diffs)

message.c

@@ -873 +873 @@
   if (owl_global_is_zcrypt(&g) && !strcasecmp(n->z_opcode, "crypt")) {
     const char *argv[] = {
-      "zcrypt",
+      NULL,
       "-D",
       "-c", owl_message_get_class(m),
@@ -885 +885 @@
 
     zcrypt = g_build_filename(owl_get_bindir(), "zcrypt", NULL);
-
-    rv = call_filter(zcrypt, argv, owl_message_get_body(m), &out, &status);
+    argv[0] = zcrypt;
+
+    rv = call_filter(argv, owl_message_get_body(m), &out, &status);
     g_free(zcrypt);