Changeset 351c535

Timestamp:

May 20, 2011, 3:59:31 PM (14 years ago)

Author:

David Benjamin <davidben@mit.edu>

Branches:

master, release-1.10, release-1.8, release-1.9

Children:

4c7c21f

Parents:

fda61d3

git-author:

David Benjamin <davidben@mit.edu> (05/07/11 15:21:11)

git-committer:

David Benjamin <davidben@mit.edu> (05/20/11 15:59:31)

Message:

owl_dict_get_keys never fails

No sense in returning an error code.

Files:

• dict.c (modified) (1 diff)
• global.c (modified) (1 diff)
• tester.c (modified) (1 diff)

dict.c

@@ -60 +60 @@
 /* Appends dictionary keys to a list.  Duplicates the keys,
  * so they will need to be freed by the caller. */
-int owl_dict_get_keys(const owl_dict *d, owl_list *l) {
+void owl_dict_get_keys(const owl_dict *d, owl_list *l) {
   int i;
   for (i=0; i<d->size; i++) {
     owl_list_append_element(l, g_strdup(d->els[i].k));
   }
-  return(0);
 }
 

global.c

@@ -747 +747 @@
 }
 
-int owl_global_get_style_names(const owl_global *g, owl_list *l) {
-  return owl_dict_get_keys(&(g->styledict), l);
+void owl_global_get_style_names(const owl_global *g, owl_list *l) {
+  owl_dict_get_keys(&(g->styledict), l);
 }
 

tester.c

@@ -249 +249 @@
   FAIL_UNLESS("get_size", 3==owl_dict_get_size(&d));
   owl_list_create(&l);
-  FAIL_UNLESS("get_keys", 0==owl_dict_get_keys(&d, &l));
+  owl_dict_get_keys(&d, &l);
   FAIL_UNLESS("get_keys result size", 3==owl_list_get_size(&l));