Changeset 36546fa

Timestamp:

Oct 11, 2009, 10:17:51 PM (15 years ago)

Author:

Nelson Elhage <nelhage@mit.edu>

Branches:

master, release-1.10, release-1.7, release-1.8, release-1.9

Children:

d69c37c

Parents:

fe184d4

git-author:

Nelson Elhage <nelhage@mit.edu> (09/16/09 23:03:38)

git-committer:

Nelson Elhage <nelhage@mit.edu> (10/11/09 22:17:51)

Message:

Replace the mainloop hook with BarnOwl's built-in timer support.

Location:

lib/BarnOwl/Module

Files:

• Twitter.pm (modified) (2 diffs)
• Twitter/Handle.pm (modified) (5 diffs)

lib/BarnOwl/Module/Twitter.pm

@@ -187 +187 @@
 }
 
-sub poll_messages {
-    return unless @twitter_handles;
-
-    my $handle = $twitter_handles[$next_service_to_poll];
-    $next_service_to_poll = ($next_service_to_poll + 1) % scalar(@twitter_handles);
-    
-    $handle->poll_twitter() if $handle->{cfg}->{poll_for_tweets};
-    $handle->poll_direct() if $handle->{cfg}->{poll_for_dms};
-}
-
 sub find_account {
     my $name = shift;
@@ -322 +312 @@
 }
 
-eval {
-    $BarnOwl::Hooks::receiveMessage->add("BarnOwl::Module::Twitter::handle_message");
-    $BarnOwl::Hooks::mainLoop->add("BarnOwl::Module::Twitter::poll_messages");
-};
-if($@) {
-    $BarnOwl::Hooks::receiveMessage->add(\&handle_message);
-    $BarnOwl::Hooks::mainLoop->add(\&poll_messages);
-}
-
 BarnOwl::filter(qw{twitter type ^twitter$});
 

lib/BarnOwl/Module/Twitter/Handle.pm

@@ -57 +57 @@
         'cfg'  => $cfg,
         'twitter' => undef,
-        'last_poll' => 0,
-        'last_direct_poll' => 0,
         'last_id' => undef,
         'last_direct' => undef,
+        'timer'        => undef,
+        'direct_timer' => undef
     };
 
@@ -92 +92 @@
     warn "$@" if $@;
 
+    $self->sleep(0);
+
     return $self;
 }
 
+=head2 sleep SECONDS
+
+Stop polling Twitter for SECONDS seconds.
+
+=cut
+
+sub sleep {
+    my $self  = shift;
+    my $delay = shift;
+
+    if($self->{cfg}->{poll_for_tweets}) {
+        $self->{timer} = BarnOwl::Timer->new({
+            after    => $delay,
+            interval => 60,
+            cb       => sub { $self->poll_twitter }
+           });
+    }
+
+    if($self->{cfg}->{poll_for_dms}) {
+        $self->{direct_timer} = BarnOwl::Timer->new({
+            after    => $delay,
+            interval => 120,
+            cb       => sub { $self->poll_direct }
+           });
+    }
+}
+
 sub twitter_error {
     my $self = shift;
@@ -101 +130 @@
     warn "$@" if $@;
     unless(defined($ratelimit) && ref($ratelimit) eq 'HASH') {
-        # Twitter's just sucking, sleep for 5 minutes
-        $self->{last_direct_poll} = $self->{last_poll} = time + 60*5;
-        # die("Twitter seems to be having problems.\n");
+        # Twitter's probably just sucking, try again later.
+        $self->sleep(5);
         return;
     }
+
     if(exists($ratelimit->{remaining_hits})
        && $ratelimit->{remaining_hits} <= 0) {
-        $self->{last_direct_poll} = $self->{last_poll} = $ratelimit->{reset_time_in_seconds};
+        $self->sleep(time - $ratelimit->{reset_time_in_seconds} + 60);
         die("Twitter: ratelimited until " . $ratelimit->{reset_time} . "\n");
     } elsif(exists($ratelimit->{error})) {
+        $self->sleep(60*20);
         die("Twitter: ". $ratelimit->{error} . "\n");
-        $self->{last_direct_poll} = $self->{last_poll} = time + 60*20;
     }
 }
@@ -119 +148 @@
     my $self = shift;
 
-    return unless ( time - $self->{last_poll} ) >= 60;
-    $self->{last_poll} = time;
     return unless BarnOwl::getvar('twitter:poll') eq 'on';
+
+    BarnOwl::debug("Polling " . $self->{cfg}->{account_nickname});
 
     my $timeline = eval { $self->{twitter}->friends_timeline( { since_id => $self->{last_id} } ) };
@@ -172 +201 @@
     my $self = shift;
 
-    return unless ( time - $self->{last_direct_poll}) >= 120;
-    $self->{last_direct_poll} = time;
     return unless BarnOwl::getvar('twitter:poll') eq 'on';
+
+    BarnOwl::debug("Polling direct for " . $self->{cfg}->{account_nickname});
 
     my $direct = eval { $self->{twitter}->direct_messages( { since_id => $self->{last_direct} } ) };