Changeset 38c584e

Timestamp:

Aug 20, 2017, 4:38:40 PM (7 years ago)

Author:

Alex Dehnert <adehnert@mit.edu>

Children:

1f69b54

Parents:

fb27b30

git-author:

Edward Z. Yang <ezyang@cs.stanford.edu> (03/22/14 02:17:36)

git-committer:

Alex Dehnert <adehnert@mit.edu> (08/20/17 16:38:40)

Message:

Fix quoting conventions for Twitter commands.

Two bugs here:

1. The documentation incorrectly implies that arguments can be
omitted, when really the argument parser is much dumber than that.
If there are two optional arguments, you can't omit the first one
and give the second one; that's ambiguous.

2. There is a codepath for replycmd when status_id is not set
(this should be impossible) which passed wrong arguments.

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Location:

perl/modules/Twitter/lib/BarnOwl

Files:

• Message/Twitter.pm (modified) (1 diff)
• Module/Twitter.pm (modified) (2 diffs)

perl/modules/Twitter/lib/BarnOwl/Message/Twitter.pm

@@ -36 +36 @@
         return BarnOwl::quote('twitter-atreply', $self->sender, $self->{status_id}, $self->account);
     } else {
-        return BarnOwl::quote('twitter-atreply', $self->sender, $self->account);
+        # Give a dummy status ID
+        return BarnOwl::quote('twitter-atreply', $self->sender, '', $self->account);
     }
 }

perl/modules/Twitter/lib/BarnOwl/Module/Twitter.pm

@@ -243 +243 @@
 BarnOwl::new_command(twitter => \&cmd_twitter, {
     summary     => 'Update Twitter from BarnOwl',
-    usage       => 'twitter [ACCOUNT] [MESSAGE]',
+    usage       => 'twitter [ACCOUNT [MESSAGE]]',
     description => 'Update Twitter on ACCOUNT. If MESSAGE is provided, use it as your status.'
     . "\nIf no ACCOUNT is provided, update all services which have publishing enabled."
@@ -259 +259 @@
     {
     summary     => 'Send a Twitter @ message',
-    usage       => 'twitter-atreply USER [ACCOUNT]',
+    usage       => 'twitter-atreply USER [ID [ACCOUNT]]',
     description => 'Send a Twitter @reply Message to USER on ACCOUNT (defaults to default_sender,' 
     . "\nor first service if no default is provided)"