Changeset 3d0a253


Ignore:
Timestamp:
Mar 1, 2010, 8:33:49 PM (10 years ago)
Author:
Nelson Elhage <nelhage@mit.edu>
Branches:
release-1.5
Children:
dd8340b
Parents:
526f630
git-author:
Anders Kaseorg <andersk@mit.edu> (02/28/10 16:41:01)
git-committer:
Nelson Elhage <nelhage@mit.edu> (03/01/10 20:33:49)
Message:
owl_command_aimwrite: Fix a buffer overflow on aimwrite -m.

I’ve tested that this works at least as well as the old code.  There’s
still something wrong here because aimwrite concatenates its arguments
to get the screenname and aimwrite -m doesn’t, but I don’t care
anymore because libfaim is going away (right?  RIGHT?).

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Reviewed-by: Sam Hartman <hartmans@mit.edu>
File:
1 edited

Legend:

Unmodified
Added
Removed
  • commands.c

    r6700c605 r3d0a253  
    19211921        newbuff[strlen(newbuff) - 1] = '\0'; /* remove last space */
    19221922
    1923       recip=owl_malloc(strlen(argv[0])+5);
    1924       sprintf(recip, "%s ", argv[1]);
     1923      recip=owl_strdup(argv[1]);
    19251924      owl_aim_send_im(recip, newbuff);
    19261925      m=owl_function_make_outgoing_aim(newbuff, recip);
Note: See TracChangeset for help on using the changeset viewer.