Changeset 3d0a253

Timestamp:

Mar 1, 2010, 8:33:49 PM (14 years ago)

Author:

Nelson Elhage <nelhage@mit.edu>

Branches:

release-1.5

Children:

dd8340b

Parents:

526f630

git-author:

Anders Kaseorg <andersk@mit.edu> (02/28/10 16:41:01)

git-committer:

Nelson Elhage <nelhage@mit.edu> (03/01/10 20:33:49)

Message:

owl_command_aimwrite: Fix a buffer overflow on aimwrite -m.

I’ve tested that this works at least as well as the old code.  There’s
still something wrong here because aimwrite concatenates its arguments
to get the screenname and aimwrite -m doesn’t, but I don’t care
anymore because libfaim is going away (right?  RIGHT?).

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Reviewed-by: Sam Hartman <hartmans@mit.edu>

File:

• commands.c (modified) (1 diff)

commands.c

@@ -1921 +1921 @@
         newbuff[strlen(newbuff) - 1] = '\0'; /* remove last space */
 
-      recip=owl_malloc(strlen(argv[0])+5);
-      sprintf(recip, "%s ", argv[1]);
+      recip=owl_strdup(argv[1]);
       owl_aim_send_im(recip, newbuff);
       m=owl_function_make_outgoing_aim(newbuff, recip);