Changeset 42c2a80

Timestamp:

Jul 21, 2009, 8:28:40 PM (15 years ago)

Author:

Anders Kaseorg <andersk@mit.edu>

Branches:

master, release-1.10, release-1.4, release-1.5, release-1.6, release-1.7, release-1.8, release-1.9

Children:

3e328b8

Parents:

7f6a8a2

git-author:

Anders Kaseorg <andersk@mit.edu> (07/21/09 20:24:06)

git-committer:

Anders Kaseorg <andersk@mit.edu> (07/21/09 20:28:40)

Message:

owl_command_multi: Fix crash on malformed multi command.

Test case:
:multi ( z

Signed-off-by: Anders Kaseorg <andersk@mit.edu>

File:

• commands.c (modified) (3 diffs)

commands.c

@@ -1616 +1616 @@
 char *owl_command_multi(int argc, char **argv, char *buff)
 {
-  char *lastrv = NULL, *dupbuff, *newbuff;
+  char *lastrv = NULL, *newbuff;
   char **commands;
   int  ncommands, i;
@@ -1623 +1623 @@
     return NULL;
   }
-  dupbuff = owl_strdup(buff);
-  newbuff = skiptokens(dupbuff, 1);
+  newbuff = owl_strdup(skiptokens(buff, 1));
   if (!strcmp(argv[0], "(")) {
     for (i=strlen(newbuff)-1; i>=0; i--) {
@@ -1644 +1643 @@
     lastrv = owl_function_command(commands[i]);
   }
-  owl_free(dupbuff);
+  owl_free(newbuff);
   atokenize_free(commands, ncommands);
   return lastrv;