Changeset 4479497

Timestamp:

Mar 24, 2011, 12:46:25 AM (14 years ago)

Author:

Anders Kaseorg <andersk@mit.edu>

Branches:

master, release-1.10, release-1.8, release-1.9

Children:

42ee1be

Parents:

82b734a

git-author:

David Benjamin <davidben@MIT.EDU> (02/26/11 00:52:13)

git-committer:

Anders Kaseorg <andersk@mit.edu> (03/24/11 00:46:25)

Message:

Use G_GNUC_PRINTF to get type-checking on our format strings

The extra type-checking is nice.

[andersk@mit.edu: Move G_GNUC_PRINTF such that no further preprocessor
 magic is needed]
Signed-off-by: Anders Kaseorg <andersk@mit.edu>

Files:

• configure.ac (modified) (1 diff)
• fmtext.c (modified) (1 diff)
• functions.c (modified) (3 diffs)

configure.ac

@@ -131 +131 @@
 AX_C_CHECK_FLAG([-Wstrict-prototypes],[],[],[AM_CFLAGS="$AM_CFLAGS -Wstrict-prototypes"])
 
+dnl Shut gcc up about zero-length format strings; the warning's apparently for
+dnl efficiency reasons, which is bogus for custom functions.
+AX_C_CHECK_FLAG([-Wno-format-zero-length],[],[],[AM_CFLAGS="$AM_CFLAGS -Wno-format-zero-length"])
+
 m4_foreach([myflag],
   [[-Wno-pointer-sign],[-Wno-empty-body],[-Wno-unused-value]],

fmtext.c

@@ -56 +56 @@
 
 /* Append normal, uncolored text specified by format string to 'f' */
-void owl_fmtext_appendf_normal(owl_fmtext *f, const char *fmt, ...)
+void G_GNUC_PRINTF(2, 3) owl_fmtext_appendf_normal(owl_fmtext *f, const char *fmt, ...)
 {
   va_list ap;

functions.c

@@ -1202 +1202 @@
 }
 
-void owl_function_debugmsg(const char *fmt, ...)
+void G_GNUC_PRINTF(1, 2) owl_function_debugmsg(const char *fmt, ...)
 {
   FILE *file;
@@ -3346 +3346 @@
 }
 
-void owl_function_error(const char *fmt, ...)
+void G_GNUC_PRINTF(1, 2) owl_function_error(const char *fmt, ...)
 {
   static int in_error = 0;
@@ -3414 +3414 @@
 }
 
-void owl_function_makemsg(const char *fmt, ...)
+void G_GNUC_PRINTF(1, 2) owl_function_makemsg(const char *fmt, ...)
 {
   va_list ap;