Changeset 4811422

Timestamp:

Sep 18, 2010, 5:07:40 PM (15 years ago)

Author:

David Benjamin <davidben@mit.edu>

Branches:

master, release-1.10, release-1.7, release-1.8, release-1.9

Children:

09ceee3

Parents:

5f0bcde

git-author:

David Benjamin <davidben@mit.edu> (08/15/10 16:25:03)

git-committer:

David Benjamin <davidben@mit.edu> (09/18/10 17:07:40)

Message:

Delay realizing a window until we need it for painting

This avoids WINDOW churn if we show and hide windows a lot.

File:

• window.c (modified) (5 diffs)

window.c

@@ -328 +328 @@
 }
 
+static void _owl_window_realize_later(owl_window *w)
+{
+  if (owl_window_is_realized(w) || !_owl_window_should_realize(w))
+    return;
+  owl_window_dirty(w);
+}
+
 static void _owl_window_realize(owl_window *w)
 {
@@ -341 +348 @@
   owl_window_dirty(w);
   /* map the children */
-  owl_window_children_foreach(w, (GFunc)_owl_window_realize, 0);
+  owl_window_children_foreach(w, (GFunc)_owl_window_realize_later, 0);
 }
 
@@ -390 +397 @@
 void owl_window_dirty(owl_window *w)
 {
-  if (!owl_window_is_realized(w))
+  if (!_owl_window_should_realize(w))
     return;
   if (!w->dirty) {
@@ -409 +416 @@
 {
   if (!w->dirty) return;
+  _owl_window_realize(w);
   if (w->win && !w->is_screen) {
     if (owl_window_is_subwin(w)) {
@@ -493 +501 @@
   if (w->shown) {
     /* ncurses is screwy: give up and recreate windows at the right place */
-    _owl_window_realize(w);
+    _owl_window_realize_later(w);
   }
 }