Changeset 4eee948

Timestamp:

Jun 12, 2010, 3:29:01 PM (14 years ago)

Author:

David Benjamin <davidben@mit.edu>

Branches:

master, release-1.10, release-1.7, release-1.8, release-1.9

Children:

438409f

Parents:

358eeae

git-author:

David Benjamin <davidben@mit.edu> (06/04/10 16:52:22)

git-committer:

David Benjamin <davidben@mit.edu> (06/12/10 15:29:01)

Message:

Eugh. Create the sepwin before the recwin

The sepwin depends on a value computed by the recwin's draw handler.
This is kinda nasty...

Files:

• doc/owl-window.txt (modified) (1 diff)
• mainpanel.c (modified) (1 diff)

doc/owl-window.txt

@@ -175 +175 @@
   everywhere; the signals can automatically disconnect in the right
   contexts if we do.
+
+- The sepbar depends on a value computed while the mainwin is drawn,
+  so we currently ensure the windows are created in the right order
+  for the repaints to occur correctly. This is rather poor and should
+  be refactored later.

mainpanel.c

@@ -5 +5 @@
   /* Create windows */
   mp->panel = owl_window_new(NULL);
+  /* HACK for now: the sepwin must be drawn /after/ the recwin for
+   * lastdisplayed to work */
+  mp->sepwin = owl_window_new(mp->panel);
   mp->recwin = owl_window_new(mp->panel);
-  mp->sepwin = owl_window_new(mp->panel);
   mp->msgwin = owl_window_new(mp->panel);
   mp->typwin = owl_window_new(mp->panel);