Changeset 5547211b for global.c

Timestamp:

Dec 13, 2008, 5:32:06 PM (15 years ago)

Author:

Nelson Elhage <nelhage@mit.edu>

Children:

1c014eec

Parents:

44fc93b

git-author:

Anders Kaseorg <andersk@mit.edu> (12/06/08 23:20:19)

git-committer:

Nelson Elhage <nelhage@mit.edu> (12/13/08 17:32:06)

Message:

Replace questionable sprintf(buf, "%s...", buf, ...) pattern, which is
broken by -D_FORTIFY_SOURCE.

perl -pe 's/(sprintf\s*\(\s*([^,]*))(\s*,\s*")%s([^"]*"\s*,)\s*\2\s*,/\1 + strlen(\2)\3\4/g'

File:

• global.c (modified) (1 diff)

global.c

@@ -570 +570 @@
   strcpy(g->startupargs, "");
   for (i=0; i<argc; i++) {
-    sprintf(g->startupargs, "%s%s ", g->startupargs, argv[i]);
+    sprintf(g->startupargs + strlen(g->startupargs), "%s ", argv[i]);
   }
   g->startupargs[strlen(g->startupargs)-1]='\0';