Changeset 554a2b8 for regex.c

Timestamp:

Dec 6, 2008, 2:33:28 AM (16 years ago)

Author:

Anders Kaseorg <andersk@mit.edu>

Branches:

master, debian, release-1.10, release-1.4, release-1.5, release-1.6, release-1.7, release-1.8, release-1.9

Children:

6eaf35b

Parents:

2aaca94

git-author:

Anders Kaseorg <andersk@mit.edu> (12/06/08 01:42:34)

git-committer:

Anders Kaseorg <andersk@mit.edu> (12/06/08 02:33:28)

Message:

Fix format string injection bugs.

File:

• regex.c (modified) (2 diffs)

regex.c

@@ -13 +13 @@
 {
   int ret;
-  char buff1[LINE], buff2[LINE];
+  char buff1[LINE];
   char *ptr;
   
@@ -29 +29 @@
   if (ret) {
     regerror(ret, NULL, buff1, LINE);
-    sprintf(buff2, "Error in regular expression: %s", buff1);
-    owl_function_makemsg(buff2);
+    owl_function_makemsg("Error in regular expression: %s", buff1);
     owl_free(re->string);
     re->string=NULL;