Changeset 55b2de8 for variable.c

Timestamp:

May 12, 2011, 4:39:26 PM (14 years ago)

Author:

David Benjamin <davidben@mit.edu>

Children:

7fd0bf7

Parents:

13ee8f2

git-author:

David Benjamin <davidben@mit.edu> (05/07/11 15:12:09)

git-committer:

David Benjamin <davidben@mit.edu> (05/12/11 16:39:26)

Message:

Remove NULL checks before calling g_free

g_free handles the NULL check for us.

File:

• variable.c (modified) (4 diffs)

variable.c

@@ -641 +641 @@
 
 void owl_variable_update(owl_variable *var, const char *summary, const char *desc) {
-  if(var->summary) g_free(var->summary);
+  g_free(var->summary);
   var->summary = g_strdup(summary);
-  if(var->description) g_free(var->description);
+  g_free(var->description);
   var->description = g_strdup(desc);
 }
@@ -651 +651 @@
   if(old) {
     owl_variable_update(old, summ, desc);
-    if(old->pval_default) g_free(old->pval_default);
+    g_free(old->pval_default);
     old->pval_default = g_strdup(initval);
   } else {
@@ -944 +944 @@
 void owl_variable_delete_default(owl_variable *v)
 {
-  if (v->val) g_free(v->val);
+  g_free(v->val);
 }
 
@@ -1076 +1076 @@
     if (!v->validate_fn(v, newval)) return(-1);
   }
-  if (v->val) g_free(v->val);
+  g_free(v->val);
   v->val = g_strdup(newval);
   return(0);