Changeset 5657d53

Timestamp:

Mar 29, 2009, 1:49:55 PM (15 years ago)

Author:

Alejandro R. Sedeño <asedeno@mit.edu>

Branches:

master, debian, release-1.10, release-1.4, release-1.5, release-1.6, release-1.7, release-1.8, release-1.9

Children:

d9bfc82

Parents:

0741984

Message:

Process zephyr prior to owl_select(). [more]

Some libzephyr functions, such as ZLocateUser(), ZSetLocation() and
ZUnsetLocation() call Z_WaitForNotice(), which has an internal select
loop on the zephyr FD. It may leave pending zephyrs unprocessed, and
the FD won't have anything to be read. This can leave a zephyr in the
queue until the next zephyr comes in.

Before calling into owl_select() loop, call
owl_zephyr_process_events() and deal with any pending
zephyrs. ZPending is quick, and we usually shouldn't have anything to
process here anyhow.

reported by: kretch

File:

• owl.c (modified) (1 diff)

owl.c

@@ -449 +449 @@
       owl_global_set_noneedrefresh(&g);
     }
+
+    /* Some calls into libzephyr call Z_WaitForNotice(), which has its
+     * own select loop and may leave zephyrs on the queue. Check for
+     * them now, and process any we find. */
+    owl_zephyr_process_events(NULL);
 
     /* select on FDs we know about. */