Changeset 60e8617


Ignore:
Timestamp:
Apr 5, 2013, 3:27:48 PM (11 years ago)
Author:
David Benjamin <davidben@mit.edu>
Branches:
master, release-1.10
Children:
52bee9c, 24ece84, 109eb89
Parents:
89f01bd
git-author:
David Benjamin <davidben@mit.edu> (04/05/13 15:24:24)
git-committer:
David Benjamin <davidben@mit.edu> (04/05/13 15:27:48)
Message:
Don't swallow errors in :unsuball

More code that should get fixed if we ever use GError or some other saner error
reporting mechanism. For now, I suppose this mess with the lower-level function
reporting error and the higher-level function reporting success is in good
company.

Test by doing a kdestroy before :unsuball. It should complain about a SERVNAK.
(It really should complain about missing credentials cache, but apparently
libzephyr tries again without auth in ZCancelSubscription even though the
server rejects unauthenticated ones. Meh.)
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • functions.c

    r05adccf r60e8617  
    855855void owl_function_unsuball(void)
    856856{
    857   unsuball();
    858   owl_function_makemsg("Unsubscribed from all messages.");
     857  if (unsuball())
     858    owl_function_makemsg("Unsubscribed from all messages.");
    859859}
    860860
  • zephyr.c

    r89f01bd r60e8617  
    455455}
    456456
    457 void unsuball(void)
     457bool unsuball(void)
    458458{
    459459#if HAVE_LIBZEPHYR
     
    465465    owl_function_error("Zephyr: Cancelling subscriptions: %s",
    466466                       error_message(ret));
    467 #endif
     467  return (ret == ZERR_NONE);
     468#endif
     469  return true;
    468470}
    469471
Note: See TracChangeset for help on using the changeset viewer.