Changeset 6425d43

Timestamp:

Sep 18, 2010, 3:17:27 PM (14 years ago)

Author:

David Benjamin <davidben@mit.edu>

Branches:

master, release-1.10, release-1.7, release-1.8, release-1.9

Children:

4cf7b1b

Parents:

dc9665a

git-author:

David Benjamin <davidben@mit.edu> (07/31/10 20:03:53)

git-committer:

David Benjamin <davidben@mit.edu> (09/18/10 15:17:27)

Message:

Don't cause confusion if owl_popwin_up on an active popwin

Likewise, inactive popwins should not be closeable. The function returns
int, so we may as well return an error, but no one checks that.

File:

• popwin.c (modified) (2 diffs)

popwin.c

@@ -9 +9 @@
 int owl_popwin_up(owl_popwin *pw)
 {
+  if (pw->active)
+    return 1;
   pw->border = owl_window_new(NULL);
   pw->content = owl_window_new(pw->border);
@@ -69 +71 @@
 int owl_popwin_close(owl_popwin *pw)
 {
+  if (!pw->active)
+    return 1;
   owl_window_unlink(pw->border);
   g_object_unref(pw->border);