Changeset 6646fdb for functions.c

Timestamp:

Sep 7, 2011, 10:06:08 AM (13 years ago)

Author:

David Benjamin <davidben@mit.edu>

Branches:

master, release-1.10, release-1.9

Children:

732d5c0, bcb84df

Parents:

3b17b57

git-author:

David Benjamin <davidben@mit.edu> (08/01/11 02:03:32)

git-committer:

David Benjamin <davidben@mit.edu> (09/07/11 10:06:08)

Message:

Restore correct semantics of message 'time' attribute

This rewrites part of 4ebbfbc5360fa004637dd101f5a0c833cdccd60a. We can't
replace every instance of ctime with a user-formatted time, as the time
attribute is not user-formatted. It is (unfortunately) the API for perl
to override the timestamp and owl_perlconfig_hashref2message expects a
particular format for strptime. We should not then flip the values
around once they reach C. (Especially not a locale-dependent one.)

Rename *_to_timestr functions to owl_util_format_* so it is clear the
function should only be used for user-formatted times.

File:

• functions.c (modified) (6 diffs)

functions.c

@@ -1223 +1223 @@
   now = time(NULL);
 
-  tmpbuff = owl_util_time_to_timestr(localtime(&now));
+  tmpbuff = owl_util_format_time(localtime(&now));
   fprintf(file, "[%d -  %s - %lds]: ",
           (int) getpid(), tmpbuff, now - owl_global_get_starttime(&g));
@@ -1373 +1373 @@
   owl_fmtext fm, attrfm;
   const owl_view *v;
+  char *time;
 #ifdef HAVE_LIBZEPHYR
   const ZNotice_t *n;
@@ -1403 +1404 @@
   }
 
-  owl_fmtext_appendf_normal(&fm, "  Time      : %s\n", owl_message_get_timestr(m));
+  time = owl_message_format_time(m);
+  owl_fmtext_appendf_normal(&fm, "  Time      : %s\n", time);
+  g_free(time);
 
   if (!owl_message_is_type_admin(m)) {
@@ -1776 +1779 @@
   owl_fmtext_append_normal(&fm, "\n");
 
-  tmpbuff = owl_util_time_to_timestr(localtime(&start));
+  tmpbuff = owl_util_format_time(localtime(&start));
   owl_fmtext_appendf_normal(&fm, "  Startup Time: %s\n", tmpbuff);
   g_free(tmpbuff);
@@ -3072 +3075 @@
       idle=owl_buddy_get_idle_time(b);
       if (idle!=0) {
-        timestr=owl_util_minutes_to_timestr(idle);
+        timestr=owl_util_format_minutes(idle);
       } else {
         timestr=g_strdup("");
@@ -3401 +3404 @@
 
   now = time(NULL);
-  date = owl_util_time_to_timestr(localtime(&now));
+  date = owl_util_format_time(localtime(&now));
 
   buff = g_strdup_printf("%s %s", date, string);