Changeset 6a5f0c3 for perlconfig.c

Timestamp:

Dec 25, 2013, 3:22:29 PM (10 years ago)

Author:

Anders Kaseorg <andersk@mit.edu>

Children:

b36b9a6

Parents:

58777e9

git-author:

Anders Kaseorg <andersk@mit.edu> (12/25/13 12:53:27)

git-committer:

Anders Kaseorg <andersk@mit.edu> (12/25/13 15:22:29)

Message:

owl_message_set_attribute: Take a destroy function for the value

In the case of constant strings, and ZNotice_t fields other than the
body, this lets us avoid wasting memory on unnecessary string copies.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>

File:

• perlconfig.c (modified) (3 diffs)

perlconfig.c

@@ -195 +195 @@
     key = hv_iterkey(ent, &len);
     val = SvPV_nolen(hv_iterval(hash, ent));
-    if(!strcmp(key, "type")) {
-      owl_message_set_type(m, val);
-    } else if(!strcmp(key, "direction")) {
+    if (!strcmp(key, "direction")) {
       owl_message_set_direction(m, owl_message_parse_direction(val));
     } else if(!strcmp(key, "private")) {
@@ -206 +204 @@
     } else if (!strcmp(key, "hostname")) {
       owl_message_set_hostname(m, val);
-    } else if (!strcmp(key, "zwriteline")) {
-      owl_message_set_zwriteline(m, val);
     } else if (!strcmp(key, "time")) {
       g_free(m->timestr);
@@ -214 +210 @@
       m->time = mktime(&tm);
     } else {
-      owl_message_set_attribute(m, key, val);
+      owl_message_set_attribute(m, key, g_strdup(val), g_free);
     }
   }
   if(owl_message_is_type_admin(m)) {
     if(!owl_message_get_attribute_value(m, "adminheader"))
-      owl_message_set_attribute(m, "adminheader", "");
+      owl_message_set_attribute(m, "adminheader", "", NULL);
   }
   return m;