Changeset 6cd3a0f

Timestamp:

Aug 5, 2017, 10:54:36 PM (7 years ago)

Author:

Jason Gross <jgross@mit.edu>

Children:

a2317ca

Parents:

4c0e713

git-author:

Jason Gross <jgross@mit.edu> (08/05/17 21:21:44)

git-committer:

Jason Gross <jgross@mit.edu> (08/05/17 22:54:36)

Message:

Add comments to logging.c

We note that defer_logs is only accessed on the disk-writing thread.

File:

• logging.c (modified) (3 diffs)

logging.c

@@ -11 +11 @@
 static GMainLoop *log_loop;
 static GThread *logging_thread;
-static bool defer_logs;
+static bool defer_logs; /* to be accessed only on the disk-writing thread */
 static GQueue *deferred_entry_queue;
 
@@ -246 +246 @@
  * EPERM, EACCES, or ETIMEDOUT, go into deferred logging mode and
  * queue an admin message.  If it fails with anything else, display an
- * error message, but do not go into deferred logging mode. */
+ * error message, but do not go into deferred logging mode.
+ *
+ * N.B. This function is called only on the disk-writing thread. */
 static void owl_log_eventually_write_entry(gpointer data)
 {
@@ -276 +278 @@
 }
 
-/* tries to write the deferred log entries */
+/* tries to write the deferred log entries
+ *
+ * N.B. This function is called only on the disk-writing thread. */
 static void owl_log_write_deferred_entries(gpointer data)
 {