Changeset 6dc2d6b for perlglue.xs

Timestamp:

Jul 27, 2009, 11:23:57 PM (15 years ago)

Author:

Nelson Elhage <nelhage@mit.edu>

Branches:

master, release-1.10, release-1.4, release-1.5, release-1.6, release-1.7, release-1.8, release-1.9

Children:

6551eae

Parents:

776c4bb

git-author:

Nelson Elhage <nelhage@mit.edu> (07/25/09 23:02:48)

git-committer:

Nelson Elhage <nelhage@mit.edu> (07/27/09 23:23:57)

Message:

save_excursion: Fix perl API error.

We need to save a mark and SPAGAIN around call_* macros. The old
behavior caused out-of-bounds stack dereferences and segfaults.

File:

• perlglue.xs (modified) (2 diffs)

perlglue.xs

@@ -485 +485 @@
         {
                 x = owl_editwin_begin_excursion(owl_global_get_typwin(&g));
+                PUSHMARK(SP);
                 count = call_sv(sub, G_SCALAR|G_EVAL|G_NOARGS);
+                SPAGAIN;
                 owl_editwin_end_excursion(owl_global_get_typwin(&g), x);
 
@@ -492 +494 @@
                 }
 
-                SPAGAIN;
                 if(count == 1)
                         RETVAL = SvREFCNT_inc(POPs);