Changeset 7013eb9

Timestamp:

Jan 5, 2011, 1:35:52 PM (13 years ago)

Author:

David Benjamin <davidben@mit.edu>

Branches:

release-1.7

Children:

4976e93

Parents:

2e5b2f9

git-author:

David Benjamin <davidben@mit.edu> (01/02/11 19:37:28)

git-committer:

David Benjamin <davidben@mit.edu> (01/05/11 13:35:52)

Message:

If a smartfilter fails to parse, handle the error

Otherwise we segfault. Of course, we should always succeed in creating a
filter, but we sometimes don't because of quoting bugs.

Files:

• commands.c (modified) (4 diffs)
• functions.c (modified) (6 diffs)

commands.c

@@ -2291 +2291 @@
   }
   filtname = owl_function_classinstfilt(argv[1], NULL, owl_global_is_narrow_related(&g));
-  owl_function_change_currentview_filter(filtname);
-  owl_free(filtname);
+  if (filtname) {
+    owl_function_change_currentview_filter(filtname);
+    owl_free(filtname);
+  }
   return NULL;
 }
@@ -2304 +2306 @@
   }
   filtname=owl_function_zuserfilt(argv[1]);
-  owl_function_change_currentview_filter(filtname);
-  owl_free(filtname);
+  if (filtname) {
+    owl_function_change_currentview_filter(filtname);
+    owl_free(filtname);
+  }
   return NULL;
 }
@@ -2395 +2399 @@
 char *owl_command_colorclass(int argc, const char *const *argv, const char *buff)
 {
-  const char *filtname;
+  char *filtname;
   
   if (argc < 3 || argc > 4) {
@@ -2403 +2407 @@
 
   filtname=owl_function_classinstfilt(argv[1], NULL, owl_global_is_narrow_related(&g));
-  (void) owl_function_color_filter(filtname, argv[2], (argc == 4 ? argv[3] : NULL));
+  if (filtname) {
+    (void) owl_function_color_filter(filtname, argv[2], (argc == 4 ? argv[3] : NULL));
+    owl_free(filtname);
+  }
   return NULL;
 }

functions.c

@@ -2280 +2280 @@
 /* Create a filter for a class, instance if one doesn't exist.  If
  * instance is NULL then catch all messgaes in the class.  Returns the
- * name of the filter, which the caller must free.
+ * name of the filter or null.  The caller must free this name.
  * If 'related' is nonzero, encompass unclasses and .d classes as well.
  */
@@ -2348 +2348 @@
 
   f = owl_filter_new_fromstring(filtname, argbuff);
+  owl_free(argbuff);
+  if (f == NULL) {
+    /* Couldn't make a filter for some reason. Return NULL. */
+    owl_function_error("Error creating filter '%s'", filtname);
+    owl_free(filtname);
+    filtname = NULL;
+    goto done;
+  }
 
   /* add it to the global list */
   owl_global_add_filter(&g, f);
 
-  owl_free(argbuff);
 done:
   owl_free(class);
@@ -2390 +2397 @@
       "recipient ^%1$s$ ) ) ) or ( ( class ^login$ ) and ( sender ^%1$s$ ) )",
       esclonguser);
+  owl_free(esclonguser);
 
   f = owl_filter_new_fromstring(filtname, argbuff);
+  owl_free(argbuff);
+
+  if (f == NULL) {
+    /* Couldn't make a filter for some reason. Return NULL. */
+    owl_function_error("Error creating filter '%s'", filtname);
+    owl_free(filtname);
+    return NULL;
+  }
 
   /* add it to the global list */
   owl_global_add_filter(&g, f);
-
-  /* free stuff */
-  owl_free(argbuff);
-  owl_free(esclonguser);
 
   return(filtname);
@@ -2430 +2442 @@
       "( sender ^%2$s$ and recipient ^%1$s$ ) ) )",
       escuser, owl_global_get_aim_screenname_for_filters(&g));
+  owl_free(escuser);
 
   f = owl_filter_new_fromstring(filtname, argbuff);
+  owl_free(argbuff);
+
+  if (f == NULL) {
+    owl_function_error("Error creating filter '%s'", filtname);
+    owl_free(filtname);
+    return NULL;
+  }
 
   /* add it to the global list */
   owl_global_add_filter(&g, f);
-
-  /* free stuff */
-  owl_free(argbuff);
-  owl_free(escuser);
 
   return(filtname);
@@ -2460 +2476 @@
 
   argbuff = owl_sprintf("type ^%s$", esctype);
+  owl_free(esctype);
 
   f = owl_filter_new_fromstring(filtname, argbuff);
+  owl_free(argbuff);
+
+  if (f == NULL) {
+    owl_function_error("Error creating filter '%s'", filtname);
+    owl_free(filtname);
+    return NULL;
+  }
 
   /* add it to the global list */
   owl_global_add_filter(&g, f);
-
-  /* free stuff */
-  owl_free(argbuff);
-  owl_free(esctype);
 
   return filtname;
@@ -2520 +2540 @@
   f = owl_filter_new_fromstring(filtname, buf->str);
   g_string_free(buf, true);
+
+  if (f == NULL) {
+    owl_function_error("Error creating filter '%s'", filtname);
+    owl_free(filtname);
+    return NULL;
+  }
 
   owl_global_add_filter(&g, f);