Changeset 731e921

Timestamp:

May 20, 2013, 12:05:54 PM (11 years ago)

Author:

Jason Gross <jgross@mit.edu>

Branches:

master, release-1.10

Children:

3bd3ee8, 60ae736, 25a5e3b

Parents:

53151d4

git-author:

Jason Gross <jgross@mit.edu> (02/24/13 19:05:43)

git-committer:

Jason Gross <jgross@mit.edu> (05/20/13 12:05:54)

Message:

Make check for non-existant channel more correct

Currently, this doesn't change anything; all channels start with '#'.
However, when pull #107 (Improve irc-msg support for multiple
connections) lands we want to accept, e.g., '0' as a valid user name.
So we should actually be checking if the value is defined, rather than
if it's not falsy.  Perhaps we should also exclude empty strings,
spaces, etc., as valid user names/channels.

File:

• perl/modules/IRC/lib/BarnOwl/Module/IRC.pm (modified) (1 diff)

perl/modules/IRC/lib/BarnOwl/Module/IRC.pm

@@ -615 +615 @@
         }
 
-        if(!$channel &&
+        if(!defined($channel) &&
            ($flags & CHANNEL_ARG) &&
            !($flags & CHANNEL_OPTIONAL)) {