Changes in / [883b421:76e80de]

Files:

• .gitignore (modified) (2 diffs)
• Makefile.am (modified) (6 diffs)
• commands.c (modified) (1 diff)
• functions.c (modified) (5 diffs)
• owl.c (modified) (4 diffs)
• owl.h (modified) (1 diff)
• perlconfig.c (modified) (1 diff)
• zcrypt.c (modified) (2 diffs)

.gitignore

@@ -4 +4 @@
 .deps
 /bin/
-BUILD_VERSION.mk
 META.yml
 MYMETA.yml
@@ -41 +40 @@
 tester
 varstubs.c
-version.c
-version.c.new
 zcrypt

Makefile.am

@@ -1 +1 @@
 ACLOCAL_AMFLAGS = -I m4
 
-GIT_DESCRIPTION := $(if $(wildcard $(srcdir)/.git),$(shell cd $(srcdir) && git describe --match='barnowl-*' HEAD 2>/dev/null))
-VERSION = $(if $(GIT_DESCRIPTION),$(GIT_DESCRIPTION:barnowl-%=%),@VERSION@)
--include BUILD_VERSION.mk
-
-FORCE:
-BUILD_VERSION.mk: $(if $(filter-out $(BUILD_VERSION),$(VERSION)),FORCE)
-        echo 'BUILD_VERSION = $(VERSION)' > $@
+GIT_DESCRIPTION := $(if $(wildcard .git),$(shell git describe --match='barnowl-*' HEAD 2>/dev/null))
+GIT_FLAGS := $(if $(GIT_DESCRIPTION),-DGIT_VERSION=$(GIT_DESCRIPTION:barnowl-%=%))
 
 bin_PROGRAMS = bin/barnowl
@@ -14 +9 @@
 endif
 
-zcrypt_SOURCES = zcrypt.c filterproc.c version.c
+zcrypt_SOURCES = zcrypt.c filterproc.c
 
 check_PROGRAMS = bin/tester
@@ -52 +47 @@
            -I$(top_srcdir)/libfaim/ \
            -DDATADIR='"$(pkgdatadir)"' \
-           -DBINDIR='"$(bindir)"'
+           -DBINDIR='"$(bindir)"' \
+           $(GIT_FLAGS)
 
 CODELIST_SRCS=message.c mainwin.c popwin.c zephyr.c messagelist.c \
@@ -68 +64 @@
 BASE_SRCS = $(CODELIST_SRCS) $(NORMAL_SRCS)
 
-GEN_C = varstubs.c perlglue.c gmarshal_funcs.c version.c version.c.new
+GEN_C = varstubs.c perlglue.c gmarshal_funcs.c
 GEN_H = owl_prototypes.h owl_prototypes.h.new gmarshal_funcs.h
 
-BUILT_SOURCES = $(GEN_H)
+BUILT_SOURCES = $(GEN_C) $(GEN_H)
 
 # Only copy file into place if file.new is different
-owl_prototypes.h version.c: %: %.new
+%: %.new
         @diff -U0 $@ $< || { \
          test -f $@ && echo '$@ changed!'; \
@@ -91 +87 @@
         $(AM_V_GEN)perl $< $(sort $(filter-out $<,$+)) > $@
 
-version.c.new: Makefile BUILD_VERSION.mk
-        $(AM_V_GEN)echo 'const char *version = "$(VERSION)";' > $@
-
 gmarshal_funcs.h: marshal_types
         glib-genmarshal --header $< > $@
@@ -103 +96 @@
         $(COMPILE) -Wall -Wextra -pedantic -fsyntax-only $(CHK_SOURCES)
 
-CLEANFILES = $(BUILT_SOURCES) $(GEN_C) $(noinst_SCRIPTS) $(check_SCRIPTS) BUILD_VERSION.mk
+CLEANFILES = $(BUILT_SOURCES) $(noinst_SCRIPTS) $(check_SCRIPTS)
 EXTRA_DIST = \
     autogen.sh \

commands.c

@@ -1114 +1114 @@
 void owl_command_version(void)
 {
-  owl_function_makemsg("BarnOwl version %s", version);
+  owl_function_makemsg("BarnOwl version %s", OWL_VERSION_STRING);
 }
 

functions.c

@@ -115 +115 @@
 void owl_function_show_license(void)
 {
-  char *text = g_strdup_printf(
-    "BarnOwl version %s\n"
+  const char *text;
+
+  text=""
+    "BarnOwl version " OWL_VERSION_STRING "\n"
     "Copyright (c) 2006-2011 The BarnOwl Developers. All rights reserved.\n"
     "Copyright (c) 2004 James Kretchmar. All rights reserved.\n"
@@ -153 +155 @@
     "WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE\n"
     "OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN\n"
-    "IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n",
-    version);
+    "IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n";
   owl_function_popless_text(text);
-  g_free(text);
 }
 
@@ -1359 +1359 @@
 void owl_function_about(void)
 {
-  char *text = g_strdup_printf(
-    "This is BarnOwl version %s.\n\n"
+  owl_function_popless_text(
+    "This is BarnOwl version " OWL_VERSION_STRING ".\n\n"
     "BarnOwl is a fork of the Owl zephyr client, written and\n"
     "maintained by Alejandro Sedeno and Nelson Elhage at the\n"
@@ -1379 +1379 @@
     "This program is free software. You can redistribute it and/or\n"
     "modify under the terms of the Sleepycat License. Use the \n"
-      "':show license' command to display the full license\n",
-      version);
-  owl_function_popless_text(text);
-  g_free(text);
+    "':show license' command to display the full license\n"
+  );
 }
 
@@ -1783 +1781 @@
 
   owl_fmtext_append_normal(&fm, "  Version: ");
-  owl_fmtext_append_normal(&fm, version);
+  owl_fmtext_append_normal(&fm, OWL_VERSION_STRING);
   owl_fmtext_append_normal(&fm, "\n");
 

owl.c

@@ -36 +36 @@
 void usage(FILE *file)
 {
-  fprintf(file, "Barnowl version %s\n", version);
+  fprintf(file, "Barnowl version %s\n", OWL_VERSION_STRING);
   fprintf(file, "Usage: barnowl [-n] [-d] [-D] [-v] [-h] [-c <configfile>] [-s <confdir>] [-t <ttyname>]\n");
   fprintf(file, "  -n,--no-subs        don't load zephyr subscriptions\n");
@@ -80 +80 @@
       break;
     case 'v':
-      printf("This is BarnOwl version %s\n", version);
+      printf("This is BarnOwl version %s\n", OWL_VERSION_STRING);
       exit(0);
     case 'h':
@@ -578 +578 @@
   /* welcome message */
   owl_function_debugmsg("startup: creating splash message");
-  char *welcome = g_strdup_printf(
+  owl_function_adminmsg("",
     "-----------------------------------------------------------------------\n"
-    "Welcome to BarnOwl version %s.\n"
+    "Welcome to BarnOwl version " OWL_VERSION_STRING ".\n"
     "To see a quick introduction, type ':show quickstart'.                  \n"
     "Press 'h' for on-line help.                                            \n"
@@ -588 +588 @@
     "                                                                 OvO   \n"
     "Please report any bugs or suggestions to bug-barnowl@mit.edu    (   )  \n"
-    "-----------------------------------------------------------------m-m---\n",
-    version);
-  owl_function_adminmsg("", welcome);
-  g_free(welcome);
+    "-----------------------------------------------------------------m-m---\n"
+  );
 
   owl_function_debugmsg("startup: setting context interactive");

owl.h

@@ -64 +64 @@
 #include "window.h"
 
-extern const char *version;
+#ifndef OWL_VERSION_STRING
+#ifdef  GIT_VERSION
+#define stringify(x)       __stringify(x)
+#define __stringify(x)     #x
+#define OWL_VERSION_STRING stringify(GIT_VERSION)
+#else
+#define OWL_VERSION_STRING PACKAGE_VERSION
+#endif
+#endif /* !OWL_VERSION_STRING */
 
 /* Feature that is being tested to redirect stderr through a pipe. 

perlconfig.c

@@ -336 +336 @@
   }
 
-  sv_setpv(get_sv("BarnOwl::VERSION", TRUE), version);
+  sv_setpv(get_sv("BarnOwl::VERSION", TRUE), OWL_VERSION_STRING);
 
   /* Add the system lib path to @INC */

zcrypt.c

@@ -29 +29 @@
 #include "filterproc.h"
 
-extern const char *version;
+#ifndef OWL_VERSION_STRING
+#ifdef  GIT_VERSION
+#define stringify(x)       __stringify(x)
+#define __stringify(x)     #x
+#define OWL_VERSION_STRING stringify(GIT_VERSION)
+#else
+#define OWL_VERSION_STRING PACKAGE_VERSION
+#endif
+#endif /* !OWL_VERSION_STRING */
 
 /* Annotate functions in which the caller owns the return value and is
@@ -149 +157 @@
       case OPT_VERSION:
         /* Version */
-        printf("This is zcrypt version %s\n", version);
+        printf("This is zcrypt version %s\n", OWL_VERSION_STRING);
         exit(0);
       case OPT_HELP: