Changeset 7d7326c

Timestamp:

Oct 23, 2010, 2:53:16 PM (14 years ago)

Author:

David Benjamin <davidben@mit.edu>

Branches:

master, release-1.10, release-1.7, release-1.8, release-1.9

Children:

a04218c

Parents:

4c0ac34

git-author:

David Benjamin <davidben@mit.edu> (10/23/10 04:44:56)

git-committer:

David Benjamin <davidben@mit.edu> (10/23/10 14:53:16)

Message:

When deleting a variable, clean-up strings

Variables allocated from perl strdup their strings. Make this consistent
and free them afterwards.

File:

• variable.c (modified) (2 diffs)

variable.c

@@ -481 +481 @@
     cur = owl_malloc(sizeof(owl_variable));
     *cur = *var;
+    /* strdup all the strings so we can delete them consistently. */
+    cur->name = owl_strdup(var->name);
+    cur->summary = owl_strdup(var->summary);
+    cur->description = owl_strdup(var->description);
     switch (cur->type) {
     case OWL_VARIABLE_OTHER:
@@ -642 +646 @@
 {
   if (v->delete_fn) v->delete_fn(v);
+  owl_free(v->name);
+  owl_free(v->summary);
+  owl_free(v->description);
   owl_free(v);
 }