Changeset 7dfe886 for owl.h


Ignore:
Timestamp:
Jun 19, 2011, 2:44:13 AM (13 years ago)
Author:
Jason Gross <jgross@mit.edu>
Children:
b0e6560
Parents:
9d43dcc
git-author:
Jason Gross <jgross@mit.edu> (06/06/11 05:24:30)
git-committer:
Jason Gross <jgross@mit.edu> (06/19/11 02:44:13)
Message:
Use G_GNUC_WARN_UNUSED_RESULT

Have gcc warn us when we ignore the result of a function that requires
the caller to free the result, or an initilization function that can
fail.  This might help (slightly) with preventing leaks and segfaults.

Additionally changed some functions that should never fail to not
return values.  (The owl_list_* functions changed only fail if
list->size < 0, which we assume is not the case elsewhere.)
File:
1 edited

Legend:

Unmodified
Added
Removed

  • owl.h

    r24a791f r7dfe886  
    255255                                 * WARNING:  this approach is hard to make
    256256                                 * thread-safe... */
    257   char *(*get_tostring_fn)(const struct _owl_variable *v, const void *val);
     257  char G_GNUC_WARN_UNUSED_RESULT *(*get_tostring_fn)(const struct _owl_variable *v, const void *val);
    258258                                /* converts val to a string;
    259259                                 * caller must free the result */
    … …  
    317317 
    318318  /* These don't take any context */
    319   char *(*cmd_args_fn)(int argc, const char *const *argv, const char *buff); 
     319  char G_GNUC_WARN_UNUSED_RESULT *(*cmd_args_fn)(int argc, const char *const *argv, const char *buff);
    320320                                /* takes argv and the full command as buff.
    321321                                 * caller must free return value if !NULL */
    … …  
    324324
    325325  /* The following also take the active context if it's valid */
    326   char *(*cmd_ctxargs_fn)(void *ctx, int argc, const char *const *argv, const char *buff); 
     326  char G_GNUC_WARN_UNUSED_RESULT *(*cmd_ctxargs_fn)(void *ctx, int argc, const char *const *argv, const char *buff);
    327327                                /* takes argv and the full command as buff.
    328328                                 * caller must free return value if !NULL */
Note: See TracChangeset for help on using the changeset viewer.