Changeset 7dfe886 for text.c

Timestamp:

Jun 19, 2011, 2:44:13 AM (13 years ago)

Author:

Jason Gross <jgross@mit.edu>

Children:

b0e6560

Parents:

9d43dcc

git-author:

Jason Gross <jgross@mit.edu> (06/06/11 05:24:30)

git-committer:

Jason Gross <jgross@mit.edu> (06/19/11 02:44:13)

Message:

Use G_GNUC_WARN_UNUSED_RESULT

Have gcc warn us when we ignore the result of a function that requires
the caller to free the result, or an initilization function that can
fail.  This might help (slightly) with preventing leaks and segfaults.

Additionally changed some functions that should never fail to not
return values.  (The owl_list_* functions changed only fail if
list->size < 0, which we assume is not the case elsewhere.)

File:

• text.c (modified) (6 diffs)

text.c

@@ -7 +7 @@
 /* Returns a copy of 'in' with each line indented 'n'
  * characters. Result must be freed with g_free. */
-char *owl_text_indent(const char *in, int n)
+G_GNUC_WARN_UNUSED_RESULT char *owl_text_indent(const char *in, int n)
 {
   const char *ptr1, *ptr2, *last;
@@ -48 +48 @@
 
 /* caller must free the return */
-char *owl_text_htmlstrip(const char *in)
+G_GNUC_WARN_UNUSED_RESULT char *owl_text_htmlstrip(const char *in)
 {
   const char *ptr1, *end, *ptr2, *ptr3;
@@ -129 +129 @@
 
 /* Caller must free return */
-char *owl_text_expand_tabs(const char *in)
+G_GNUC_WARN_UNUSED_RESULT char *owl_text_expand_tabs(const char *in)
 {
   int len = 0;
@@ -188 +188 @@
 
 /* caller must free the return */
-char *owl_text_wordwrap(const char *in, int col)
+G_GNUC_WARN_UNUSED_RESULT char *owl_text_wordwrap(const char *in, int col)
 {
   char *out;
@@ -269 +269 @@
  * Caller must free returned string.
  */
-char *owl_text_substitute(const char *in, const char *from, const char *to)
+G_GNUC_WARN_UNUSED_RESULT char *owl_text_substitute(const char *in, const char *from, const char *to)
 {
   char **split = g_strsplit(in, from, 0), *out;
@@ -284 +284 @@
  * On success returns the string, on error returns NULL.
  */
-char *owl_text_quote(const char *in, const char *toquote, const char *quotestr)
+G_GNUC_WARN_UNUSED_RESULT char *owl_text_quote(const char *in, const char *toquote, const char *quotestr)
 {
   int i, x, r, place, escape;