Changeset 7efa163 for perl/modules

Timestamp:

Sep 20, 2011, 11:15:33 PM (13 years ago)

Author:

Edward Z. Yang <ezyang@mit.edu>

Branches:

master, release-1.10, release-1.9

Children:

f4037cf

Parents:

1d11b78

git-author:

Edward Z. Yang <ezyang@mit.edu> (07/30/11 23:27:31)

git-committer:

Edward Z. Yang <ezyang@mit.edu> (09/20/11 23:15:33)

Message:

Wordwrap, write the config, style wibbles.

Signed-off-by: Edward Z. Yang <ezyang@mit.edu>

Location:

perl/modules/Facebook/lib/BarnOwl/Module

Files:

• Facebook.pm (modified) (4 diffs)
• Facebook/Handle.pm (modified) (9 diffs)

perl/modules/Facebook/lib/BarnOwl/Module/Facebook.pm

@@ -61 +61 @@
 #BarnOwl::new_command('facebook-message' => \&cmd_facebook_direct, {
 #    summary     => 'Send a Facebook message',
-#    usage       => 'twitter-direct USER',
-#    description => 'Send a private Facebook Message to USER.'
+#    usage       => 'facebook-message USER',
+#    description => 'Send a private Facebook message to USER.'
 #});
 
@@ -93 +93 @@
     BarnOwl::start_edit_win(
         defined $user ? "Write something to $user..." : "What's on your mind?",
-        sub{ $facebook_handle->facebook($user, shift) }
+        sub { $facebook_handle->facebook($user, shift) }
     );
 }
@@ -132 +132 @@
 sub check_ready {
     if (!$facebook_handle->{logged_in}) {
-        BarnOwl::message("Need to login to Facebook first with ':facebook-auth'.");
+        BarnOwl::message("You need to login to Facebook first with ':facebook-auth'.");
         return 0;
     }
@@ -139 +139 @@
 
 BarnOwl::filter(qw{facebook type ^facebook$});
+BarnOwl::bindkey(qw(recv f command facebook));
 
 sub complete_user { return keys %{$facebook_handle->{friends}}; }

perl/modules/Facebook/lib/BarnOwl/Module/Facebook/Handle.pm

@@ -26 +26 @@
         my @words = split(' ', lc($sentence));
         return () unless @words;
-        return (reduce{ length($a) > length($b) ? $a : $b } @words,);
+        return (reduce { length($a) > length($b) ? $a : $b } @words);
     };
 } else {
@@ -71 +71 @@
 
     my $self = {
-        'cfg'  => $cfg,
+        'cfg' => $cfg,
         'facebook' => undef,
 
@@ -238 +238 @@
     return unless $self->{logged_in};
 
-    # XXX Oh no! This blocks the user interface.  Not good.
-    # Ideally, we should have some worker thread for polling facebook.
-    # But BarnOwl is probably not thread-safe >_<
-
     my $old_topics = $self->{topics};
     $self->{topics} = {};
@@ -289 +285 @@
             }
 
+            # XXX The intent is to get the 'Comment' link, which also
+            # serves as a canonical link to the post.  The {name}
+            # field should equal 'Comment'.  But we don't check
+            # this, we assume that the first element is the right one.
             my $link = $post->{actions}[0]{link};
 
@@ -294 +294 @@
             my $created_time = str2time($post->{created_time});
             if ($created_time >= $self->{last_poll}) {
-                # XXX indexing is fragile
                 my $msg = BarnOwl::Message->new(
                     type      => 'Facebook',
@@ -302 +301 @@
                     name_id   => $name_id,
                     direction => 'in',
-                    body      => $self->format_body($post),
+                    body      => wordwrap($self->format_body($post)),
                     post_id   => $post_id,
                     topic     => $topic,
                     time      => asctime(localtime $created_time),
-                    # XXX The intent is to get the 'Comment' link, which also
-                    # serves as a canonical link to the post.  The {name}
-                    # field should equal 'Comment'.
                     permalink => $link,
                    );
@@ -331 +327 @@
                         name_id   => $name_id,
                         direction => 'in',
-                        body      => $comment->{message},
+                        body      => wordwrap($comment->{message}),
                         post_id   => $post_id,
                         topic     => $topic,
@@ -348 +344 @@
         $self->{last_poll} = $new_last_poll;
     });
+}
+
+sub wordwrap {
+    my $text = shift;
+    return BarnOwl::wordwrap($text, BarnOwl::getvar('edit:maxwrapcols'));
 }
 
@@ -431 +432 @@
     $self->facebook_do_auth(sub {
         my $raw_cfg = to_json($self->{cfg});
-        BarnOwl::admin_message('Facebook', "Add this as the contents of your ~/.owl/facebook file:\n$raw_cfg");
+        my $cfg_file;
+        unless (open($cfg_file, ">", BarnOwl::get_config_dir() . "/facebook")) {
+          BarnOwl::admin_message('Facebook', "Add this as the contents of your ~/.owl/facebook file:\n$raw_cfg");
+          return;
+        }
+        print $cfg_file $raw_cfg;
+        close $cfg_file;
+        BarnOwl::admin_message('Facebook', "Saved your login credentials to ~/.owl/facebook.");
     });
     return;