Changeset 7fd450f for perlglue.xs

Timestamp:

Mar 1, 2010, 8:33:47 PM (14 years ago)

Author:

Nelson Elhage <nelhage@mit.edu>

Branches:

release-1.5

Children:

7d6a751

Parents:

65fca7a0

git-author:

Nelson Elhage <nelhage@mit.edu> (01/19/10 22:53:08)

git-committer:

Nelson Elhage <nelhage@mit.edu> (03/01/10 20:33:47)

Message:

perlglue.xs: Copy passed-in SV*s before storing them.

Perl gives us a pointer to the same SV* that the caller was using, so
if the caller mutates it in some way after the call, it affects our
saved copy. This is definitely not what we want.

Reported-by: William Throwe <wthrowe@MIT.EDU>

File:

• perlglue.xs (modified) (6 diffs)

perlglue.xs

@@ -179 +179 @@
                 owl_function_start_question(line);
 
-                owl_editwin_set_cbdata(owl_global_get_typwin(&g), SvREFCNT_inc(callback));
+                owl_editwin_set_cbdata(owl_global_get_typwin(&g), newSVsv(callback));
                 owl_editwin_set_callback(owl_global_get_typwin(&g), owl_perlconfig_edit_callback);
         }
@@ -195 +195 @@
                 owl_function_start_password(line);
 
-                owl_editwin_set_cbdata(owl_global_get_typwin(&g), SvREFCNT_inc(callback));
+                owl_editwin_set_cbdata(owl_global_get_typwin(&g), newSVsv(callback));
                 owl_editwin_set_callback(owl_global_get_typwin(&g), owl_perlconfig_edit_callback);
         }
@@ -208 +208 @@
                         croak("Callback must be a subref");
 
-                owl_function_start_edit_win(line, owl_perlconfig_edit_callback, SvREFCNT_inc(callback));
+                owl_function_start_edit_win(line, owl_perlconfig_edit_callback, newSVsv(callback));
         }
 
@@ -279 +279 @@
         {
                 s = owl_malloc(sizeof(owl_style));
-                owl_style_create_perl(s, name, object);
+                owl_style_create_perl(s, name, sv_2mortal(newSVsv(object)));
                 owl_global_add_style(&g, s);
         }
@@ -444 +444 @@
                 }
                 cmd.name = name;
-                cmd.cmd_perl = SvREFCNT_inc(func);
+                cmd.cmd_perl = newSVsv(func);
                 cmd.summary = summary;
                 cmd.usage = usage;
@@ -504 +504 @@
         SV * cb
         CODE:
-        owl_select_add_perl_io_dispatch(fd, mode, SvREFCNT_inc(cb));
+        owl_select_add_perl_io_dispatch(fd, mode, newSVsv(cb));
 
 IV