Changes in perl/modules/Jabber/lib/BarnOwl/Module/Jabber.pm [aa0a0b5:8789410]

File:

• perl/modules/Jabber/lib/BarnOwl/Module/Jabber.pm (modified) (27 diffs)

perl/modules/Jabber/lib/BarnOwl/Module/Jabber.pm

@@ -285 +285 @@
         {
             summary => "Send a Jabber Message",
-            usage   => "jwrite <jid> [-t <thread>] [-s <subject>] [-a <account>] [-m <message>]"
+            usage   => "jwrite <jid> [-t <thread>] [-s <subject>] [-a <account>]"
         }
     );
@@ -308 +308 @@
             description => "jmuc sends Jabber commands related to MUC.\n\n"
               . "The following commands are available\n\n"
-              . "join <muc>[/<nick>]\n"
-              . "            Join a MUC (with a given nickname, or otherwise your JID).\n\n"
+              . "join <muc>  Join a MUC.\n\n"
               . "part <muc>  Part a MUC.\n"
               . "            The MUC is taken from the current message if not supplied.\n\n"
@@ -378 +377 @@
         my $cjidStr = $conn->baseJIDExists($jidStr);
         if ($cjidStr) {
-            die("Already logged in as $cjidStr.\n");
+            BarnOwl::error("Already logged in as $cjidStr.");
+            return;
         }
     }
@@ -387 +387 @@
 
     if ( !$uid || !$componentname ) {
-        die("usage: $cmd JID\n");
+        BarnOwl::error("usage: $cmd JID");
+        return;
     }
 
     if ( $conn->jidActive($jidStr) ) {
-        die("Already logged in as $jidStr.\n");
+        BarnOwl::error("Already logged in as $jidStr.");
+        return;
     } elsif ($conn->jidExists($jidStr)) {
         return $conn->tryReconnect($jidStr, 1);
@@ -524 +526 @@
 sub cmd_jlist {
     if ( !( scalar $conn->getJIDs() ) ) {
-        die("You are not logged in to Jabber.\n");
+        BarnOwl::error("You are not logged in to Jabber.");
+        return;
     }
     BarnOwl::popless_ztext( onGetBuddyList() );
@@ -531 +534 @@
 sub cmd_jwrite {
     if ( !$conn->connected() ) {
-        die("You are not logged in to Jabber.\n");
+        BarnOwl::error("You are not logged in to Jabber.");
+        return;
     }
 
@@ -539 +543 @@
     my $jwrite_thread  = "";
     my $jwrite_subject = "";
-    my $jwrite_body;
     my ($to, $from);
     my $jwrite_type    = "chat";
@@ -551 +554 @@
         'subject=s' => \$jwrite_subject,
         'account=s' => \$from,
-        'id=s'      => \$jwrite_sid,
-        'message=s' => \$jwrite_body,
+        'id=s'     =>  \$jwrite_sid,
     ) or die("Usage: jwrite <jid> [-t <thread>] [-s <subject>] [-a <account>]\n");
     $jwrite_type = 'groupchat' if $gc;
 
     if ( scalar @ARGV != 1 ) {
-        die("Usage: jwrite <jid> [-t <thread>] [-s <subject>] [-a <account>]\n");
+        BarnOwl::error(
+            "Usage: jwrite <jid> [-t <thread>] [-s <subject>] [-a <account>]");
+        return;
     }
     else {
@@ -566 +570 @@
 
     unless(scalar @candidates) {
-        die("Unable to resolve JID $to\n");
+        die("Unable to resolve JID $to");
     }
 
@@ -573 +577 @@
     unless(scalar @candidates) {
         if(!$from) {
-            die("You must specify an account with -a\n");
+            die("You must specify an account with -a");
         } else {
-            die("Unable to resolve account $from\n");
+            die("Unable to resolve account $from");
         }
     }
@@ -590 +594 @@
         type    => $jwrite_type
     };
-
-    if (defined($jwrite_body)) {
-        process_owl_jwrite($jwrite_body);
-        return;
-    }
 
     if(scalar @candidates > 1) {
@@ -632 +631 @@
     my $func = $jmuc_commands{$cmd};
     if ( !$func ) {
-        die("jmuc: Unknown command: $cmd\n");
+        BarnOwl::error("jmuc: Unknown command: $cmd");
+        return;
     }
 
@@ -654 +654 @@
         }
         else {
-            die("You must specify an account with -a <jid>\n");
+            BarnOwl::error('You must specify an account with -a <jid>');
         }
         return $func->( $jid, $muc, @ARGV );
@@ -667 +667 @@
 
     $muc = shift @ARGV
-      or die("Usage: jmuc join <muc> [-p <password>] [-a <account>]\n");
+      or die("Usage: jmuc join <muc> [-p <password>] [-a <account>]");
 
     die("Error: Must specify a fully-qualified MUC name (e.g. barnowl\@conference.mit.edu)\n")
@@ -680 +680 @@
                                                    MaxChars => 0
                                                   });
-    $completion_jids{$muc->GetJID('base')} = 1;
+    $completion_jids{$muc} = 1;
     return;
 }
@@ -688 +688 @@
 
     $muc = shift @args if scalar @args;
-    die("Usage: jmuc part [<muc>] [-a <account>]\n") unless $muc;
+    die("Usage: jmuc part [<muc>] [-a <account>]") unless $muc;
 
     if($conn->getConnectionFromJID($jid)->MUCLeave(JID => $muc)) {
         queue_admin_msg("$jid has left $muc.");
     } else {
-        die("Error: Not joined to $muc\n");
+        die("Error: Not joined to $muc");
     }
 }
@@ -703 +703 @@
     $muc = shift @args if scalar @args;
 
-    die("Usage: jmuc invite <jid> [<muc>] [-a <account>]\n")
+    die('Usage: jmuc invite <jid> [<muc>] [-a <account>]')
       unless $muc && $invite_jid;
 
@@ -718 +718 @@
     my ( $jid, $muc, @args ) = @_;
     $muc = shift @args if scalar @args;
-    die("Usage: jmuc configure [<muc>]\n") unless $muc;
+    die("Usage: jmuc configure [<muc>]") unless $muc;
     my $iq = Net::Jabber::IQ->new();
     $iq->SetTo($muc);
@@ -759 +759 @@
 
     $muc = shift @args if scalar @args;
-    die("Usage: jmuc presence [<muc>]\n") unless $muc;
+    die("Usage: jmuc presence [<muc>]") unless $muc;
 
     if ($muc eq '-a') {
@@ -774 +774 @@
     else {
         my $m = $conn->getConnectionFromJID($jid)->FindMUC(jid => $muc);
-        die("No such muc: $muc\n") unless $m;
+        die("No such muc: $muc") unless $m;
         BarnOwl::popless_ztext(jmuc_presence_single($m));
     }
@@ -801 +801 @@
     my $func = $jroster_commands{$cmd};
     if ( !$func ) {
-        die("jroster: Unknown command: $cmd\n");
+        BarnOwl::error("jroster: Unknown command: $cmd");
+        return;
     }
 
@@ -824 +825 @@
         }
         else {
-            die("You must specify an account with -a <jid>\n");
+            BarnOwl::error('You must specify an account with -a <jid>');
         }
         return $func->( $jid, $name, \@groups, $purgeGroups,  @ARGV );
@@ -848 +849 @@
     }
     else {
-        die("You must specify an account with -a <jid>\n");
+        BarnOwl::error('You must specify an account with -a <jid>');
     }
 
@@ -1233 +1234 @@
         $completion_jids{$room} = 1;
 
-        my $muc;
-        if ($dir eq 'in') {
-            my $connection = $conn->getConnectionFromSid($props{sid});
-            $muc = $connection->FindMUC(jid => $from);
-        } else {
-            my $connection = $conn->getConnectionFromJID($props{from});
-            $muc = $connection->FindMUC(jid => $to);
-        }
-        $props{from} = $muc->GetFullJID($from) || $nick || $room;
         $props{sender} = $nick || $room;
         $props{recipient} = $room;
@@ -1339 +1331 @@
         return $givenJIDStr if ($conn->jidExists($givenJIDStr) );
         return resolveConnectedJID($givenJID->GetJID('base')) if $loose;
-        die("Invalid account: $givenJIDStr\n");
+        die("Invalid account: $givenJIDStr");
     }
 
@@ -1392 +1384 @@
         # Not one of ours.
         else {
-            die("Invalid account: $givenJIDStr\n");
+            die("Invalid account: $givenJIDStr");
         }
 
@@ -1438 +1430 @@
     if($from) {
         $from_jid = resolveConnectedJID($from, 1);
-        die("Unable to resolve account $from\n") unless $from_jid;
+        die("Unable to resolve account $from") unless $from_jid;
         $to_jid = resolveDestJID($to, $from_jid);
         push @matches, [$from_jid, $to_jid] if $to_jid;