Changeset 8b62088

Timestamp:

Sep 20, 2011, 11:15:31 PM (13 years ago)

Author:

Edward Z. Yang <ezyang@mit.edu>

Branches:

master, release-1.10, release-1.9

Children:

65c2b3c

Parents:

eb20731

git-author:

Edward Z. Yang <ezyang@mit.edu> (06/22/11 18:30:55)

git-committer:

Edward Z. Yang <ezyang@mit.edu> (09/20/11 23:15:31)

Message:

Add autocomplete and wall-posting support.

Signed-off-by: Edward Z. Yang <ezyang@mit.edu>

Location:

perl/modules/Facebook

Files:

• README (modified) (1 diff)
• lib/BarnOwl/Module/Facebook.pm (modified) (2 diffs)
• lib/BarnOwl/Module/Facebook/Handle.pm (modified) (7 diffs)

perl/modules/Facebook/README

@@ -32 +32 @@
     and blocks the entire BarnOwl interface.  We need to confront
     Perl's threading demon.
-  * Need to detect if you have two friends with the same name and
-    disambiguate if so.
-  * No messaging support.
-  * No auto-completion support.
-  * No posting to an arbitrary user's wall.
-  * See code comments for more work items!
+  * No messaging support. (We'll add it when Facebook makes the new endpoint.)
+  * Smarter name de-duplication (see code comments for details.)
+  * Grep for XXX and TODO for more work items.
 
 TECHNICAL NOTES

perl/modules/Facebook/lib/BarnOwl/Module/Facebook.pm

@@ -123 +123 @@
 sub cmd_facebook {
     my $cmd = shift;
-    BarnOwl::start_edit_win("What's on your mind?", sub{ facebook(shift) });
-    # User prompt for other person's wall is "Write something..." which
-    # we will ostensibly check for soon.
+    my $user = shift;
+
+    BarnOwl::start_edit_win(
+        defined $user ? "Write something to $user..." : "What's on your mind?",
+        sub{ facebook($user, shift) }
+    );
 }
 
@@ -156 +159 @@
 BarnOwl::filter(qw{facebook type ^facebook$});
 
+# Autocompletion support
+
+sub complete_user { return keys %{$facebook_handle->{friends}}; }
+BarnOwl::Completion::register_completer(facebook => sub { complete_user(@_) });
+
 1;

perl/modules/Facebook/lib/BarnOwl/Module/Facebook/Handle.pm

@@ -80 +80 @@
         'facebook' => undef,
 
+        # Ideally this should be done using Facebook realtime updates,
+        # but we can't assume that the BarnOwl lives on a publically
+        # addressable server (XXX maybe we can setup an option for this.)
+        'last_friend_poll' => 0,
+        'friend_timer' => undef,
+
         # Initialized with our 'time', but will be synced to Facebook
-        # soon enough.
+        # soon enough. (Subtractive amount is just to preseed with some
+        # values.)
         'last_poll' => time - 60 * 60 * 24 * 2,
         'timer' => undef,
@@ -100 +107 @@
         # would need another hash for topic de-dup
         'topics' => {},
+
+        # deduplicated map of names to user ids
+        'friends' => {},
     };
 
@@ -125 +135 @@
 
     # Stop any existing timers.
+    if (defined $self->{friend_timer}) {
+        $self->{friend_timer}->stop;
+        $self->{friend_timer} = undef;
+    }
     if (defined $self->{timer}) {
         $self->{timer}->stop;
@@ -135 +149 @@
     }
 
+    $self->{friend_timer} = BarnOwl::Timer->new({
+        name     => "Facebook friend poll",
+        after    => $delay,
+        interval => 60 * 60 * 24,
+        cb       => sub { $weak->poll_friends if $weak }
+       });
     $self->{timer} = BarnOwl::Timer->new({
         name     => "Facebook poll",
@@ -142 +162 @@
        });
     # XXX implement message polling
+}
+
+sub poll_friends {
+    my $self = shift;
+
+    return unless BarnOwl::getvar('facebook:poll') eq 'on';
+    return unless $self->{logged_in};
+
+    my $friends = eval { $self->{facebook}->fetch('me/friends'); };
+    if ($@) {
+        warn "Poll failed $@";
+        return;
+    }
+
+    $self->{last_friend_poll} = time;
+    $self->{friends} = {};
+
+    for my $friend ( @{$friends->{data}} ) {
+        if (defined $self->{friends}{$friend->{name}}) {
+            # XXX We should try a little harder here, rather than just
+            # tacking on a number.  Ideally, we should be able to
+            # calculate some extra piece of information that the user
+            # needs to disambiguate between the two users.  An old
+            # version of Facebook used to disambiguate with your primary
+            # network (so you might have Edward Yang (MIT) and Edward
+            # Yang (Cambridge), the idea being that users in the same
+            # network would probably have already disambiguated
+            # themselves with middle names or nicknames.  We no longer
+            # get network information, since Facebook axed that
+            # information, but the Education/Work fields may still be
+            # a reasonable approximation (but which one do you pick?!
+            # The most recent one.)  Since getting this information
+            # involves extra queries, there are also caching and
+            # efficiency concerns.
+            #   We may want a facility for users to specify custom
+            # aliases for Facebook users, which are added into this
+            # hash.  See also username support.
+            warn "Duplicate friend name " . $friend->{name};
+            my $name = $friend->{name};
+            my $i = 2;
+            while (defined $self->{friends}{$friend->{name} . ' ' . $i}) { $i++; }
+            $self->{friends}{$friend->{name} . ' ' . $i} = $friend->{id};
+        } else {
+            $self->{friends}{$friend->{name}} = $friend->{id};
+        }
+    }
+
+    # XXX We should also have support for usernames, and not just real
+    # names. However, since this data is not returned by the friends
+    # query, it would require a rather expensive set of queries. We
+    # might try to preserve old data, but all-in-all it's a bit
+    # complicated, so we don't bother.
 }
 
@@ -283 +355 @@
     my $self = shift;
 
+    my $user = shift;
     my $msg = shift;
-    my $reply_to = shift;
 
     if (!defined $self->{facebook} || !$self->{logged_in}) {
@@ -290 +362 @@
         return;
     }
-    $self->{facebook}->add_post->set_message( $msg )->publish;
+    if (defined $user) {
+        $user = $self->{friends}{$user} || $user;
+        $self->{facebook}->add_post( $user )->set_message( $msg )->publish;
+    } else {
+        $self->{facebook}->add_post->set_message( $msg )->publish;
+    }
     $self->sleep(0);
 }