Changeset 8fec514

Timestamp:

Oct 12, 2002, 12:46:42 PM (22 years ago)

Author:

James M. Kretchmar <kretch@mit.edu>

Branches:

master, barnowl_perlaim, debian, owl, release-1.10, release-1.4, release-1.5, release-1.6, release-1.7, release-1.8, release-1.9

Children:

a3ba748

Parents:

aa2f6364

Message:

Fixed memory access bug in new outgoing message creation

Files:

• functions.c (modified) (3 diffs)
• message.c (modified) (2 diffs)

functions.c

@@ -96 +96 @@
   owl_message_create_from_zwriteline(m, zwriteline, body, zsig);
 
-  /* add it to the global list */
+  /* add it to the global list and current view */
   owl_messagelist_append_element(owl_global_get_msglist(&g), m);
   owl_view_consider_message(owl_global_get_current_view(&g), m);
@@ -154 +154 @@
 
 void owl_function_zwrite(char *line) {
-  char buff[1024];
   owl_zwrite z;
   int i, j;
@@ -165 +164 @@
   /* display the message as an outgoing message in the receive window */
   if (owl_global_is_displayoutgoing(&g) && owl_zwrite_is_personal(&z)) {
-    owl_zwrite_get_recipstr(&z, buff);
     owl_function_make_outgoing_zephyr(owl_editwin_get_text(owl_global_get_typwin(&g)), line, owl_zwrite_get_zsig(&z));
   }

message.c

@@ -437 +437 @@
   owl_message_set_direction_out(m);
   owl_message_set_type_zephyr(m);
-  m->sender=owl_strdup(ZGetSender());
-  m->class=owl_strdup(owl_zwrite_get_class(&z));
-  m->inst=owl_strdup(owl_zwrite_get_instance(&z));
+  owl_message_set_sender(m, ZGetSender());
+  owl_message_set_class(m, owl_zwrite_get_class(&z));
+  owl_message_set_instance(m, owl_zwrite_get_instance(&z));
   m->recip=long_zuser(owl_zwrite_get_recip_n(&z, 0)); /* only gets the first user, must fix */
-  m->opcode=owl_strdup(owl_zwrite_get_opcode(&z));
+  owl_message_set_opcode(m, owl_zwrite_get_opcode(&z));
   m->realm=owl_strdup(owl_zwrite_get_realm(&z)); /* also a hack, but not here */
   m->zwriteline=owl_strdup(line);
   m->body=owl_strdup(body);
-  m->zsig=owl_strdup(zsig);
+  owl_message_set_zsig(m, zsig);
   
   /* save the hostname */
@@ -499 +499 @@
   owl_fmtext_append_normal(&(m->fmtext), "  (Zsig: ");
 
-  zsigbuff=owl_malloc(strlen(owl_message_get_zsig(m)));
+  zsigbuff=owl_malloc(strlen(owl_message_get_zsig(m))+30);
   owl_message_pretty_zsig(m, zsigbuff);
   owl_fmtext_append_ztext(&(m->fmtext), zsigbuff);