Changeset 94be4a8

Timestamp:

Jun 3, 2010, 2:19:28 AM (15 years ago)

Author:

David Benjamin <davidben@mit.edu>

Branches:

master, release-1.10, release-1.7, release-1.8, release-1.9

Children:

cc36f27

Parents:

d6f2d21

Message:

Add a command-executed signal for the sepbar

Now we can remove sepbar_dirty()

Files:

• cmd.c (modified) (3 diffs)
• globalnotifier.h (modified) (1 diff)
• globalnotifiergen.pl (modified) (3 diffs)
• sepbar.c (modified) (1 diff)

cmd.c

@@ -4 +4 @@
 #include <unistd.h>
 #include "owl.h"
+#include "globalnotifier.h"
 
 extern const owl_cmd commands_to_init[];
@@ -73 +74 @@
   } else if (NULL != (cmd = owl_dict_find_element(cd, argv[0]))) {
     retval = owl_cmd_execute(cmd, cd, ctx, argc, argv, buff);
+    /* This really should be attached to the cmd or cmddict... */
+    owl_global_notifier_emit_command_executed(g.gn);
   } else {
     owl_function_makemsg("Unknown command '%s'.", buff);
@@ -103 +106 @@
   owl_parse_delete(argv, argc);
   owl_free(tmpbuff);
-  sepbar_dirty();
   return retval;
 }

globalnotifier.h

@@ -41 +41 @@
 void owl_global_notifier_emit_view_changed(OwlGlobalNotifier *gn);
 void owl_global_notifier_emit_message_received(OwlGlobalNotifier *gn, owl_message *msg);
+void owl_global_notifier_emit_command_executed(OwlGlobalNotifier *gn);
 
 G_END_DECLS

globalnotifiergen.pl

@@ -55 +55 @@
   VIEW_CHANGED,
   MESSAGE_RECEIVED,
+  COMMAND_EXECUTED,
   LAST_SIGNAL
 };
@@ -181 +182 @@
                  1,
                  G_TYPE_POINTER, NULL);
+
+  notifier_signals[COMMAND_EXECUTED] =
+    g_signal_new("command-executed",
+                 G_TYPE_FROM_CLASS(gobject_class),
+                 G_SIGNAL_RUN_FIRST,
+                 0,
+                 NULL, NULL,
+                 g_cclosure_marshal_VOID__VOID,
+                 G_TYPE_NONE,
+                 0,
+                 NULL);
 
   /* Register properties */
@@ -276 +288 @@
   g_signal_emit(gn, notifier_signals[MESSAGE_RECEIVED], 0, msg);
 }
-EOT
+
+void owl_global_notifier_emit_command_executed(OwlGlobalNotifier *gn)
+{
+  g_signal_emit(gn, notifier_signals[COMMAND_EXECUTED], 0);
+}
+
+EOT

sepbar.c

@@ -7 +7 @@
   g_signal_connect(w, "redraw", G_CALLBACK(sepbar_redraw), NULL);
   owl_dirty_window_on_signal(w, g.gn, "message-received");
+  owl_dirty_window_on_signal(w, g.gn, "command-executed");
   owl_window_dirty(w);
-}
-
-void sepbar_dirty(void)
-{
-  owl_window_dirty(owl_global_get_curs_sepwin(&g));
 }