Changeset 9625c55

Timestamp:

Aug 16, 2017, 12:53:41 PM (7 years ago)

Author:

Jason Gross <jasongross9@gmail.com>

Branches:

master

Children:

3222df2

Parents:

54c5395

git-author:

Jason Gross <jgross@mit.edu> (08/03/17 15:29:32)

git-committer:

Jason Gross <jasongross9@gmail.com> (08/16/17 12:53:41)

Message:

Silence "Use of uninitialized value $realm in uc"

Files:

• perl/lib/BarnOwl/Message/Zephyr.pm (modified) (1 diff)
• t/BarnOwl_Message_Zephyr.t (modified) (1 diff)

perl/lib/BarnOwl/Message/Zephyr.pm

@@ -28 +28 @@
     # characters; this way, we always get at least '@' in $user
     my ($user, $realm) = split(/(?<=@)(?=[^@]+$)/, $principal);
-    return lc($user) . uc($realm);
+    $user = '' if !defined $user;
+    $user = lc($user);
+    $user = $user . uc($realm) if defined $realm;
+    return $user;
 }
 

t/BarnOwl_Message_Zephyr.t

@@ -24 +24 @@
 }
 
-test_casefold_principal('');
-test_casefold_principal('FOO');
+test_casefold_principal('', '');
+test_casefold_principal('FOO', '');
 test_casefold_principal('FOO', 'athena.mit.edu');
 test_casefold_principal('FOO@BAR', 'athena.mit.edu');