Changeset 9820d55 for perl/modules/Facebook/lib/Facebook/Graph/Response.pm

Timestamp:

Sep 19, 2011, 1:31:35 PM (13 years ago)

Author:

Edward Z. Yang <ezyang@mit.edu>

Children:

c104b43

Parents:

cfca761

git-author:

Edward Z. Yang <ezyang@mit.edu> (07/12/11 09:17:04)

git-committer:

Edward Z. Yang <ezyang@mit.edu> (09/19/11 13:31:35)

Message:

Convert to async (both Facebook::Graph and us.)

Work items:
    - Documentation is all out of date
    - Think more carefully about error handling
      (right now it's delayed into the response object)
    - Really bad HTTP POST hack in Publish.pm.

Signed-off-by: Edward Z. Yang <ezyang@mit.edu>

File:

• perl/modules/Facebook/lib/Facebook/Graph/Response.pm (modified) (3 diffs)

perl/modules/Facebook/lib/Facebook/Graph/Response.pm

@@ -13 +13 @@
 );
 
+has headers => (
+    is      => 'ro',
+    required=> 1,
+);
+
+has uri => (
+    is      => 'ro',
+    required=> 1,
+);
+
 has as_string => (
     is      => 'ro',
@@ -18 +28 @@
     default => sub {
         my $self = shift;
-        return $self->response->content;
+        if (!defined $self->response) {
+            ouch $self->headers->{Status}, $self->headers->{Reason}, $self->uri;
+        }
+        if ($self->headers->{Status} < 200 || $self->headers->{Status} >= 300) {
+            my $type = $self->headers->{Status};
+            my $message = $self->response;
+            my $error = eval { JSON->new->decode($self->response) };
+            unless ($@) {
+                $type = $error->{error}{type};
+                $message = $error->{error}{message};
+            }
+            ouch $type, 'Could not execute request ('.$self->uri.'): '.$message, $self->uri;
+        }
+        return $self->response;
     },
 );
@@ -27 +50 @@
     default => sub {
         my $self = shift;
-        my $response = $self->response;
-        if ($response->is_success) {
-            return $response->content;
-        }
-        else {
-            my $message = $response->message;
-            my $error = eval { JSON->new->decode($response->content) };
-            unless ($@) {
-                $message = $error->{error}{type} . ' - ' . $error->{error}{message};
-            }
-            ouch $response->code, 'Could not execute request ('.$response->request->uri->as_string.'): '.$message, $response->request->uri->as_string;
-        }
+        return $self->as_string;
     },
 );