Changeset 9ae6095

Timestamp:

Jan 23, 2014, 6:24:58 PM (11 years ago)

Author:

Nelson Elhage <nelhage@nelhage.com>

Branches:

master, release-1.10

Children:

a2ae85a, 61ad0cb2, cba6b9c, 2e42098

Parents:

c53f5e8 (diff), 140429f (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge pull request #160 from nelhage/twitter

Some misc twitter fixes and improvements

Location:

perl/modules/Twitter/lib/BarnOwl/Module

Files:

• Twitter.pm (modified) (3 diffs)
• Twitter/Handle.pm (modified) (2 diffs)

perl/modules/Twitter/lib/BarnOwl/Module/Twitter.pm

@@ -137 +137 @@
         my $twitter_args = { username   => $cfg->{user},
                              password   => $cfg->{password},
-                             source     => 'barnowl', 
+                             source     => 'barnowl',
                              ssl        => 1,
+                             legacy_lists_api => 0,
                          };
         if (defined $cfg->{service}) {
@@ -275 +276 @@
 );
 
+BarnOwl::new_command( 'twitter-favorite' => sub { cmd_twitter_favorite(@_) },
+    {
+    summary     => 'Favorite the current Twitter message',
+    usage       => 'twitter-favorite [ACCOUNT]',
+    description => <<END_DESCRIPTION
+Favorite the current Twitter message using ACCOUNT (defaults to the
+account that received the tweet).
+END_DESCRIPTION
+    }
+);
+
 BarnOwl::new_command( 'twitter-follow' => sub { cmd_twitter_follow(@_); },
     {
@@ -356 +368 @@
     $account = $m->account unless defined($account);
     find_account($account)->twitter_retweet($m);
+    return;
+}
+
+sub cmd_twitter_favorite {
+    my $cmd = shift;
+    my $account = shift;
+    my $m = BarnOwl::getcurmsg();
+    if(!$m || $m->type ne 'Twitter') {
+        die("$cmd must be used with a Twitter message selected.\n");
+    }
+
+    $account = $m->account unless defined($account);
+    find_account($account)->twitter_favorite($m);
     return;
 }

perl/modules/Twitter/lib/BarnOwl/Module/Twitter/Handle.pm

@@ -371 +371 @@
         $self->twitter_direct($1, $2);
     } elsif(defined $self->{twitter}) {
-        if(length($msg) > 140) {
-            die("Twitter: Message over 140 characters long.\n");
-        }
         $self->twitter_command('update', {
             status => $msg,
@@ -432 +429 @@
 }
 
+sub twitter_favorite {
+    my $self = shift;
+    my $msg = shift;
+
+    if($msg->service ne $self->{cfg}->{service}) {
+        die("Cannot favorite a message from a different service.\n");
+    }
+    $self->twitter_command(create_favorite => $msg->{status_id});
+}
+
+
 sub twitter_follow {
     my $self = shift;