Changeset 9eb38bb

Timestamp:

Sep 18, 2010, 5:07:39 PM (14 years ago)

Author:

David Benjamin <davidben@mit.edu>

Branches:

master, release-1.10, release-1.7, release-1.8, release-1.9

Children:

d574d61

Parents:

8ee712e0

git-author:

David Benjamin <davidben@mit.edu> (08/01/10 14:09:34)

git-committer:

David Benjamin <davidben@mit.edu> (09/18/10 17:07:39)

Message:

Likewise, don't reuse a global owl_viewwin

This means we don't have to support plugging and unplugging that thing
over and over. We also can almost entirely drop the global owl_viewwin.
Most of the code gets it from the context anyway.

Files:

• commands.c (modified) (1 diff)
• functions.c (modified) (4 diffs)
• global.c (modified) (2 diffs)
• owl.h (modified) (1 diff)
• popexec.c (modified) (2 diffs)
• viewwin.c (modified) (6 diffs)

commands.c

@@ -2772 +2772 @@
   pw = owl_global_get_popwin(&g);
   owl_global_set_popwin(&g, NULL);
-  owl_viewwin_cleanup(vw);
+  /* Kind of a hack, but you can only have one active viewwin right
+   * now anyway. */
+  if (vw == owl_global_get_viewwin(&g))
+    owl_global_set_viewwin(&g, NULL);
+  owl_viewwin_delete(vw);
   owl_popwin_delete(pw);
   owl_global_pop_context(&g);

functions.c

@@ -1237 +1237 @@
   owl_viewwin *v;
 
-  v=owl_global_get_viewwin(&g);
-
-  if (owl_global_get_popwin(&g)) {
+  if (owl_global_get_popwin(&g) || owl_global_get_viewwin(&g)) {
     owl_function_error("Popwin already in use.");
     return;
@@ -1246 +1244 @@
   owl_global_set_popwin(&g, pw);
   owl_popwin_up(pw);
+
+  v = owl_viewwin_new_text(owl_popwin_get_content(pw), text);
+  owl_global_set_viewwin(&g, v);
+
   owl_global_push_context(&g, OWL_CTX_POPLESS, v, "popless", NULL);
-  owl_viewwin_init_text(v, owl_popwin_get_content(pw), text);
 }
 
@@ -1255 +1256 @@
   owl_viewwin *v;
 
-  v=owl_global_get_viewwin(&g);
-
-  if (owl_global_get_popwin(&g)) {
+  if (owl_global_get_popwin(&g) || owl_global_get_viewwin(&g)) {
     owl_function_error("Popwin already in use.");
     return;
@@ -1264 +1263 @@
   owl_global_set_popwin(&g, pw);
   owl_popwin_up(pw);
+
+  v = owl_viewwin_new_fmtext(owl_popwin_get_content(pw), fm);
+  owl_global_set_viewwin(&g, v);
+
   owl_global_push_context(&g, OWL_CTX_POPLESS, v, "popless", NULL);
-  owl_viewwin_init_fmtext(v, owl_popwin_get_content(pw), fm);
 }
 

global.c

@@ -49 +49 @@
 
   g->pw = NULL;
+  g->vw = NULL;
   g->tw = NULL;
 
@@ -492 +493 @@
 
 owl_viewwin *owl_global_get_viewwin(owl_global *g) {
-  return(&(g->vw));
+  return g->vw;
+}
+
+void owl_global_set_viewwin(owl_global *g, owl_viewwin *vw) {
+  g->vw = vw;
 }
 

owl.h

@@ -596 +596 @@
   void *buffercbdata;
   owl_editwin *tw;
-  owl_viewwin vw;
+  owl_viewwin *vw;
   void *perl;
   int debug;

popexec.c

@@ -17 +17 @@
   pid_t pid;
 
-  if (owl_global_get_popwin(&g)) {
+  if (owl_global_get_popwin(&g) || owl_global_get_viewwin(&g)) {
     owl_function_error("Popwin already in use.");
     return NULL;
@@ -28 +28 @@
   pe->refcount=0;
 
-  pe->vwin=v=owl_global_get_viewwin(&g);
   pw = owl_popwin_new();
   owl_global_set_popwin(&g, pw);
   owl_popwin_up(pw);
+  pe->vwin = v = owl_viewwin_new_text(owl_popwin_get_content(pw), "");
+  owl_global_set_viewwin(&g, v);
+  owl_viewwin_set_onclose_hook(v, owl_popexec_viewwin_onclose, pe);
 
   owl_global_push_context(&g, OWL_CTX_POPLESS, v, "popless", NULL);
-  owl_viewwin_init_text(v, owl_popwin_get_content(pw), "");
-  owl_viewwin_set_onclose_hook(v, owl_popexec_viewwin_onclose, pe);
   pe->refcount++;
 

viewwin.c

@@ -7 +7 @@
 static void owl_viewwin_set_window(owl_viewwin *v, owl_window *w);
 
-/* initialize the viewwin e.  'win' is an already initialzed curses
- * window that will be used by viewwin
+/* Create a viewwin.  'win' is an already initialized owl_window that
+ * will be used by the viewwin
  */
-void owl_viewwin_init_text(owl_viewwin *v, owl_window *win, const char *text)
+owl_viewwin *owl_viewwin_new_text(owl_window *win, const char *text)
 {
+  owl_viewwin *v = owl_malloc(sizeof(owl_viewwin));
+  memset(v, 0, sizeof(*v));
   owl_fmtext_init_null(&(v->fmtext));
   if (text) {
@@ -25 +27 @@
 
   owl_viewwin_set_window(v, win);
+  return v;
 }
 
@@ -42 +45 @@
 }
 
-/* initialize the viewwin e.  'win' is an already initialzed curses
- * window that will be used by viewwin
+/* Create a viewwin.  'win' is an already initialized owl_window that
+ * will be used by the viewwin
  */
-void owl_viewwin_init_fmtext(owl_viewwin *v, owl_window *win, const owl_fmtext *fmtext)
+owl_viewwin *owl_viewwin_new_fmtext(owl_window *win, const owl_fmtext *fmtext)
 {
   char *text;
+  owl_viewwin *v = owl_malloc(sizeof(owl_viewwin));
+  memset(v, 0, sizeof(*v));
 
   owl_fmtext_copy(&(v->fmtext), fmtext);
@@ -60 +65 @@
 
   owl_viewwin_set_window(v, win);
+  return v;
 }
 
 static void owl_viewwin_set_window(owl_viewwin *v, owl_window *w)
 {
-  if (v->window) {
-    g_signal_handler_disconnect(v->window, v->sig_redraw_id);
-    g_object_unref(v->window);
-  }
   v->window = w;
   if (w) {
@@ -181 +183 @@
 }
 
-void owl_viewwin_cleanup(owl_viewwin *v)
+void owl_viewwin_delete(owl_viewwin *v)
 {
-  owl_viewwin_set_window(v, NULL);
   if (v->onclose_hook) {
     v->onclose_hook(v, v->onclose_hook_data);
@@ -189 +190 @@
     v->onclose_hook_data = NULL;
   }
+  if (v->window) {
+    g_signal_handler_disconnect(v->window, v->sig_redraw_id);
+    g_object_unref(v->window);
+    v->window = NULL;
+  }
   owl_fmtext_cleanup(&(v->fmtext));
+  owl_free(v);
 }