Changeset a03a409

Timestamp:

Mar 11, 2012, 10:58:00 PM (12 years ago)

Author:

David Benjamin <davidben@mit.edu>

Branches:

master, release-1.10, release-1.9

Children:

d199207

Parents:

97cdbaf5

git-author:

Anders Kaseorg <andersk@mit.edu> (01/19/12 21:22:29)

git-committer:

David Benjamin <davidben@mit.edu> (03/11/12 22:58:00)

Message:

zephyr: Add an iterator interface to fields

Signed-off-by: Anders Kaseorg <andersk@mit.edu>

File:

• zephyr.c (modified) (2 diffs)

zephyr.c

@@ -516 +516 @@
 }
 
-/* return a pointer to the data in the Jth field, (NULL terminated by
- * definition).  Caller must free the return.
- */
-#ifdef HAVE_LIBZEPHYR
+#ifdef HAVE_LIBZEPHYR
+const char *owl_zephyr_first_raw_field(const ZNotice_t *n)
+{
+  if (n->z_message_len == 0)
+    return NULL;
+  return n->z_message;
+}
+
+const char *owl_zephyr_next_raw_field(const ZNotice_t *n, const char *f)
+{
+  const char *end = n->z_message + n->z_message_len;
+  f = memchr(f, '\0', end - f);
+  if (f == NULL)
+    return NULL;
+  return f + 1;
+}
+
+const char *owl_zephyr_get_raw_field(const ZNotice_t *n, int j)
+{
+  int i;
+  const char *f;
+  for (i = 1, f = owl_zephyr_first_raw_field(n); i < j && f != NULL;
+       i++, f = owl_zephyr_next_raw_field(n, f))
+    ;
+  return f;
+}
+
+CALLER_OWN char *owl_zephyr_field(const ZNotice_t *n, const char *f)
+{
+  if (f == NULL)
+    return g_strdup("");
+  return g_strndup(f, n->z_message + n->z_message_len - f);
+}
+
+CALLER_OWN char *owl_zephyr_field_as_utf8(const ZNotice_t *n, const char *f)
+{
+  char *tmp = owl_zephyr_field(n, f);
+  char *out = owl_validate_or_convert(tmp);
+  g_free(tmp);
+  return out;
+}
+
 CALLER_OWN char *owl_zephyr_get_field(const ZNotice_t *n, int j)
 {
-  int i, count, save;
-
-  /* If there's no message here, just run along now */
-  if (n->z_message_len == 0)
-    return(g_strdup(""));
-
-  count=save=0;
-  for (i=0; i<n->z_message_len; i++) {
-    if (n->z_message[i]=='\0') {
-      count++;
-      if (count==j) {
-        /* just found the end of the field we're looking for */
-        return(g_strdup(n->z_message+save));
-      } else {
-        save=i+1;
-      }
-    }
-  }
-  /* catch the last field, which might not be null terminated */
-  if (count==j-1) {
-    return g_strndup(n->z_message + save, n->z_message_len - save);
-  }
-
-  return(g_strdup(""));
+  return owl_zephyr_field(n, owl_zephyr_get_raw_field(n, j));
 }
 
 CALLER_OWN char *owl_zephyr_get_field_as_utf8(const ZNotice_t *n, int j)
 {
-  int i, count, save;
-
-  /* If there's no message here, just run along now */
-  if (n->z_message_len == 0)
-    return(g_strdup(""));
-
-  count=save=0;
-  for (i = 0; i < n->z_message_len; i++) {
-    if (n->z_message[i]=='\0') {
-      count++;
-      if (count == j) {
-        /* just found the end of the field we're looking for */
-        return(owl_validate_or_convert(n->z_message + save));
-      } else {
-        save = i + 1;
-      }
-    }
-  }
-  /* catch the last field, which might not be null terminated */
-  if (count == j - 1) {
-    char *tmp, *out;
-    tmp = g_strndup(n->z_message + save, n->z_message_len - save);
-    out = owl_validate_or_convert(tmp);
-    g_free(tmp);
-    return out;
-  }
-
-  return(g_strdup(""));
-}
-#else
-CALLER_OWN char *owl_zephyr_get_field(void *n, int j)
-{
-  return(g_strdup(""));
-}
-CALLER_OWN char *owl_zephyr_get_field_as_utf8(void *n, int j)
-{
-  return owl_zephyr_get_field(n, j);
+  return owl_zephyr_field_as_utf8(n, owl_zephyr_get_raw_field(n, j));
+}
+#else
+const char *owl_zephyr_first_raw_field(const void *n)
+{
+  return NULL;
+}
+
+const char *owl_zephyr_next_raw_field(const void *n, const char *f)
+{
+  return NULL;
+}
+
+const char *owl_zephyr_get_raw_field(const void *n, int j)
+{
+  return NULL;
+}
+
+CALLER_OWN char *owl_zephyr_field(const void *n, const char *f)
+{
+  return g_strdup("");
+}
+
+CALLER_OWN char *owl_zephyr_field_as_utf8(const void *n, const char *f)
+{
+  return g_strdup("");
+}
+
+CALLER_OWN char *owl_zephyr_get_field(const void *n, int j)
+{
+  return g_strdup("");
+}
+
+CALLER_OWN char *owl_zephyr_get_field_as_utf8(const void *n, int j)
+{
+  return owl_zephyr_field(n, owl_zephyr_get_raw_field(n, j));
 }
 #endif
@@ -594 +608 @@
 int owl_zephyr_get_num_fields(const ZNotice_t *n)
 {
-  int i, fields;
-
-  if(n->z_message_len == 0)
-    return 0;
-
-  fields=1;
-  for (i=0; i<n->z_message_len; i++) {
-    if (n->z_message[i]=='\0') fields++;
-  }
-  
-  return(fields);
+  int i;
+  const char *f;
+  for (i = 0, f = owl_zephyr_first_raw_field(n); f != NULL;
+       i++, f = owl_zephyr_next_raw_field(n, f))
+    ;
+  return i;
 }
 #else