Changeset a130fc5

Timestamp:

Jul 9, 2011, 4:11:45 PM (13 years ago)

Author:

Jason Gross <jgross@mit.edu>

Branches:

master, release-1.10, release-1.8, release-1.9

Children:

176d2c75, 4168fb8, 220db88, 820e852, 4bf2a11, 976e58a

Parents:

efeec7f

git-author:

Jason Gross <jgross@mit.edu> (05/23/11 19:23:05)

git-committer:

Jason Gross <jgross@mit.edu> (07/09/11 16:11:45)

Message:

Improved ability to delete messages from perl

BarnOwl::Message now has a delete_and_expunge command, and
BarnOwl::queue_message returns the queued message, so that deletion
actually works; there used to be no way to get the id of a queued
message, and so ->delete() didn't actually do anything...

Files:

• perl/lib/BarnOwl.pm (modified) (1 diff)
• perl/lib/BarnOwl/Message.pm (modified) (1 diff)
• perlglue.xs (modified) (2 diffs)

perl/lib/BarnOwl.pm

@@ -105 +105 @@
 Enqueue a message in the BarnOwl message list, logging it and
 processing it appropriately. C<MESSAGE> should be an instance of
-BarnOwl::Message or a subclass.
+BarnOwl::Message or a subclass.  Returns the queued message.  This
+is useful for, e.g., deleting a message from the message list.
 
 =head2 admin_message HEADER BODY

perl/lib/BarnOwl/Message.pm

@@ -81 +81 @@
 sub short_personal_context { return ""; }
 
+sub delete_and_expunge {
+    my ($m) = @_;
+    &BarnOwl::command("delete-and-expunge --quiet --id " . $m->id);
+}
+
 sub delete {
     my ($m) = @_;

perlglue.xs

@@ -143 +143 @@
                 g_free(rv);
 
-void
+SV *
 queue_message(msg)
         SV *msg
@@ -157 +157 @@
 
                 owl_global_messagequeue_addmsg(&g, m);
-        }
+
+                RETVAL = owl_perlconfig_message2hashref(m);
+        }
+        OUTPUT:
+                RETVAL
 
 void