Changeset acdd52e

Timestamp:

May 7, 2009, 5:12:56 PM (15 years ago)

Author:

Nelson Elhage <nelhage@mit.edu>

Branches:

master, release-1.10, release-1.7, release-1.8, release-1.9

Children:

b56f2c3

Parents:

b25b5a4

Message:

Correctly tag replies with the in_reply_to_status_id parameter.

Location:

lib/BarnOwl

Files:

• Message/Twitter.pm (modified) (1 diff)
• Module/Twitter.pm (modified) (4 diffs)

lib/BarnOwl/Message/Twitter.pm

@@ -21 +21 @@
     if($self->is_private) {
         return $self->replysendercmd;
+    } elsif(exists($self->{status_id})) {
+        return 'twitter-atreply ' . $self->sender . " " . $self->{status_id};
     } else {
-        return 'twitter-atreply '.$self->sender;
+        return 'twitter-atreply ' . $self->sender;
     }
 }

lib/BarnOwl/Module/Twitter.pm

@@ -183 +183 @@
                 source    => decode_entities($tweet->{source}),
                 location  => decode_entities($tweet->{user}{location}||""),
-                body      => decode_entities($tweet->{text})
+                body      => decode_entities($tweet->{text}),
+                status_id => $tweet->{id}
                );
             BarnOwl::queue_message($msg);
@@ -227 +228 @@
 sub twitter {
     my $msg = shift;
+    my $reply_to = shift;
+
     if($msg =~ m{\Ad\s+([^\s])+(.*)}sm) {
         twitter_direct($1, $2);
     } elsif(defined $twitter) {
-        $twitter->update($msg);
+        $twitter->update({
+            status => $msg,
+            defined($reply_to) ? (in_reply_to_status_id => $reply_to) : ()
+           });
     }
 }
@@ -258 +264 @@
 sub twitter_atreply {
     my $to  = shift;
+    my $id  = shift;
     my $msg = shift;
-    twitter("@".$to." ".$msg);
+    if(defined($id)) {
+        twitter("@".$to." ".$msg, $id);
+    } else {
+        twitter("@".$to." ".$msg);
+    }
 }
 
@@ -303 +314 @@
 sub cmd_twitter_atreply {
     my $cmd  = shift;
-    my $user = shift;
-    BarnOwl::start_edit_win("Reply to \@" . $user, sub { twitter_atreply($user, shift) });
+    my $user = shift || die("Usage: $cmd USER [In-Reply-To ID]\n");
+    my $id   = shift;
+    BarnOwl::start_edit_win("Reply to \@" . $user, sub { twitter_atreply($user, $id, shift) });
 }