Changeset b381b55

Timestamp:

Mar 1, 2010, 8:33:48 PM (15 years ago)

Author:

Nelson Elhage <nelhage@mit.edu>

Branches:

release-1.5

Children:

54e1fe4

Parents:

b22170c

git-author:

Anders Kaseorg <andersk@mit.edu> (02/08/10 22:40:45)

git-committer:

Nelson Elhage <nelhage@mit.edu> (03/01/10 20:33:48)

Message:

zcrypt: Don’t leak the body after decrypting a message.

This fixes a leak noticed by nelhage.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Reviewed-by: Nelson Elhage <nelhage@mit.edu>

File:

• message.c (modified) (1 diff)

message.c

@@ -846 +846 @@
     out=owl_malloc(strlen(owl_message_get_body(m))*16+20);
     ret=owl_zcrypt_decrypt(out, owl_message_get_body(m), owl_message_get_class(m), owl_message_get_instance(m));
-    if (ret==0) {
+    if (ret == 0)
       owl_message_set_body(m, out);
-    } else {
-      owl_free(out);
-    }
+    owl_free(out);
   }
 #endif