Changeset b7ee89b

Timestamp:

Oct 17, 2009, 6:08:15 PM (15 years ago)

Author:

Karl Ramm <kcr@1ts.org>

Branches:

master, release-1.10, release-1.5, release-1.6, release-1.7, release-1.8, release-1.9

Children:

6ea3890

Parents:

435001d

git-author:

Karl Ramm <kcr@1ts.org> (09/24/09 11:05:55)

git-committer:

Karl Ramm <kcr@1ts.org> (10/17/09 18:08:15)

Message:

Cleanup and use owl_getline{,_chomp} and owl_slurp

Files:

• functions.c (modified) (7 diffs)
• zephyr.c (modified) (7 diffs)

functions.c

@@ -1363 +1363 @@
   owl_fmtext fm;
   FILE *file;
-  char buff[1024];
+  char *s = NULL;
 
   file=fopen(filename, "r");
@@ -1372 +1372 @@
 
   owl_fmtext_init_null(&fm);
-  while (fgets(buff, 1024, file)) {
-    owl_fmtext_append_normal(&fm, buff);
-    /*    owl_fmtext_append_normal(&fm, "\n"); */
-  }
+  while (owl_getline(&s, file))
+    owl_fmtext_append_normal(&fm, s);
+  owl_free(s);
 
   owl_function_popless_fmtext(&fm);
@@ -2022 +2021 @@
   const char *redirect = " 2>&1 < /dev/null";
   char *newbuff;
-  char *out, buff2[1024];
-  int size;
+  char *out;
   FILE *p;
 
@@ -2041 +2039 @@
     owl_popexec_new(newbuff);
   } else {
-    p=popen(newbuff, "r");
-    out=owl_malloc(1024);
-    size=1024;
-    strcpy(out, "");
-    while (fgets(buff2, 1024, p)!=NULL) {
-      size+=1024;
-      out=owl_realloc(out, size);
-      strcat(out, buff2);
-    }
+    p = popen(newbuff, "r");
+    out = owl_slurp(p);
     pclose(p);
     
@@ -3338 +3329 @@
   char *path;
   FILE *file;
-  char buff[LINE];
+  char *s = NULL;
   int fail_silent = 0;
 
@@ -3347 +3338 @@
     path = owl_util_makepath(filename);
   }
-  file=fopen(path, "r");
+  file = fopen(path, "r");
   owl_free(path);
   if (!file) {
@@ -3355 +3346 @@
     return;
   }
-  while (fgets(buff, LINE, file)!=NULL) {
-    if (buff[0] == '\0' || buff[0] == '#') continue;
-    if (buff[strlen(buff) - 1] == '\n')
-      buff[strlen(buff) - 1] = '\0';
-    owl_function_command(buff);
-  }
+  while (owl_getline_chomp(&s, file)) {
+    if (s[0] == '\0' || s[0] == '#')
+      continue;
+    owl_function_command(s);
+  }
+
+  owl_free(s);
   fclose(file);
 }

zephyr.c

@@ -246 +246 @@
   FILE *file;
   char *tmp, *start;
-  char buffer[1024], subsfile[1024];
+  char *buffer = NULL;
+  char *subsfile;
   ZSubscription_t *subs;
   int subSize = 1024;
-  int count, ret;
+  int count;
   struct stat statbuff;
 
   subs = owl_malloc(sizeof(ZSubscription_t) * subSize);
-  if (filename==NULL) {
-    sprintf(subsfile, "%s/%s", owl_global_get_homedir(&g), ".zephyr.subs");
-  } else {
-    strcpy(subsfile, filename);
-  }
-
-  ret=stat(subsfile, &statbuff);
-  if (ret) {
-    if (error_on_nofile==1) return(-1);
-    return(0);
+  if (filename == NULL)
+    subsfile = owl_sprintf("%s/.zephyr.subs", owl_global_get_homedir(&g));
+  else
+    subsfile = owl_strdup(filename);
+
+  if (stat(subsfile, &statbuff) != 0) {
+    if (error_on_nofile == 1)
+      return -1;
+    return 0;
   }
 
   ZResetAuthentication();
-  count=0;
-  file=fopen(subsfile, "r");
-  if (!file) return(-1);
-  while ( fgets(buffer, 1024, file)!=NULL ) {
-    if (buffer[0]=='#' || buffer[0]=='\n' || buffer[0]=='\n') continue;
-    
-    if (buffer[0]=='-') {
-      start=buffer+1;
-    } else {
-      start=buffer;
-    }
-    
+  count = 0;
+  file = fopen(subsfile, "r");
+  owl_free(subsfile);
+  if (!file)
+    return -1;
+  while (owl_getline(&buffer, file)) {
+    if (buffer[0] == '#' || buffer[0] == '\n')
+        continue;
+
+    if (buffer[0] == '-')
+      start = buffer + 1;
+    else
+      start = buffer;
+
     if (count >= subSize) {
       subSize *= 2;
@@ -284 +286 @@
     
     /* add it to the list of subs */
-    if ((tmp=strtok(start, ",\n\r"))==NULL) continue;
-    subs[count].zsub_class=owl_strdup(tmp);
-    if ((tmp=strtok(NULL, ",\n\r"))==NULL) continue;
-    subs[count].zsub_classinst=owl_strdup(tmp);
-    if ((tmp=strtok(NULL, " \t\n\r"))==NULL) continue;
-    subs[count].zsub_recipient=owl_strdup(tmp);
-    
+    if ((tmp = strtok(start, ",\n\r")) == NULL)
+      continue;
+    subs[count].zsub_class = owl_strdup(tmp);
+    if ((tmp=strtok(NULL, ",\n\r")) == NULL)
+      continue;
+    subs[count].zsub_classinst = owl_strdup(tmp);
+    if ((tmp = strtok(NULL, " \t\n\r")) == NULL)
+      continue;
+    subs[count].zsub_recipient = owl_strdup(tmp);
+
     /* if it started with '-' then add it to the global punt list, and
      * remove it from the list of subs. */
-    if (buffer[0]=='-') {
+    if (buffer[0] == '-') {
       owl_function_zpunt(subs[count].zsub_class, subs[count].zsub_classinst, subs[count].zsub_recipient, 0);
       owl_free(subs[count].zsub_class);
       owl_free(subs[count].zsub_classinst);
       owl_free(subs[count].zsub_recipient);
-    }
-    else {
+    } else {
       count++;
     }
   }
   fclose(file);
-
-  ret = owl_zephyr_loadsubs_helper(subs, count);
-  return(ret);
-#else
-  return(0);
+  if (buffer)
+    owl_free(buffer);
+
+  return owl_zephyr_loadsubs_helper(subs, count);
+#else
+  return 0;
 #endif
 }
@@ -362 +367 @@
   ZSubscription_t *subs;
   int numSubs = 100;
-  char subsfile[1024], buffer[1024];
-  int count, ret;
+  char *subsfile;
+  char *buffer = NULL;
+  int count;
   struct stat statbuff;
 
   subs = owl_malloc(numSubs * sizeof(ZSubscription_t));
 
-  if (filename==NULL) {
-    sprintf(subsfile, "%s/%s", owl_global_get_homedir(&g), ".anyone");
-  } else {
-    strcpy(subsfile, filename);
-  }
-  
-  ret=stat(subsfile, &statbuff);
-  if (ret) return(0);
-
-  ret=0;
+  if (filename==NULL)
+    subsfile = owl_sprintf("%s/%s", owl_global_get_homedir(&g), ".anyone");
+  else
+    subsfile = owl_strdup(filename);
+
+  if (stat(subsfile, &statbuff) == -1)
+    return 0;
 
   ZResetAuthentication();
-  count=0;
-  file=fopen(subsfile, "r");
+  count = 0;
+  file = fopen(subsfile, "r");
+  owl_free(subsfile);
   if (file) {
-    while ( fgets(buffer, 1024, file)!=NULL ) {
-      if (buffer[0] == '\0' || buffer[0] == '#' || buffer[0] == '\n') continue;
-      
+    while (owl_getline_chomp(&buffer, file)) {
+      if (buffer[0] == '\0' || buffer[0] == '#')
+        continue;
+
       if (count == numSubs) {
         numSubs *= 2;
@@ -391 +396 @@
       }
 
-      if (buffer[strlen(buffer) - 1] == '\n')
-        buffer[strlen(buffer) - 1] = '\0';
-      subs[count].zsub_class=owl_strdup("login");
-      subs[count].zsub_recipient=owl_strdup("*");
-      if (strchr(buffer, '@')) {
-        subs[count].zsub_classinst=owl_strdup(buffer);
-      } else {
-        subs[count].zsub_classinst=owl_sprintf("%s@%s", buffer, ZGetRealm());
-      }
+      subs[count].zsub_class = owl_strdup("login");
+      subs[count].zsub_recipient = owl_strdup("*");
+      subs[count].zsub_classinst = long_zuser(buffer);
 
       count++;
@@ -405 +404 @@
     fclose(file);
   } else {
-    count=0;
-    ret=-1;
-  }
-
-  ret = owl_zephyr_loadsubs_helper(subs, count);
-  return(ret);
-#else
-  return(0);
+    return 0;
+  }
+  if (buffer)
+    owl_free(buffer);
+
+  return owl_zephyr_loadsubs_helper(subs, count);
+#else
+  return 0;
 #endif
 }
@@ -953 +952 @@
 {
 #ifdef HAVE_LIBZEPHYR
-  char *line, subsfile[LINE], buff[LINE];
+  char *line, *subsfile, *s = NULL;
   FILE *file;
-
-  line=owl_zephyr_makesubline(class, inst, recip);
-
-  if (filename==NULL) {
-    sprintf(subsfile, "%s/%s", owl_global_get_homedir(&g), ".zephyr.subs");
-  } else {
-    strcpy(subsfile, filename);
-  }
+  int duplicate = 0;
+
+  line = owl_zephyr_makesubline(class, inst, recip);
+
+  if (filename == NULL)
+    subsfile = owl_sprintf("%s/.zephyr.subs", owl_global_get_homedir(&g));
+  else
+    subsfile = owl_strdup(filename);
 
   /* if the file already exists, check to see if the sub is already there */
-  file=fopen(subsfile, "r");
+  file = fopen(subsfile, "r");
   if (file) {
-    while (fgets(buff, LINE, file)!=NULL) {
-      if (!strcasecmp(buff, line)) {
+    while (owl_getline(&s, file)) {
+      if (strcasecmp(s, line) == 0) {
         owl_function_error("Subscription already present in %s", subsfile);
-        owl_free(line);
-        fclose(file);
-        return;
+        duplicate++;
       }
     }
     fclose(file);
-  }
-
-  /* if we get here then we didn't find it */
-  file=fopen(subsfile, "a");
-  if (!file) {
-    owl_function_error("Error opening file %s for writing", subsfile);
-    owl_free(line);
-    return;
-  }
-  fputs(line, file);
-  fclose(file);
-  owl_function_makemsg("Subscription added");
-  
+    owl_free(s);
+  }
+
+  if (!duplicate) {
+    file = fopen(subsfile, "a");
+    if (file) {
+      fputs(line, file);
+      fclose(file);
+      owl_function_makemsg("Subscription added");
+    } else {
+      owl_function_error("Error opening file %s for writing", subsfile);
+    }
+  }
+
   owl_free(line);
 #endif
@@ -1277 +1275 @@
 {
 #ifdef HAVE_LIBZEPHYR
-  char *ourfile, *tmp, buff[LINE];
+  char *ourfile, *tmp, *s = NULL;
   FILE *f;
 
-  if (filename==NULL) {
-    ourfile=owl_sprintf("%s/.anyone", owl_global_get_homedir(&g));
-  } else {
-    ourfile=owl_strdup(filename);
-  }
-  
-  f=fopen(ourfile, "r");
+  if (filename == NULL)
+    ourfile = owl_sprintf("%s/.anyone", owl_global_get_homedir(&g));
+  else
+    ourfile = owl_strdup(filename);
+
+  f = fopen(ourfile, "r");
   if (!f) {
     owl_function_error("Error opening file %s: %s", ourfile, strerror(errno) ? strerror(errno) : "");
     owl_free(ourfile);
-    return(-1);
-  }
-
-  while (fgets(buff, LINE, f)!=NULL) {
+    return -1;
+  }
+  owl_free(ourfile);
+
+  while (owl_getline_chomp(&s, f)) {
     /* ignore comments, blank lines etc. */
-    if (buff[0]=='#') continue;
-    if (buff[0]=='\n') continue;
-    if (buff[0]=='\0') continue;
-    
-    /* strip the \n */
-    buff[strlen(buff)-1]='\0';
-    
-    /* ingore from # on */
-    tmp=strchr(buff, '#');
-    if (tmp) tmp[0]='\0';
-    
-    /* ingore from SPC */
-    tmp=strchr(buff, ' ');
-    if (tmp) tmp[0]='\0';
-    
-    /* stick on the local realm. */
-    if (!strchr(buff, '@')) {
-      strcat(buff, "@");
-      strcat(buff, ZGetRealm());
-    }
-    owl_list_append_element(in, owl_strdup(buff));
+    if (s[0] == '#' || s[0] == '\0')
+      continue;
+
+    /* ignore from # on */
+    tmp = strchr(s, '#');
+    if (tmp)
+      tmp[0] = '\0';
+
+    /* ignore from SPC */
+    tmp = strchr(s, ' ');
+    if (tmp)
+      tmp[0] = '\0';
+
+    owl_list_append_element(in, long_zuser(s));
   }
   fclose(f);
-  owl_free(ourfile);
-  return(0);
-#else
-  return(-1);
+  return 0;
+#else
+  return -1;
 #endif
 }